From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbcHSJyr (ORCPT ); Fri, 19 Aug 2016 05:54:47 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:37925 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbcHSJyq (ORCPT ); Fri, 19 Aug 2016 05:54:46 -0400 Subject: Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration To: Russell King - ARM Linux References: <20160819063424.16383-1-peter.ujfalusi@ti.com> <20160819085404.GI1041@n2100.armlinux.org.uk> CC: Mark Brown , Liam Girdwood , , , Tony Lindgren , From: Peter Ujfalusi Message-ID: Date: Fri, 19 Aug 2016 12:54:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160819085404.GI1041@n2100.armlinux.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/19/16 11:54, Russell King - ARM Linux wrote: > On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote: >> The dmic-codec was registered within the platform_driver's probe function, >> which can cause deferred probe to run in loops as reported and analyzed by >> Russell King. >> >> Use module_init/exit in the driver and handle the dmic-codec device >> registration and removal at that level instead of the platform_driver >> probe/remove. >> >> Signed-off-by: Peter Ujfalusi >> Reported-by: Russell King > > I think this address came from memory... it's certainly not the one that > I'm using today. ;) I'm really sorry. I have one txt file where I store e-mail addresses when I'm lazy to look them up in my mailbox. txt updated. Mark: can you fix Russell's e-mail addrress to: linux@armlinux.org.uk Or I can resend the patch. > >> --- > > This certainly fixes the problem: > > VUSB: disabling > mmcblk0: mmc0:0002 00000 972 MiB > ALSA device list: > mmcblk0: p1 p2 > No soundcards found. > omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered > omap-abe-twl6040 sound: snd_soc_register_card() failed: -517 > Waiting 2 sec before mounting root device... > EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem > EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended > > and allows booting to continue. Thanks. > > Tested-by: Russell King > -- Péter