From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752223AbdK1NLM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 08:11:12 -0500
Received: from mout.web.de ([212.227.15.4]:49610 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751443AbdK1NLK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 08:11:10 -0500
Subject: Re: [alsa-devel] ALSA: nm256: Fine-tuning for three function
 implementations
To: Ondrej Zary <linux@rainbow-software.org>, alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>, Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <d98a2685-ddf9-1cba-839a-d12c5ff8d3ba@users.sourceforge.net>
 <s5hbmjmluba.wl-tiwai@suse.de>
 <2cbef557-5f89-c630-e108-14ef2ce6b41a@users.sourceforge.net>
 <201711281333.15131.linux@rainbow-software.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d5573b12-7e52-7f62-11b4-07558152eed2@users.sourceforge.net>
Date: Tue, 28 Nov 2017 14:10:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <201711281333.15131.linux@rainbow-software.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:zE8KNlgvQo7an74Swli5OmdLhscakOkvJZYpVGV6TdCHBFrRZyk
 AimZhQXYFO+OUuVbe3X1/80vGIfDZr0m286L6w0xnDkCqdzm9y8rUO8MX5RitQYp3mSKcAt
 X9YKvzbywtb7l5npKzwiQC0yRHQmeJgtPlNjxmcLDQrCT/w4k04PB8NR9+Ll6mpLg6T+No2
 tRzgoxhDBW894OVRpMVlw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:BLJBPQ1jIzs=:DiPWQyclwcBcnLn87UFUdc
 p0L6NYwxOWFmbolshED9sRA7WyqRhnzBKYAtZbcV0mCoz67BSBb2dH8/CNH3FWQP6NbFAt4oH
 K2TtLRPc2g8emGw/SqFeJqxS2LV/lwh/k0VudS4gDd2JhmFuaqK3dmlHG8ctzQPmG8/GmFqDc
 J6lPTbIpI1n70mePbhzUyL/OVQ9yvRPA4fJs1QnueeBKOCepw60ddCFnsE9+4qF78zgZxrWNz
 Q7XJ94svA/GP2wDPY50qlXNQsW/QToD0bAxF4+6TM3n4S7Hv8ox1uNQ+mb625d/+ugjK5VDC/
 ADNxJsgYEAYtyy0qmQEVqv/kGS2FsK8cT5rlqiSJS5dLVw64tiFZK8cqiokBsRCPEu1joGfzd
 C9t0X8ndkbrY0Ta9+gX/pk7oV0NE0dwd2Anzy+zJeVGOaB+iIOcyxKPGNYuXf6fpXfhmBoe2E
 tpvJl1aSEYju2B5EGb2W+XEuC2RJPGl87nHYNCvjzI2wQGzQdtwTe+Rh5Hfsc0sbDuRrNS+rG
 KsDqSuyrFGdx2NMMe/fhxl/G2RKvQDR1j42jU7T0NWBowdxqYO+1mRXcJkxZ+zmK40csJXjvx
 57CMi2ZqmH8t84kX0egssUg5T3r6qMfaLgic/scmrg+F7tlr8+e2pNX7KUtOUEJP6BY5a4uBI
 C038ruIibHhs5SdYFTrZJqCZBdAnjSJGd/Atid4C3QKiXpKy5XgVb4tbafAaGOF2oYZuCLYxo
 pL8iMADnSkM8QOAk+aJsBYTQbXr1pt3ojArdyUFpeKk5jSZwzxD3EVHnn5pdjcib2IO42Sh/J
 TfmNBsJ1hNGgpJPB3hs50wFtNYCXe20pxStNRtDO8jRQDarDrg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Can you get the impression that the shown transformation patterns were
>> correctly applied for the source file “sound/pci/nm256/nm256.c”?
> 
> Have you tested the driver?

Which results do you expect from a corresponding system test?


> Please don't "improve" working drivers unless

I am trying to improve software components also for devices to which
I have not got direct access so far.


> Patches like this are known to cause regressions.

Do you prefer to keep this software area “frozen” anyhow?


> If the hardware is rare (like the NM256), the regression can hit years later
> when someone with such HW upgrades distro (e.g. Debian stable).

Have you got any resources to reduce corresponding concerns?

Regards,
Markus