From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794926351; b=URyu+N/rOIzVw9TfEGiMGVOCXJYdwKScRunGYG3GaYldUBpzTSEOpD49CWFhHdiOO+0x 6FvuLprMXc9bZhwu1IF0eaoXXu3+PjN+CMcPe5TcvEa/cXxZ+sdOvTF9dp3YQh6xZmhIv tILMV9J0rzFLveBaZJawey7Oy42OMHQYVkJo7y4F1R33Efv733DScxxPs+davZnp9r8lk TckSL69aHHOJ6R4U/s4vyR+e2FBgYKtlqBgEaKxSAnhsMLuNiDozO7IAdf0wLLx9CfMDG X/Sq89amkQN0dcqpgHJfD1VQA1X5l889a27O8tv87bkABFJ4fsZeIk7aK0sqqLbRwjA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794926351; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info: X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=J/4vLvyNqeORXrBPoXGUzzn2IETQe9KRQ40Tt84ca5g=; b=1vVQXlpT6lztNiSAaUDxmtrco9WzIlKpaHtSb3WdWFDqeopP6vw2g3wGf6BNRn0KAPge uFEYUHGdMcNpKYLwNz9rlZE20cwbaC8ZNJpfKONS8om/YC3nGZafHyUjhYj6t0I/lHPfb dUHzFl6InCh2FcBZBVpIIr/QvwSTb7nLW4teojaenKpdgknWwqRf5XecXczOXXitx6VEL um+77LtPGeOqwWNTLjZ0R/4JnkYsQQGM4gbYWjgh4ISsLJbPuVPv/V9OUXs1cL1bl5ICB b9YeK6yx/X2PBFAHB8mAvYzZXHjI+d+cUDFzBC2oO1Zpu0vTO+Y1QM8CLRuyziQQ5CQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=RaZdnNrX; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=I2eYdPIa; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F18A606A31C for ; Tue, 17 Nov 2026 14:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8F18A606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=RaZdnNrX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=I2eYdPIa Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AHDEIbl626672 for ; Tue, 17 Nov 2026 14:39:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J/4vLvyNqeORXrBPoXGUzzn2IETQe9KRQ40Tt84ca5g=; b=RaZdnNrXIXuujHIL b9gDY6DkKpfcXz3+RtJMNcSG2CBbjvyZvwfuE3SPA1MzNtWuWLPkv0xOk3corQGb 9hnsSeU//oJ8Xfddv4H2/ry7020h+5yagaaVpQpSz7oxja90XPUrw1XDo/8PBigI CALjD9jco/hHbq+V9D9XRgpEh5T2P6iWO+x71wV/QuYtotFLUcispWkEaAg0pAqU 7hmUtvgFJJtB/jnoLUIArmuG01TjjmN1fdT2x3Ak/n/0OvWhffI4K5jOktBNlKu8 PPDe1XT16GpXB9ydVlfUIORhu1hKDnkSYLosgk+VlfZG4A3AUDfcz0iY11Kt/oO+ py7HgA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0qms0c24-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Nov 2026 14:39:04 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7d2c7428eb2so677114137.2 for ; Tue, 17 Nov 2026 06:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794926344; x=1795531144; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J/4vLvyNqeORXrBPoXGUzzn2IETQe9KRQ40Tt84ca5g=; b=I2eYdPIawMDuzDv8t8nyVyMKHJBCpnsseE6P92OcAlApTbDGO86XNhM4CJib78ZQ3/ 0zxxPDDwVxubVpkREA2V/q8Ao/QicgYvYiqfNYFJalPfdhNPQHNYw4e/dvX6XiiqSdJv I37jEB4waTNWfvOm9n2pWgbVNgd9jsVqap+c59iizmhMpSq/ta5Jtdz4FiNX3a876ODU S9FyZHrmLeUZBUDlJCe3JgTXRzQyVwnTx1Ykcjcy2jdE1pwqWuNsIRCYzdgqob2UqKBM IEZSuPbXFX4czfGlTagrAvAbQgn/t6nNEQpSGIqTPu89+ZxXXHLfkVCijoDPu97MH3dI FINA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794926344; x=1795531144; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J/4vLvyNqeORXrBPoXGUzzn2IETQe9KRQ40Tt84ca5g=; b=Qtl+skNhGbariySYqRhUrRxKrEEmFOgjnvy0l9KAzjrWn2BmyR8IMQxw8fcMbhqILl 4kGYYGty6WgSOcdw+oHxOx0ulUuUYwrDswn/PXl6trOKq3uLcqp7hvUwS3DuxTrqVEw4 GY67lG5Tjoz+1s9JZDRAcZw1vtmM+DKGQbB8qOiwTRlrqK7YzlOVcUiisQatWyn+teXm OTw2SGdsjigY8Vjy5GnRV5F73icIjGmSSmV8cXQy3PHOr3U07t8NbftvBYhjzzjgUavA t3SyCJCRg5wvSS16DtZCRkinN/h0IqGsOOPRbvEifLwFFjwUl5r2/Hz+E4rwAwGHlAq+ XkMw== X-Forwarded-Encrypted: i=1; AL+hErHlHDLtFK2nNkT22XTYcJgq6gQeNe6Z4oxdEkEmMcsr+cK8C9nhVLc7ICQEBJGBR+C5V9MKNi+WR3/Jgg4=@vger.kernel.org X-Gm-Message-State: APuU4Z/zpU8jWb0SIpJaeQuz89LHT9vCd1kC4Tr/io0tO5weIX8OTJOR vbuDZhenJTvfDEKNbT/xFUttuUbmVSyhJUMmjQDgI0IFUntsizP3faNmkJkaPD6tpKsLksvIX92 TRLfundF6glGToU2i5TqNos3yy3arppwgy5J4DcVvQlZNiq1cV4HJibeKmBEXD40rWTI= X-Gm-Gg: AYBFou1a0FmwuMnj71onegjMsdkBRoGcJ1g5P7fGm70LB6DMsrax5lblFDHoxuoVsqL 3/SPxDE0BlL+9C5QA7/cICb/5Y1OybeHowKNEvejPu770Cl6nj7Cx7MkEWWeqkTVcPyGmqRmh3D mCLCuGDC/uS4TeWkgg1udqKFYOaogYAg/WFKSGmb+2eXK/Gd+ZXzZrA+BjivaNUIuUu3+s2ICzp 6mfwKK6Ffijjf8tzQ8g1XdbUqn2w+CeZCbRBEI1bhMuWA0mLHW563H7psHjRt0tPvE+URNe1lU7 pS51hJzGhny0hBIJNlZIprg4yMJchOdrUAp7q9HQcjzCCPe/s1xzCtSFXSa7IDvOwdRKkQav/++ Rso8dzxDZhLX5u39uSQioOcZKt88vsJ0aKvAAil8H+UwO+qu88YtkiWYkmfORLjclBuKFbW7x0j VItywB X-Received: by 2002:a05:6102:6050:b0:7d6:48c4:ed56 with SMTP id ada2fe7eead31-7d64d69dbf2mr3523234137.6.1794926343472; Tue, 17 Nov 2026 06:39:03 -0800 (PST) X-Received: by 2002:a05:6102:6050:b0:7d6:48c4:ed56 with SMTP id ada2fe7eead31-7d64d69dbf2mr3523224137.6.1794926342900; Tue, 17 Nov 2026 06:39:02 -0800 (PST) Received: from [10.218.50.86] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-7d69e02d340sm2636416137.8.2026.11.17.06.38.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 06:39:02 -0800 (PST) Message-ID: Date: Tue, 17 Nov 2026 20:08:54 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier To: Krzysztof Kozlowski Cc: Mark Brown , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org References: <20261106-qspi_upstream_series-v1-0-21f43042dd60@oss.qualcomm.com> <20261106-qspi_upstream_series-v1-2-21f43042dd60@oss.qualcomm.com> <20261109-wandering-miraculous-mamba-0cf21a@quoll> <2fc8f7ea-651e-466e-9346-c47e0a38c5bb@oss.qualcomm.com> <20261111-daring-salamander-from-tartarus-4c72bd@quoll> <5b6e4031-4c52-4b67-82c2-0033d13b15d6@kernel.org> <0d4fa5af-e406-4761-aa58-534c3c6a043a@oss.qualcomm.com> <4c3bf92c-2434-46e8-8a3a-ab34cc50c72d@kernel.org> Content-Language: en-US From: Jyothi Kumar Seerapu In-Reply-To: <4c3bf92c-2434-46e8-8a3a-ab34cc50c72d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE3MDA1OCBTYWx0ZWRfXzDUumZ9esj9l 7WBwfoBfhew79vftE1BGJinYFNGkgD1Iokyk9eXAtuvGMBwV7/j0WxQ+J+Rs/rGzq52Qbn+BCdP 2EnBz4HorlFYEhfvDWxxl7WW+GjFvN0= X-Proofpoint-ORIG-GUID: YiF_INZt9uFhFdo7qmKrv0XCbVpX1Hoh X-Proofpoint-GUID: YiF_INZt9uFhFdo7qmKrv0XCbVpX1Hoh X-Authority-Analysis: v=2.4 cv=BIEmP1QG c=1 sm=1 tr=0 ts=6afc6708 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=fQRhRBuJyxsiCmdI730A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE3MDA1OCBTYWx0ZWRfXzKtqtZA++QX8 R8/0G9ZE9CujbdAivBkokrXp0jkWrhXT5POk0UdETvgrLTTyQPyshzDMl03Cr5peszKC38bH1KP +8h0wH7mpPoECilbXu9lYjrdijeUOoNUkm4gtZouSyxXzctj9kp78RLC1IlfszdEjK7SAGVa9IV YyxVx5XTz4RhQD0qa+SXJcnKwaBVNFy+eoWeK1ZKza799sxcF/dt+PVqD2EJrLFjO4NfB4Ay/vL PtXBQbJG+jt1X68UXbdeDoRRCVQ4CONp0zpPPHYynd1gkwQY1DhpUev/tiw5+5SqwuwjT6fnfhI ot5dKYknVT3hzoTN7EuJot8uaKK/SzU/SpwbtRUvXVZFd+JRa9kGAundpTqo9jJcHoaTKYPU0YR KCvcU1GWqOYyxg7+0aHwp3GAD3h9Bhm7HGtPAs2s93I6x5Ivz1nRTSXHMXaZD169MiLdogPLrNT LO15ML9PfjYhyXeJZfQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-17_02,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611170058 On 11/16/2026 6:56 PM, Krzysztof Kozlowski wrote: > On 16/11/2026 11:36, Jyothi Kumar Seerapu wrote: >> >> >> On 11/12/2026 7:27 PM, Krzysztof Kozlowski wrote: >>> On 12/11/2026 14:47, Jyothi Kumar Seerapu wrote: >>>> >>>> >>>> On 11/11/2026 6:07 PM, Krzysztof Kozlowski wrote: >>>>> On Mon, Nov 09, 2026 at 08:03:29PM +0530, Jyothi Kumar Seerapu wrote: >>>>>> >>>>>> >>>>>> On 11/9/2026 7:12 PM, Krzysztof Kozlowski wrote: >>>>>>> On Fri, Nov 06, 2026 at 08:31:20PM +0530, Jyothi Kumar Seerapu wrote: >>>>>>>> Add QCOM_GPI_QSPI to identify QSPI (Quad SPI) channels in GPI DMA >>>>>>>> specifiers. Its value, 9, matches the GENI serial engine firmware >>>>>>>> protocol ID for QSPI. >>>>>>> >>>>>>> What is GENI serial engine firmware? How does the Linux rely on it that >>>>>>> we add bindings for it? >>>>>> >>>>>> Hi Krzysztof, >>>>>> GENI firmware runs on the serial engine’s programmable sequencers and >>>>>> implements protocols such as SPI and QSPI. Linux configures the engine and >>>>>> submits transfers to it. >>>>>> The existing GPI DMA specifier includes a client protocol ID. Linux programs >>>>>> this ID into the DMA channel and selects the corresponding descriptor >>>>>> format. QCOM_GPI_QSPI adds the QSPI protocol encoding 9 to that interface. >>>>>> I will clarify this in the commit description in V2. >>>>> >>>>> Does not really answer. I see no reason why GENI firmware needs ABI for >>>>> Linux. >>>>> >>>> This extends the existing GPI DMA binding, not a GENI firmware ABI. >>> >>> OK, so it is not ABI for the firmware. Period. Let's stop discussing this. >>> >>>> >>>> The third argument of the DMA specifier in the dmas property selects >>>> the peripheral protocol. The GPI driver programs this value into the >>> >>> Yes, so the third argument can be value of 6 because it has no meaning >>> for the firmware. >>> >>> Again, follow standard DT bindings ABI rules, you don't get an exception. >> >> The existing GPI DMA driver and binding uses its third cell to identify >> the client protocol. The driver takes that value from DT and programs it >> directly into the channel's SCRATCH_0 protocol field. > > So register value? Not a binding... > >> Its mandatory to maintain protocol ID-9 for QSPI. > > How can it be mandatory if we did not define in the bindings so far... > Hi Krzysztof, Existing SPI, UART and I2C use the same number for the DT identifier and hardware encoding. gpi_of_dma_xlate() stores the third DMA argument in gchan->protocol, and gpi_alloc_chan() writes it directly into SCRATCH_0 without translation. Neither 6 nor 9 has been defined in the upstream binding yet. Would it be acceptable to follow the existing SPI, UART and I2C approach and use 9 for both the DT identifier and hardware encoding? Or should I use 6 for QCOM_GPI_QSPI and explicitly translate it to hardware protocol ID 9 when programming SCRATCH_0? Regards, JyothiKumar >> >> Other protocol IDs which are not part of upstream are for AFC (6), SPMI >> (7), HID_QSPI (8). > > > > Best regards, > Krzysztof