From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E89737F8C9 for ; Wed, 14 Jan 2026 09:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381539; cv=none; b=CfGe8myVtUE/LvM/G//0Q+h9K9NiUdcax2H+K6vcTD1zVWsK1xP/dpiiftJU/qjKAsL4LiDieT+JWnFia25h87XJRs6ApeUOud/FPf5bEJwll+EMThaKqAyZgNMXmspwSGy7vR03dkg8IJzYyssdqbDYDyUt/6XjrKmshy8a0ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381539; c=relaxed/simple; bh=YR4DwG8pCplYBUPao0aXPNwD6nlZciCukQORdqVQ6y4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ihjI1htQdb7TFhXLaXYaMJ6mnhoNzcIEMlCxHxAx+x7lX22rMKHjgljtuiTFhSD7wwCUrLfrt3EXG7jZ0xMPnuTaxmszdGof4LRfjC/vF7T1c5My6O8ACuIun1Squ5MJzxV2JCRzHf9GGw7A61e+i5I+2UgU+/zTusx5pcvL3Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G2+Cnfsx; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G2+Cnfsx" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso71168385e9.2 for ; Wed, 14 Jan 2026 01:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768381537; x=1768986337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XwG15GopvSaIUizczqNnDWH98rC0KVKMXbS2DOpVO8A=; b=G2+CnfsxWbzk1l3cGpMDM3AXFv01IOiKrwKMuBI+3j3YYdP7LnVSCjLCnyej7SQ+Bq GGVIz+M2l2YPnyci3+geOtoQRhTomB4Ogd42rHKD8jzfFPtsfyiXOdyVgwK5gsMEXl2e bAYcvAjENznlqIDYsmOCjeO4SYUMBuwJ81zeVmLj+Ooap1h1WI0i/3rfFk/wWW5ljJVh BoDFXvCJgvuTKWWDF/f4l4Hr+9oH+eNeJzB5/G8LTbptvwrIA7zLs4SOCjsxmtAGMRO9 rt5ExSYd5za8Lvk5fmQLqd9E7rV6ZShb+0P9UCTAd8OhEXKDIy6CclzUNmX5kl/PTT/7 lbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768381537; x=1768986337; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XwG15GopvSaIUizczqNnDWH98rC0KVKMXbS2DOpVO8A=; b=OuxP1x0o9X9EKem2zNoeG5uy0ydIrQJUUuOxUwfUKVmREzDstuCwMttmT2IahfXFX+ Ywe4SwsUePbdKInPyD/3u64oiiLTwsux4NYRTUWDdnNVJawojOaaFCURk+Jah0CJreZb 1m3y4NEPtNy1Ive9tyyxmFt0e5NxHB1A2YIezHudKzeYCtqRePJyTyADTncBRJjdd6hb wb9bNNe4UySSEX+ZKIYilUqxu9spM6cGTCbm7FZsprbI8erG+wWwi+ptrtbd+OCTte0T WEFbES20PA3tj5NxL76ZMTEKbJG6xLfl9ebCHOa0+ZStE4Qth/P5nNo9hEDhVocDf0Yf brog== X-Forwarded-Encrypted: i=1; AJvYcCVODuWRrJv4wRuo1kzO/1uBB+XNiLjmTfwnDe2GG7OdgwYBcUmR7UYQPkYAnDpqvan2vZ6XUUON/cNqQXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzLMMTxxog2QLP3tU3UyKKt6dXv0RD4mlLgpGCR/+Ro2Yd6noTO FNQ8kgpEwNsyitRM3lKcQTTJuHX1+Vz/Cceqf90MYWDtHEQ8eBTOvjPSf+fArpthmlY= X-Gm-Gg: AY/fxX59cZMhCiS0GZHo1L2ALpZhtMXkYwRBVzxSMGjiGhn8HGcv5ikDw0qPpHp8jD+ CvBrOGi8+7z08Q73KH+ljDvU+pyJ4KVuULIEl1TJLq+KXQocHWdGSBLcxwotv6P/jhx0GmuQMok q2kiBvZhOwKIVBebm9XLDqNmo3khfNwalW2zKQTkoCE7DH3O8KStFEn+5r2m68WNlajLmkrq94c CfX7nTmNSzZ7VX5XJyOAACZ9uik1FOxjIWxi2COKGmsPzmorj8rI5CFuyTAJT5qgm7H+KtjDJ7d xKe4U08vwLRd2dC3cUjPYBFJriiwwBt4SOq0mg/KTtzoTqYpLG/AaZsqkbDYfBv2kt3uzBXCLyk Siy/sF6Ge4y4qCQE6+by8/uB43KYUfB6zslS7A38RCl7JaTpYbwRjSCWy5YJJ5ylUf/EOjqViZM RyKDiqrOJ9vpQypSutiZkFeHqM5GYLtV2L0IFkN6jTINTKGtsiGBjGmuNvOFotR/z9WQ3SJ7nyN w== X-Received: by 2002:a05:600c:4446:b0:477:9ce2:a0d8 with SMTP id 5b1f17b1804b1-47ee47222f1mr14772495e9.0.1768381536276; Wed, 14 Jan 2026 01:05:36 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:b357:7e03:65d5:1450? ([2a01:e0a:3d9:2080:b357:7e03:65d5:1450]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee562d7aasm17655715e9.11.2026.01.14.01.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 01:05:35 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 10:05:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] arm64: dts: amlogic: s4: assign mmc b clock to 24MHz To: Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> <20260114-amlogic-s4-mmc-fixup-v2-1-7e9ab5f12286@baylibre.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260114-amlogic-s4-mmc-fixup-v2-1-7e9ab5f12286@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/26 09:56, Jerome Brunet wrote: > The amlogic MMC driver operate with the assumption that MMC clock > is configured to provide 24MHz. It uses this path for low > rates such as 400kHz. > > This assumption did hold true until but it now, but it is apparently > not the case with s4. The clock has been reported to provide 1GHz > instead. This is most likely due to how the bootloader is using the MMC > clock on this platform. > > Regardless of why the MMC clock rate is 1GHz, if the MMC driver expects > 24MHz, the clock should be properly assigned, so assign it. > > Reported-by: Nick Xie > Closes: https://lore.kernel.org/linux-amlogic/20260113011931.40424-1-nick@khadas.com/ > Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") > Tested-by: Nick Xie > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > index 9d99ed2994df..62538fd9db6b 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > @@ -838,6 +838,10 @@ sd: mmc@fe08a000 { > clock-names = "core", "clkin0", "clkin1"; > resets = <&reset RESET_SD_EMMC_B>; > status = "disabled"; > + > + assigned-clocks = <&clkc_periphs CLKID_SD_EMMC_B>; > + assigned-clock-parents = <0>; In this case, assigned-clock-parents should be dropped. Neil > + assigned-clock-rates = <24000000>; > }; > > emmc: mmc@fe08c000 { >