From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5123C11CBA for ; Thu, 11 Sep 2025 05:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.68 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757567788; cv=fail; b=u9EuU6QDaK4D+fORXvdzmGGqeL3vOzl+QmMleyhvuH8H+/OjrMaria9ukPqMmNGwI+MJxGnz2ZC/us9kKLZrXcr/6xWAwEXezFedjzOlpAMgbMHqg7tgfykDcwYGmBaOWsZyFB9uqEbKfCAdZ7ylDRuC45lTQmQrNn04BPjBQnA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757567788; c=relaxed/simple; bh=3cOmLQdM5YERniba4EAHpK886faLuvMpArQkgDGSrTM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=NtTE6g1uCuKEnlQStEDu8gUtGEivsiORJETRIXzVxjq6h6r9I40yC4ck9p+iFoVSc177xESUviQ83G3hModpsvpJt9S3IhzZTdoQzee/zTvAKK1eyoaciDaDXhVII/SydNaDjHADL2wNhJguzQFdntxicAtkwXZUD1T1yeV1q00= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=1vzJztiK; arc=fail smtp.client-ip=40.107.243.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="1vzJztiK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jEqgdgd39tItNZoVT9ntcs0DSls03f5tVOZILIZ4SsIAuWqDTYAlXcgcDQ3CH9AQ1F8o1mHBN+LlxRW3naZxyiTySoKmgnDzJP4kwUcpekHjzQAFqvwUp5rBhr3RCNb8XysXhxUwKCRppI73i7zlAhatqvbbONhGdQw0qf/cNcZdFMFfP2e5krGYFYSXkT9EWqogBKj/VrljgWnbq6mDwzDfc0yGmLNv3dIhwJAQLGlLBpVBvrjkS7JV771vmE5vUkEDlyczW3b1n99G6Y1wvPo43zei0LnAHnLjGytDBlmnA5ND+/jlbqi15Chgl95jNfJMRxRvdqORv78r0cJXDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KCtG/Urn6ho2+vnKkN0kJ6nwoT/N/6sWRdZ+lysuFvk=; b=RqMXX3UP+u0c0gXvHW1vCQSSsyx341SUOU4LSQEdEOMSeEV97hsA7Gdx36v1PrmLaoZhu+rsfaLawU4IYVFuK3OiEaVmNmbcGGA6KDRWvtQpk30+dDacoEpHenCRW6/UWkaMDj8bRdlC0uXaXtn3GEpeflNLE1GcfUvob4Ne+MzyD9W89eHNKbPJ1O120VFA9Ln2Dw6pJRM6gOBzYpS0MnbQOpk5PiWHjgnj61mWQ6+ptLuF2/DCSstvX7LGHRrWSOKqIaL4/RzwQ+osv+I6GCB+Q6Zj/O1nsQ4T83EtMMnpgvni8pr+KbE4VoL8ksxu0MMaVlUP3oFkUU5C1MLV3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KCtG/Urn6ho2+vnKkN0kJ6nwoT/N/6sWRdZ+lysuFvk=; b=1vzJztiKFREd1GnIckM38m/qaRmCIqLVjt/x0pzpV4aYhTOn3w07SWMJd36G6QmrOHTD/85v+lUEWgTH7u/lpWGt0H3x/+d3+Qgg275gadAUeEOUPEiDSECgMwyhKqGY117DWsOVn3BKc16vqNR3DQXZy+2Okdi6R54ymEsGDeI= Received: from CY5PR15CA0235.namprd15.prod.outlook.com (2603:10b6:930:66::7) by CH1PPF0316D269B.namprd12.prod.outlook.com (2603:10b6:61f:fc00::604) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Thu, 11 Sep 2025 05:16:21 +0000 Received: from CY4PEPF0000E9CE.namprd03.prod.outlook.com (2603:10b6:930:66:cafe::26) by CY5PR15CA0235.outlook.office365.com (2603:10b6:930:66::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.16 via Frontend Transport; Thu, 11 Sep 2025 05:16:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CY4PEPF0000E9CE.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Thu, 11 Sep 2025 05:16:20 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 10 Sep 2025 22:16:19 -0700 Received: from [172.31.178.191] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 10 Sep 2025 22:16:13 -0700 Message-ID: Date: Thu, 11 Sep 2025 10:46:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 04/10] sched/core: Dont allow to use CPU marked as paravirt To: Shrikanth Hegde , , , , , , , , , , CC: , , , , , , , , References: <20250910174210.1969750-1-sshegde@linux.ibm.com> <20250910174210.1969750-5-sshegde@linux.ibm.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20250910174210.1969750-5-sshegde@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9CE:EE_|CH1PPF0316D269B:EE_ X-MS-Office365-Filtering-Correlation-Id: f69456b7-7fda-431d-f78a-08ddf0f25826 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N0h3UjlFUkhMZTUwMHhSaXNjSTZPcm5BdWxSZTcveFlRNXFmZUlFcjhwbzNT?= =?utf-8?B?Q3ZLcmZueXp4UTJncS8zNENZWTFLN3ZsUnNiMmZMOHBkT1dmRXpWTVA0V015?= =?utf-8?B?N1VVVVNiU3ZzSjRhcmxnQ1JEd09nOFJMTTJjWW02OHFJckR3QU5GZVlHS0Vt?= =?utf-8?B?NWg0L09YRm03ZjZaeGdVTUxjdmhSd1NlZ2JHdW91dERYL0NGUXNncmplQTJr?= =?utf-8?B?RkNQT2Flbjh4UkxXN1RRR3JyOHpsMHQ2VmEvdUFTWEpYZnBObjl2VzRsYWNl?= =?utf-8?B?VjRxMFNWUEFhOThkQU90aG9YOG53TkxkdjBhbnRtdkZlWjNPRjJUYlFlYWFq?= =?utf-8?B?clJQdnNacVB1VWJOZnZRT0VubFAxUm5aQVEvTU1jTDZoQlN3UFNLc1BTYVJW?= =?utf-8?B?TFh1M281bWZmMW5UMUNtU1lHQVhCaDdzaXMyR0xCZmN2WGsydndiL01oR05L?= =?utf-8?B?U0FXUlV1SXpHQW1hbVBuRjBzNUR4RzZQbSs0N2YwUGNVcmIwOGxZWG1IemFj?= =?utf-8?B?SjArMjRzdG5VUnBUSHkyaklFU0xHK0NmWXBlUkdHWENEVUhiQ1pzZEMyR2Rx?= =?utf-8?B?S3FpUWZaM2NRdWtsY3lmMGV5S1RnUUJhUmVXMElSMzhzTmlaa3p3VExJaGE0?= =?utf-8?B?M3YzVXAvOEFvNzJHQ3JiYnNRdXlHTzVibDhTV3diYXJZUzByUEtDK0lBUFBr?= =?utf-8?B?QVkvZzVSTTBXc2xsRkR0NEhxa0F5cWEzM0l6MnZHUXgyNVluNnRWNUFvS0Y0?= =?utf-8?B?Y2swcXRycFdYdlRjMWlzNHg5RllRWGlRUUo2QVk5aFJEc2xReHNRL0lXQkd0?= =?utf-8?B?cVJyaVpFQUVDcUpYWjMwakdpc0NQRTVVM3Q4aElIaUtqRzRpWWhyc0xILzZi?= =?utf-8?B?MEorbFI1clBML0oxRkJ2NU1EQ1gyMERqU21oTThKNXZybmtIejB4RFJobXBJ?= =?utf-8?B?Tk1EbmJFNEUwOU1EMDlkYXZGSFZ2cWw3T0ZsSFh0LzVrYmRFSW8yelVQRUpP?= =?utf-8?B?MVNIRk43eHpFQjdyZGdQWThHQWlWeGUzZENNZVd2Sm4rbTFIWWNrNmpTTk9L?= =?utf-8?B?UExFUlVTN0ZVdEw0N2cxUUtaWkloY1hKZzJpVjNZelpYMTR5NUxjNUpOUG9x?= =?utf-8?B?TTU2a3RUVDlrTG5zcHZvS0JuNGJRd0RlTHFRKzBaS2lnZEFtMzlmN0J4ZmJX?= =?utf-8?B?NHdkekFLRlJGdFJGWGlGN1AyS2JVSEZmUzhlL1lXV3BMbjAvTWZkTmwyaGw0?= =?utf-8?B?OXJqVnA0ejYxbzBFK0ZGR1NuZkpzUlBqQ0pGb0FQbGFoQUh6MkpySFhvZXpX?= =?utf-8?B?SnBxbXRZZmptd1N2MUQ1bEkzYjVxOWgwWkNsVjh6TDB6UmFMNGtPZENqcndy?= =?utf-8?B?YS9wNmhtOTRMSHRCMmdhN2N3T2JaODZuYkpnZHVHRTJhV3BveU5kc2daMlJO?= =?utf-8?B?eUt6S3RBelZBczNKcDJyd3FNZmlUWEtSSzBCQURTZTBZZWFkSmxPZ0htMEVq?= =?utf-8?B?R3c0QThOai9ZbytjMzFadkJRU1BhVStnazFQdEIzWWtLT0VUYkpheDQ5bFd1?= =?utf-8?B?ek9oUERVRzZ1L2M2V3pLMi9vanNpbU5URE1mMXZmRG5xbEJTRzZVd2NUUXZH?= =?utf-8?B?RFA5eHFYNVVaa0J0ZmJXMUl2VS9xRGNLVFlYdVo3ZWQwd0V1bWc4SG1sYmVP?= =?utf-8?B?ejE5em9ibXpzSWRoUHpoNkNjZGxqYm5mdmNUMTNPak93RUlraDY4aXQxK0pZ?= =?utf-8?B?N292M1c0U3d1Tk9PWkcxY0tFcExPYzZmeHhTT1E5RXMya1JISkpmRjlEQVFC?= =?utf-8?B?Mm5Md2ZpMHZPTE43U1EzVDg0dmorcXhqZTRnWnhwT3FBaVVEemU2M2R2UkZh?= =?utf-8?B?MUswaHR3M1FXVVZuVmY1d3hFUy9jazAxS28wblNNYTFKWUQwbXZzWG1Mb2Fv?= =?utf-8?B?dXF1QncvYmFpODh4OTNwYmwrVHViOGNqTFRwQmUzR1I5Qm9VNCtJTEYzSmtR?= =?utf-8?B?MmM2ejVkeEZFVWIxcHRCN0F2Z2hGSkVLaDRiWmVENThOeURBdUJJWnhpa0xC?= =?utf-8?B?NjNZMmwwUGVyT0R6blJsRGt2Zk1BVzVmaXRqdz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2025 05:16:20.7305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f69456b7-7fda-431d-f78a-08ddf0f25826 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9CE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPF0316D269B Hello Shrikanth, On 9/10/2025 11:12 PM, Shrikanth Hegde wrote: > @@ -2462,8 +2462,13 @@ static inline bool is_cpu_allowed(struct task_struct *p, int cpu) > return cpu_online(cpu); > > /* Non kernel threads are not allowed during either online or offline. */ > - if (!(p->flags & PF_KTHREAD)) > - return cpu_active(cpu); > + if (!(p->flags & PF_KTHREAD)) { > + /* A user thread shouldn't be allowed on a paravirt cpu */ > + if (is_cpu_paravirt(cpu)) > + return false; > + else nit. redundant "else". I think this can be simplified as: return !is_cpu_paravirt(cpu) && cpu_active(cpu); > + return cpu_active(cpu); > + } -- Thanks and Regards, Prateek