From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD7DCA0FF8 for ; Tue, 5 Sep 2023 17:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347280AbjIEREA (ORCPT ); Tue, 5 Sep 2023 13:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354094AbjIEJgm (ORCPT ); Tue, 5 Sep 2023 05:36:42 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 735491A7; Tue, 5 Sep 2023 02:36:34 -0700 (PDT) X-UUID: ae4448c84bcf11ee8051498923ad61e6-20230905 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=D5y9G1z06Rxre4yQq8k6ge1/4b/I2XOmZS0cs0tPS4w=; b=JP8ejumWXkZ11w3SOnxRdDeLD2kiwg8vGjG6RhPczO8SNnTj9QZ8wfCHqo+K79joD8sa6AhRjYYzFc61RSQ4hERDej0eZ3X8fPvZ1w2DMf4gR3W58YEDGji8UiVqfE2nE/iD56QaCR3eqffzfukQykYQZggdaUDkuhZHXZ8/zOA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:d114ed4b-bd01-4cd0-93bb-b9a462902d16,IP:0,U RL:0,TC:0,Content:3,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:3 X-CID-META: VersionHash:0ad78a4,CLOUDID:bd5d9313-4929-4845-9571-38c601e9c3c9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:4,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: ae4448c84bcf11ee8051498923ad61e6-20230905 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1482347891; Tue, 05 Sep 2023 17:36:24 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 5 Sep 2023 17:36:23 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 5 Sep 2023 17:36:21 +0800 Message-ID: Date: Tue, 5 Sep 2023 17:36:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] dt-bindings: arm64: dts: mediatek: Add mt8395-evk board Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , Sean Wang , , , , CC: Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun References: <20230904092043.5157-1-macpaul.lin@mediatek.com> <00f0a1cf-6246-92e9-13b0-cf31bb292a94@mediatek.com> <97b82a16-8710-9430-35c8-673381aaa417@linaro.org> From: Macpaul Lin In-Reply-To: <97b82a16-8710-9430-35c8-673381aaa417@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/4/23 20:11, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 04/09/2023 11:50, Macpaul Lin wrote: >> >> >> On 9/4/23 17:33, Krzysztof Kozlowski wrote: >>> >>> >>> External email : Please do not click links or open attachments until you >>> have verified the sender or the content. >>> >>> On 04/09/2023 11:20, Macpaul Lin wrote: >>>> Add bindings for the MediaTek mt8395-evk board. >>>> The mt8359-evk board is also named as "Genio 1200-EVK". >>>> MT8195 and MT8395 are the same family series SoC could share >>> >>> How can be the same and have different numbers? You sill need dedicated >>> compatible. >>> >> >> The SoCs mt8195 and mt8395 are designed for different market application >> and physical characteristics, using different efuse values for >> distinction. The booting flow and configurations are controllered by the >> boot loaders, firmware, and TF-A. Therefore, the part numbers and >> procurement channels are different. The detail information of these >> efuse values is proprietary, so I cant disclose it futher. Hence the >> most of peripheral drivers and base address are almost the same. > > 1. Drivers? So we talk about compatibility, not the same. > 2. "almost the same" is not the same. Follow the guidelines for writing > bindings. > Thanks for the review. After internal confirmation and discussion, it can be confirmed that the MT8195 and MT8395 are identical SoCs from to binding's perspective. MediaTek hope the mt8395 boards could directly use mt8195.dtsi, without the need to create a separate mt8395.dtsi to include mt8195.dtsi. Therefore, we hope to fully adopt the bindings of mt8195. However, I will submit a revised patch for compatible since they are different boards. If the reviewer still disagrees, then MediaTek will create a new binding and use mt8395.dtsi to include mt8195.dtsi to apply the separate bindings for differentiation. > Best regards, > Krzysztof > > Best regards, Macpaul Lin