From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBDCB34C9AF for ; Mon, 20 Apr 2026 09:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776677582; cv=none; b=AzJ5Kr25jll1YUBm5FWUuzPcaT5Aej2B3GDUgARMEFVp3Jp11qCAXCt82030moZgdTLRyWS3JHOuJn3gVMNqUV97ttES0+9MSvdYXARPDq3nnfi2a6YfS8vogynFlfuNbPf9tGXakLtulecMpIr3zMV7qBKWpQf4BhzSHlrkOnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776677582; c=relaxed/simple; bh=s04bmjBEuyVca8RWyh2Sf2LUnzslvrKNSj91YxyWZck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MrQtdkabYSyWikdSHer0yGsvNWSi5bevQD7Ven587nll+110u08cQAq7Vkg84B2bxjgkiEnJSIUHYUyNXt4hGOGcGpIGo0N4uVJyTq6NIy25E0vnjTum3+qeixyxew3YOZocxuviLbE1baVxJ+w++9ZC66cb7IZJrm/xbVvBeKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rfpA7sBP; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=akHXfFCd; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=FiA9CekF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=e4qW7709; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rfpA7sBP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="akHXfFCd"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="FiA9CekF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="e4qW7709" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DAC2D5BCCF; Mon, 20 Apr 2026 09:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776677579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vsEByiZj+JzsLCs3ONQnwD4NDNTerqZlz+YKsEHr+As=; b=rfpA7sBPfnrBSoBvzB4wFw04ZziTx6J2M9ZVh0NXY/b9MlIme0Xq70HmU6H+KvMFthVBIf QzWTmMdUSCxR6zZzH4CECrLA4bApf23Uh6lc/ylfUwzsfSd0VOrqFrNydA1Um2B9N06Ihj /KQ1ShKExo+hAnx4FyGjRiHXondRiQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776677579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vsEByiZj+JzsLCs3ONQnwD4NDNTerqZlz+YKsEHr+As=; b=akHXfFCdcpzJRQgpD+0jxUsn9jEHl6sk4hNKUwD9tF8g+ORtj/8OEsfoLPe1RjQ+c4owDe x7VhXjUgJZCHlaCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776677578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vsEByiZj+JzsLCs3ONQnwD4NDNTerqZlz+YKsEHr+As=; b=FiA9CekFc10XMsc+DHe/OWMXB8a8mn5AdU65Bk/MJOTpESPB8MibX8H1TpymB2hNk+p8JE CxCmHNwRNXuQiOQhNELyPDL1W+Y1z4Kk5cN02kk/1znnILmzjBfgiXo5efdnF9NdMSqSQb ba8Ulk4x1NWWPI2gY6uw0UitIR2hnWc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776677578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vsEByiZj+JzsLCs3ONQnwD4NDNTerqZlz+YKsEHr+As=; b=e4qW7709k//ImjWHWl+gkkVg50u8KuHM1rjdf+K/YN/2nJJyBp0VHTXSKleRFACLGGXGFI 5u34ytmKY2IG3+Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 65CC7593AE; Mon, 20 Apr 2026 09:32:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pSxxF8ry5WmPTAAAD6G6ig (envelope-from ); Mon, 20 Apr 2026 09:32:58 +0000 Message-ID: Date: Mon, 20 Apr 2026 11:32:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for drm-misc-fixes v4 2/4] drm/hisilicon/hibmc: fix no showing when no connectors connected To: Yongbang Shi , dmitry.baryshkov@oss.qualcomm.com, tiantao6@hisilicon.com, xinliang.liu@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, daniel@ffwll.ch, kong.kongxinwei@hisilicon.com Cc: liangjian010@huawei.com, chenjianmin@huawei.com, fengsheng5@huawei.com, helin52@h-partners.com, shenjian15@huawei.com, shaojijie@huawei.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260416092455.1990632-1-shiyongbang@huawei.com> <20260416092455.1990632-3-shiyongbang@huawei.com> <7407b6cf-70a0-42a0-b63f-5cdaae0eb4b8@huawei.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <7407b6cf-70a0-42a0-b63f-5cdaae0eb4b8@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[huawei.com,oss.qualcomm.com,hisilicon.com,linaro.org,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: Hi Am 20.04.26 um 10:40 schrieb Yongbang Shi: [...] > > From the patch you contributed,，I understand that you are using an > RH1288H V3 server. I have confirmed with our chief hardware engineer > that the board design for this series of servers does not connect the > BMC chip’s DDC I2C to the VGA port. Thanks a lot for double-checking. That's the info I was missing. I suggest to build a workaround into the driver to filter out these boards and always return 'connected' on them. IIUC even with these new callbacks, the driver would not work as expected. > > [1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c?h=v6.12.82#L60 > [2]https://lore.kernel.org/all/20250320101455.2538835-10-shiyongbang@huawei.com/ > > >>> Signed-off-by: Lin He >>> Signed-off-by: Yongbang Shi >>> --- >> [...] >>> +static int hibmc_vdac_detect(struct drm_connector *connector, >>> +                 struct drm_modeset_acquire_ctx *ctx, >>> +                 bool force) >>> +{ >>> +    struct hibmc_drm_private *priv = to_hibmc_drm_private(connector- >>>> dev); >>> +    struct hibmc_vdac *vdac = to_hibmc_vdac(connector); >>> + >>> +    vdac->phys_state = drm_connector_helper_detect_from_ddc(connector, >>> +                                ctx, force); >>> + >>> +    /* If the DP connectors are disconnected, the hibmc_vdac_detect >>> function >>> +     * must return a connected state to ensure KVM display >>> functionality. >>> +     * Additionally, for previous-generation products that may lack >>> hardware >>> +     * link support and thus cannot detect the monitor, >>> hibmc_vdac_detect >>> +     * should also return a connected state. >>> +     */ >>> +    if (priv->dp.phys_state != connector_status_connected) >>> +        return connector_status_connected; >>> + >>> +    return vdac->phys_state; >> This will break user-space compositors if DP and VGA are connected at >> the same time. I know, because we had such logic in ast and mgag200. >> >> Today's compositors expect a single encoder-connector pair on each CRTC. >> That's what most contemporary hardware provides.  But the server >> chipsets usually come with one a single CRTC and multiple connectors >> attached to it.  Compositors fail to configure that. When we had this in >> ast and mgag200, Gnome would display garbage to the screen and mode- >> setting would fail. The bug report is at [1]. >> >> In ast and mgag200, only one connector would be installed on a single >> system. So we could avoid the problem. It looks like that this is not an >> option with hibmc. VGA always seems to be present and DP seems optional. >> I would advice to only report one of the connectors as 'connected' if >> both are installed on a system. >> > According to our BMC chip specifications, both VGA and DisplayPort > outputs are required, but only one connection is allowed at a time, > which seems impractical. That's true. Yet it needs support form user space to make it work. It's not a kernel problem. > > Do you have any additional details regarding this issue with the Mutter > synthesizer? For example, steps to reproduce the issue or more specific > alert logs. I looked at the issue you submitted to Mutter, which > describes the phenomenon as "a warning that the configuration is > incompatible", Could you clarify what this warning specifically refers > to—is it a message displayed on the screen, or is it a specific entry in > the logs? In ast, we used to have at least one connector for the physical output and another connector for the BMC/KVM. Running Gnome and opening the Settings app did not work correctly. One issue is that display configuration could not be changed in Gnome. That's the reported error of changes not being applicable. IIRC I've also seen distorted output if I really pushed it. But maybe that has meanwhile been mitigated. I've been told that other compositors also don't support this scenario well. I think you'd run into this case once someone connects the DP and VGA at the same time. > > Over the next few days, we will focus on testing relevant scenarios > while setting both the VGA and DP ports to `connected` to see if we > encounter similar issues or warnings. > >> You also need to increment the connector's epoch_counter if the physical >> status changed. Doing this will trigger DRM clients to re-read the >> connector state and reconfigure display. >> >> Something like that >> >> dp_detect() >> { >>     dp.phys_state = detect_from_hw() >> >>     if (dp.phys_state changed) >>         ++epoch_counter >>     return connected >> } >> >> vdac_detect() >> { >>     if (dp.phys_state == connected) >>         return disconnected >> > Only one option is displayed here, but it does not meet our specifications. > >>     vdac.phys_state = detect_from_hw() >> >>     if (vdac.phys_state changed) >>         ++epoch_counter >>     return connected >> } >> >> This handles the KVM in each connector's helper. The ast driver is >> probably the best reference for the current logic. See [2]. >> > I looked at the implementations of `detect_ctx` in ATS and MGAG200; > these implementations generally always return `connected`. > > If my analysis is correct, the logic should be as follows: > - If the `detect_ctx` function implemented by each vendor returns the > actual hardware state, there is no need to modify `epoch_counter`; > the DRM framework will execute `epoch_counter++` based on the return > value of the `detect_ctx` function; > > - If the `detect_ctx` function in a vendor’s code always returns > `connected`, then `epoch_counter++` must be performed within the > vendor’s `detect_ctx` function; the implementations in ATS and > MGAG200 appear to be like this; Exactly. In ast/mgag200, we had the case that the VGA got disconnected. We'd still return connected, as the BMC/KVM was present. We now had to reconfigure for the KVM. That requires modifying epoch_counter. You can see at [1] that we only increment if the physical status changes. [1]  Same goes for re-connecting the VGA display. [1] https://elixir.bootlin.com/linux/v7.0/source/drivers/gpu/drm/ast/ast_vga.c#L56 > > > Here is the pseudocode for our current logic. This logic is indeed a bit > hard to grasp, so I've added some more comments; it might be a bit > clearer than the patch: > > dp_detect() > { > dp.phys_state = detect_from_hw() > > /* epoch_counter update by drm framework */ > return dp.phys_state; > } > > vdac_detect() > { > /* > * Scene 1: The driver runs on an older version of the BMC chip, > * and `dp.phys_state` is initialized to 0. To maintain > * consistency with the previous hibmc-drm driver > * logic, always return `connected`. > * Scene 2: The driver runs on an new version of the BMC chip, > * and `dp.phys_state` is real status, witch is real > * `disconnect`. In this scenario, we must ensure that > * the VGA is `connected` to guarantee that the KVM > * displays properly. > */ > if (dp.phys_state != connected) > return connected; > > /* > * DP is connected: This driver is definitely running on the > * latest BMC chip, and the DDC I2C is definitely > * connected to the VGA port, so we can confirm whether > * the VGA is present by reading the EDID directly via > * I2C. > */ > vdac.phys_state = detect_from_hw() > > /* epoch_counter update by drm framework */ > return vdac.phys_state; Let's assume the DP is disconnected. If VGA's physical status goes from connected to disconnected, user space will not know that it needs to reconfigure for the BMC.   (or vice versa) To give you some context from earlier discussions around the other drivers: We had the scenario that the user boots up without a connected VGA display. This would enable the BMC, which sometimes picks a large resolution; say >2k per dimension. That is problematic for KVM over networks. And if the user now plugs in a physical VGA display, they would be stuck with the large resolution on the framebuffer console. Maybe the VGA display wouldn't even support such a high-res mode.  So we set the default for the BMC to 1024x768. That is well manageable for all of today's VGA displays and does not impose too much overhead for KVM over networks.  As a drawback, it's a bit small on monitors and not nice to look at. So we modify epoch_counter whenever the physical status changes. This triggers compositors to reconfigure their screens for the new display. Best regards Thomas > } > > Sorry for the delay; it took me a little while to figure out how best to > explain this bug and our current implementation. > > Thanks, > Yongbang. > >> [1] https://gitlab.gnome.org/GNOME/mutter/-/issues/3858 >> [2] https://elixir.bootlin.com/linux/v7.0/source/drivers/gpu/drm/ast/ >> ast_vga.c#L47 >> >> Best regards >> Thomas >> >>> +} >>> + >>>   static const struct drm_connector_helper_funcs >>>       hibmc_connector_helper_funcs = { >>>       .get_modes = hibmc_connector_get_modes, >>> -    .detect_ctx = drm_connector_helper_detect_from_ddc, >>> +    .detect_ctx = hibmc_vdac_detect, >>>   }; >>>     static const struct drm_connector_funcs hibmc_connector_funcs = { >>> @@ -130,6 +145,8 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv) >>>         connector->polled = DRM_CONNECTOR_POLL_CONNECT | >>> DRM_CONNECTOR_POLL_DISCONNECT; >>>   +    vdac->phys_state = connector_status_connected; >>> + >>>       return 0; >>>     err: -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)