From: liubaolin <liubaolin12138@163.com>
To: linkinjeon@kernel.org, hyc.lee@gmail.com
Cc: ntfs@lists.linux.dev, linux-kernel@vger.kernel.org,
Baolin Liu <liubaolin@kylinos.cn>
Subject: Re: [PATCH v3 02/10] ntfs: validate EA chains and link zero-terminated tails
Date: Tue, 22 Sep 2026 11:56:45 +0800 [thread overview]
Message-ID: <d56a1b4b-8080-449b-a324-eb10cc45a130@163.com> (raw)
In-Reply-To: <20260921102318.2104180-1-liubaolin12138@163.com>
Hi Namjae,
Hyunchul has suggested avoiding the $LX prefix because it may
conflict with the WSL namespace. I agree with this concern and have
proposed using $LINUXFLAGS instead.
Because this name change affects the complete series, I plan to
update the code and documentation, rerun the relevant tests, and resend
the full series as v4.
Please ignore the standalone v3 revision of patch 2 for now. I will
supersede it with the v4 series after the new EA name is confirmed.
Thanks,
Baolin.
在 2026/9/21 18:23, Baolin Liu 写道:
> From: Baolin Liu <liubaolin@kylinos.cn>
>
> A zero next-entry offset terminates an EA list. Appending an entry
> without linking the old tail makes the new entry unreachable. Invalid
> entries are also treated as missing names, allowing setters to proceed
> on corrupt metadata.
>
> Validate the entire chain before modifying it and connect a zero tail
> to the append position. Check name terminators and retain the full tail
> span when removing an entry. Return EUCLEAN for malformed EA structures
> and inconsistent information lengths, preserving that error through the
> get, set and list paths. Keep ENOENT for a missing name and translate it to
> ENODATA only at the xattr read boundary. Preserve lower-level read errors.
>
> Reuse the same full-chain validation in ntfs_listxattr(), including
> size-only queries, before copying names. Reject malformed lists with
> EUCLEAN instead of returning an empty or partial list.
>
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
> ---
> Changes since v2:
> - Reuse full-chain validation in ntfs_listxattr(), including size-only
> queries, and return EUCLEAN for malformed EA structures.
> - Remove the duplicate listxattr structure checks; preserve lower-level
> read errors.
>
> This replaces [PATCH v2 02/10]. Original v2 patches 3-10 apply cleanly
> on top without modification.
>
> Validation:
> - QEMU listxattr tests covered normal and zero-terminated lists, empty
> lists, size-only queries, short buffers, malformed offsets, missing
> name terminators, oversized values and truncated entry headers.
> Verified EUCLEAN after successful file open, including tiny buffers.
> - Checked an oversized query length at the patch-2 stage, and ordinary
> file/xattr writes plus unmount/remount.
>
> fs/ntfs/ea.c | 81 +++++++++++++++++++++++++++++++---------------------
> 1 file changed, 48 insertions(+), 33 deletions(-)
>
> diff --git a/fs/ntfs/ea.c b/fs/ntfs/ea.c
> index bb97df3045a0..2ee700f8227e 100644
> --- a/fs/ntfs/ea.c
> +++ b/fs/ntfs/ea.c
> @@ -53,10 +53,13 @@ static int ntfs_ea_lookup(char *ea_buf, s64 ea_buf_size, const char *name,
> loff_t offset, p_ea_size;
> unsigned int next;
>
> + if (!ea_buf_size)
> + return -ENOENT;
> +
> offset = 0;
> do {
> if (ea_buf_size - offset < sizeof(struct ea_attr))
> - break;
> + return -EUCLEAN;
>
> p_ea = (const struct ea_attr *)&ea_buf[offset];
> next = le32_to_cpu(p_ea->next_entry_offset);
> @@ -64,31 +67,31 @@ static int ntfs_ea_lookup(char *ea_buf, s64 ea_buf_size, const char *name,
>
> if (p_ea_size < sizeof(struct ea_attr) ||
> offset + p_ea_size > ea_buf_size)
> - break;
> + return -EUCLEAN;
>
> if ((s64)p_ea->ea_name_length + 1 >
> p_ea_size - offsetof(struct ea_attr, ea_name))
> - break;
> + return -EUCLEAN;
>
> actual_size = ALIGN(struct_size(p_ea, ea_name, 1 + p_ea->ea_name_length +
> le16_to_cpu(p_ea->ea_value_length)), 4);
> - if (actual_size > p_ea_size)
> - break;
> + if (actual_size > p_ea_size ||
> + p_ea->ea_name[p_ea->ea_name_length])
> + return -EUCLEAN;
>
> - if (p_ea->ea_name_length == name_len &&
> + if (name && p_ea->ea_name_length == name_len &&
> !memcmp(p_ea->ea_name, name, name_len)) {
> *ea_offset = offset;
> - *ea_size = next ? next : actual_size;
> + *ea_size = p_ea_size;
>
> if (ea_buf_size < *ea_offset + *ea_size)
> - goto out;
> + return -EUCLEAN;
>
> return 0;
> }
> offset += next;
> } while (next > 0 && offset < ea_buf_size);
>
> -out:
> return -ENOENT;
> }
>
> @@ -126,7 +129,7 @@ static int ntfs_get_ea(struct inode *inode, const char *name, size_t name_len,
> return PTR_ERR(p_ea_info);
> if (ea_info_size != sizeof(struct ea_information)) {
> kvfree(p_ea_info);
> - return -EIO;
> + return -EUCLEAN;
> }
>
> ea_info_qlen = le32_to_cpu(p_ea_info->ea_query_length);
> @@ -137,7 +140,7 @@ static int ntfs_get_ea(struct inode *inode, const char *name, size_t name_len,
> return PTR_ERR(ea_buf);
>
> if (ea_info_qlen > all_ea_size) {
> - err = -EIO;
> + err = -EUCLEAN;
> goto free_ea_buf;
> }
>
> @@ -162,7 +165,8 @@ static int ntfs_get_ea(struct inode *inode, const char *name, size_t name_len,
> return ea_value_len;
> }
>
> - err = -ENODATA;
> + if (err == -ENOENT)
> + err = -ENODATA;
> free_ea_buf:
> kvfree(ea_buf);
> return err;
> @@ -216,7 +220,7 @@ static int ntfs_set_ea(struct inode *inode, const char *name, size_t name_len,
> goto out;
> }
> if (ea_info_size != sizeof(struct ea_information)) {
> - err = -EIO;
> + err = -EUCLEAN;
> goto out;
> }
>
> @@ -255,12 +259,29 @@ static int ntfs_set_ea(struct inode *inode, const char *name, size_t name_len,
> }
>
> if (ea_info_qsize > all_ea_size) {
> - err = -EIO;
> + err = -EUCLEAN;
> + goto out;
> + }
> +
> + /* Validate the whole chain before modifying it, including its tail. */
> + err = ntfs_ea_lookup(ea_buf, ea_info_qsize, NULL, 0, &ea_off,
> + &ea_size);
> + if (err != -ENOENT)
> goto out;
> + /* A zero tail offset must be linked before appending another EA. */
> + for (ea_off = 0; ea_off < ea_info_qsize; ea_off += ea_size) {
> + p_ea = (struct ea_attr *)(ea_buf + ea_off);
> + ea_size = le32_to_cpu(p_ea->next_entry_offset);
> + if (!ea_size) {
> + ea_size = ea_info_qsize - ea_off;
> + p_ea->next_entry_offset = cpu_to_le32(ea_size);
> + }
> }
>
> err = ntfs_ea_lookup(ea_buf, ea_info_qsize, name, name_len, &ea_off,
> &ea_size);
> + if (err && err != -ENOENT)
> + goto out;
> if (ea_info_qsize && !err) {
> if (flags & XATTR_CREATE) {
> err = -EEXIST;
> @@ -537,7 +558,7 @@ ssize_t ntfs_listxattr(struct dentry *dentry, char *buffer, size_t size)
> goto out;
> }
> if (ea_info_size != sizeof(struct ea_information)) {
> - err = -EIO;
> + err = -EUCLEAN;
> goto out;
> }
>
> @@ -550,32 +571,26 @@ ssize_t ntfs_listxattr(struct dentry *dentry, char *buffer, size_t size)
> goto out;
> }
>
> - if (ea_info_qsize > ea_buf_size || ea_info_qsize == 0)
> + if (ea_info_qsize > ea_buf_size) {
> + err = -EUCLEAN;
> + goto out;
> + }
> +
> + /* Validate the entire chain, including size-only queries. */
> + err = ntfs_ea_lookup(ea_buf, ea_info_qsize, NULL, 0, &offset,
> + &ea_size);
> + if (err != -ENOENT)
> + goto out;
> + err = 0;
> + if (!ea_info_qsize)
> goto out;
>
> offset = 0;
> do {
> - if (ea_info_qsize - offset < sizeof(struct ea_attr)) {
> - err = -EIO;
> - goto out;
> - }
> -
> p_ea = (const struct ea_attr *)&ea_buf[offset];
> next = le32_to_cpu(p_ea->next_entry_offset);
> ea_size = next ? next : (ea_info_qsize - offset);
>
> - if (ea_size < sizeof(struct ea_attr) ||
> - offset + ea_size > ea_info_qsize) {
> - err = -EIO;
> - goto out;
> - }
> -
> - if ((int)p_ea->ea_name_length + 1 >
> - ea_size - offsetof(struct ea_attr, ea_name)) {
> - err = -EIO;
> - goto out;
> - }
> -
> if (buffer) {
> if (ret + p_ea->ea_name_length + 1 > size) {
> err = -ERANGE;
prev parent reply other threads:[~2026-09-22 3:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 10:23 Baolin Liu
2026-09-22 3:56 ` liubaolin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d56a1b4b-8080-449b-a324-eb10cc45a130@163.com \
--to=liubaolin12138@163.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaolin@kylinos.cn \
--cc=ntfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®