From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED10C4332F for ; Mon, 18 Apr 2022 12:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236832AbiDRNBj (ORCPT ); Mon, 18 Apr 2022 09:01:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236403AbiDRMuF (ORCPT ); Mon, 18 Apr 2022 08:50:05 -0400 Received: from relay5.hostedemail.com (relay5.hostedemail.com [64.99.140.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4984F2CCAB for ; Mon, 18 Apr 2022 05:34:13 -0700 (PDT) Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C98A621F48; Mon, 18 Apr 2022 12:34:10 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id BABB22002B; Mon, 18 Apr 2022 12:34:03 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues From: Joe Perches To: Nava kishore Manne , "mdf@kernel.org" , "hao.wu@intel.com" , "yilun.xu@intel.com" , "trix@redhat.com" , Michal Simek , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , git Date: Mon, 18 Apr 2022 05:34:02 -0700 In-Reply-To: References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-3-nava.manne@xilinx.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: epzo5oz5kfdybfgi53hfa7jj89tnxo9k X-Rspamd-Server: rspamout06 X-Rspamd-Queue-Id: BABB22002B X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+NFs9m+djNp+pOCjBVEkayfxYTc+TurQw= X-HE-Tag: 1650285243-748919 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote: > Hi Joe, > > Please find my response inline. > > > -----Original Message----- > > From: Joe Perches > > Sent: Saturday, April 16, 2022 10:29 PM > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote: > > > fixes the below checks reported by checkpatch.pl Lines should not end > > > with a '(' > > > Alignment should match open parenthesis > > > > in fpga-mgr: > > Another possibillty would be to change the function arguments > > > > and > > > > in fpga-region: > > Ideally keep the include declaration and definition styles synced > > These changes are targeted to fix the checks reported by checkpatch.pl without touching the actual functionality. Hello. I am the checkpatch maintainer. The goal of the checkpatch script is simply to mark things that generally don't conform to the typical kernel coding style not to mandate that all of the messages it emits is dicta. checkpatch is a stupid little script. It has no taste. Please take what I wrote with a little consideration rather than follow the advise of a brainless script.