From: Helge Deller <deller@gmx.de>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
broonie@kernel.org, maarten.lankhorst@linux.intel.com,
daniel.vetter@ffwll.ch
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information
Date: Sun, 25 Sep 2022 13:24:56 +0200 [thread overview]
Message-ID: <d57755de-44dc-e39c-6f79-1c139a77525f@gmx.de> (raw)
In-Reply-To: <20220902025612.3833972-1-jiasheng@iscas.ac.cn>
On 9/2/22 04:56, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the fb_info() should be removed.
NAK.
This seems to be useful info about the detected card and it's only
printed once.
Helge
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/video/fbdev/gbefb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 1582c718329c..7e39ab939691 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device *p_dev)
>
> platform_set_drvdata(p_dev, info);
>
> - fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
> - info->fix.id, gbe_revision, (unsigned)GBE_BASE,
> - gbe_mem_size >> 10);
> -
> return 0;
>
> out_gbe_unmap:
next prev parent reply other threads:[~2022-09-25 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 2:56 Jiasheng Jiang
2022-09-25 11:24 ` Helge Deller [this message]
2022-09-26 7:09 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d57755de-44dc-e39c-6f79-1c139a77525f@gmx.de \
--to=deller@gmx.de \
--cc=broonie@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®