From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39059C77B73 for ; Fri, 14 Apr 2023 20:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbjDNUko (ORCPT ); Fri, 14 Apr 2023 16:40:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229704AbjDNUkl (ORCPT ); Fri, 14 Apr 2023 16:40:41 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A42744A8 for ; Fri, 14 Apr 2023 13:40:40 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id kt6so10474697ejb.0 for ; Fri, 14 Apr 2023 13:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681504838; x=1684096838; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UBTBZBV3j3XB818AQf6y4VMhCZ7BnWynW+AV/+QQYBo=; b=tp0VjrVfgR1zQjAQH+CD1I/8euDbaKkRk9I76jq+BQpOOkHe8U4KC2T2/MDNJmVE1H 9E0c/3UEZKeHN4fXTQFuoQWcVjyEYPk6NlMI7Dufg1YwIH3i41eUoydNEie4evhWbnoA kMIfibomcSlZ2z3OEM1xpdj/zAQkjrj0iGOgv2mNYI7e4f3J2VcJQ2Tfn7oaanLvMksu s8mwTNFlyOJKxehn26TiJLcprJYYRAFQil3YROQIVikzdBEqmks5C45h5ZX74VEd2XjV 1wjQJWYX7PatO/YcO2qLPUhzDM1wB6KAgLsphV3YlBPvWSiXV5M28eNzylUAuHDchfc4 FBTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681504838; x=1684096838; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UBTBZBV3j3XB818AQf6y4VMhCZ7BnWynW+AV/+QQYBo=; b=NMa41zttR0+0BVR+1/+oqlzNsDaMkp42YT06gP2nZjt+JhejWYhaHrU8Dc6lvhFAVb neXvFP+hkofxvuMk9tcJTcgjW6hfvh/bcO5r9dgqbpihI59ZG+iMcJ/hACOmI/D495Db 3f0DMoA/Bg7vwxYer75+pTDBUeAGdAqGLk8KlESUo1nv674I12n14O2pmVimZCo7/xHH HbFtoLX3TuZMx766xrQKIQaiUeelP0yxhT7Krd/ICcRfJxwqJZjYNlBIRtcgvBKv1gAg dad+odB7Vy0ftSqzsIKyLxQMNILwTIMuN1WTxKrwad7UxzZ+wGoNIhBw4u4klMv9+/FA REEA== X-Gm-Message-State: AAQBX9ex6Q6QEQ6iVtksFOsECK9396IfAV+5pcLaNZXYi2Wldtd5l4Og OxzG3WuopQlgYEgTjwLdYLvjLw== X-Google-Smtp-Source: AKy350YWtYEZbla3D055wcBJGgPIjcQpUqqBDPJcyqq+YttwcjwgN5hzwEo067Hfi0VH3CmPoKV7Nw== X-Received: by 2002:a17:906:8602:b0:94a:a1e2:ce29 with SMTP id o2-20020a170906860200b0094aa1e2ce29mr408724ejx.23.1681504838502; Fri, 14 Apr 2023 13:40:38 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ffae:8aab:ae5a:4688? ([2a02:810d:15c0:828:ffae:8aab:ae5a:4688]) by smtp.gmail.com with ESMTPSA id fh8-20020a1709073a8800b0094f0f0de1bcsm168733ejc.200.2023.04.14.13.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 13:40:38 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 22:40:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/1] dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor Content-Language: en-US To: Andreas Klinger , linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Angel Iglesias , linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/2023 14:48, Andreas Klinger wrote: > Honeywell mpr is a pressure sensor series. There are many different models with different pressure > ranges, units and transfer functions. > > The range and transfer function need to be set up in the dt. Therefore new properties > honeywell,pmin-pascal, honeywell,pmax-pascal, honeywell,transfer-function are introduced. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > Add dt-bindings. > > Signed-off-by: Andreas Klinger Patches 2 and 3 are missing. At least they were mentioned in the changelog but this is 1/1. > --- > .../iio/pressure/honeywell,mprls0025pa.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > new file mode 100644 > index 000000000000..c0eb3c4be16f > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/pressure/honeywell,mprls0025pa.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Honeywell mpr series pressure sensor > + > +maintainers: > + - Andreas Klinger > + > +description: | > + Honeywell pressure sensor of model mprls0025pa. > + > + This sensor has an I2C and SPI interface. Only the I2C interface is implemented. > + > + There are many models with different pressure ranges available. The vendor calls them "mpr > + series". All of them have the identical programming model and differ in the pressure range, unit Wrap according to Linux coding style, so at 80. > + and transfer function. > + > + To support different models one need to specify the pressure range as well as the transfer > + function. Pressure range needs to be converted from its unit to pascal. > + > + The transfer function defines the ranges of numerical values delivered by the sensor. The minimal > + range value stands for the minimum pressure and the maximum value also for the maximum pressure > + with linear relation inside the range. > + > + Specifications about the devices can be found at: > + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/ > + pressure-sensors/board-mount-pressure-sensors/micropressure-mpr-series/documents/ > + sps-siot-mpr-series-datasheet-32332628-ciid-172626.pdf > + > +properties: > + compatible: > + const: honeywell,mprls0025pa So this is one compatible for entire family of 96 separate devices. Looks like reasonable compromise, although I will wait for Rob's approval on that. Anyway you need to fix the coding style. Best regards, Krzysztof