mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: dimitri.fedrau@liebherr.com,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: phy: dp83822: Add support for changing the MAC series termination
Date: Fri, 7 Mar 2025 16:34:59 +0100	[thread overview]
Message-ID: <d57aff5b-7d1d-43bf-95a1-ee90689f5ac0@lunn.ch> (raw)
In-Reply-To: <20250307142252.GA2326148@legfed1>

> Should I add the proper description in the bindings ? Description of the
> properties are somehow short. However will expand the description.

Yes, please expand the description. For well known concepts, we can
keep the binding description short. But i would not consider this a
well known concept, so we need to spell out in detail what it is.

My knowledge of transmission lines and termination is not so good....

So this configures the resistor on the PHY outputs. Do PHY inputs also
need termination resistors? Could there be PHYs which also allow such
resistors to be configured? Are there use cases where you need
asymmetric termination resistors?

My questions are trying to lead to an answer to your question:

> Should I rename then "mac-series-termination-ohms" to
> "output-mac-series-termination-ohms" or similar ?

We should think about this from the general case, not one specific
PHY, and ideally from thinking about the physics of termination.

https://electronics.stackexchange.com/questions/524620/impedance-termination-of-marvell-phy

This seems to suggest RGMII only has termination resistors at the
outputs. So "mac-series-termination-ohms" would be O.K.

	Andrew

  reply	other threads:[~2025-03-07 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 10:30 Dimitri Fedrau via B4 Relay
2025-03-07 10:30 ` [PATCH net-next 1/3] dt-bindings: net: ethernet-phy: add property mac-series-termination-ohms Dimitri Fedrau via B4 Relay
2025-03-11 17:33   ` Rob Herring
2025-03-11 18:06     ` Andrew Lunn
2025-03-07 10:30 ` [PATCH net-next 2/3] net: phy: Add helper for getting MAC series termination resistance Dimitri Fedrau via B4 Relay
2025-03-07 10:30 ` [PATCH net-next 3/3] net: phy: dp83822: Add support for changing the MAC series termination Dimitri Fedrau via B4 Relay
2025-03-07 13:39 ` [PATCH net-next 0/3] " Andrew Lunn
2025-03-07 14:22   ` Dimitri Fedrau
2025-03-07 15:34     ` Andrew Lunn [this message]
2025-03-07 19:23       ` Dimitri Fedrau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d57aff5b-7d1d-43bf-95a1-ee90689f5ac0@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dima.fedrau@gmail.com \
    --cc=dimitri.fedrau@liebherr.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®