From: "Arnd Bergmann" <arnd@kernel.org>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "kernel test robot" <lkp@intel.com>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: asm/io.h: mark mmio read addresses as const
Date: Mon, 02 Oct 2023 21:42:18 +0200 [thread overview]
Message-ID: <d5836a46-c614-4270-8473-05c98bbab41f@app.fastmail.com> (raw)
In-Reply-To: <CAMuHMdWFCSQgsf_0qwdkkAif3zDXM2N-WEymJBa1eeT4N6Ezcw@mail.gmail.com>
On Mon, Oct 2, 2023, at 15:12, Geert Uytterhoeven wrote:
> On Mon, Sep 25, 2023 at 5:53 PM Arnd Bergmann <arnd@kernel.org> wrote:
>> #define out_8(addr,b) (void)((*(__force volatile u8 *) (unsigned long)(addr)) = (b))
>> #define out_be16(addr,w) (void)((*(__force volatile u16 *) (unsigned long)(addr)) = (w))
>
> Shouldn't a similar change be made to rom_in_{8,be16,le16}()?
Right, these seem to have escaped my regex searches.
> I can do that while applying...
Ok, thanks!
Arnd
next prev parent reply other threads:[~2023-10-02 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:53 Arnd Bergmann
2023-10-02 13:12 ` Geert Uytterhoeven
2023-10-02 19:42 ` Arnd Bergmann [this message]
2023-10-06 7:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5836a46-c614-4270-8473-05c98bbab41f@app.fastmail.com \
--to=arnd@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®