mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert Lougher" <rob.lougher@gmail.com>
To: "Geert Uytterhoeven" <Geert.Uytterhoeven@sonycom.com>
Cc: "Peter Korsgaard" <jacmet@sunsite.dk>,
	"Phillip Lougher" <phillip@lougher.demon.co.uk>,
	squashfs-devel@lists.sourceforge.net,
	"Linux Kernel Development" <linux-kernel@vger.kernel.org>
Subject: Re: [Squashfs-devel] Squashfs mainlining status?
Date: Thu, 17 Jul 2008 16:47:13 +0100	[thread overview]
Message-ID: <d58509a80807170847p6ef05a8av96b6c8828a33821@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0807171729450.29859@vixen.sonytel.be>

On Thu, Jul 17, 2008 at 4:35 PM, Geert Uytterhoeven
<Geert.Uytterhoeven@sonycom.com> wrote:
>        Hi Peter,
>
> On Wed, 4 Jun 2008, Peter Korsgaard wrote:
>> >>>>> "Phillip" == Phillip Lougher <phillip@lougher.demon.co.uk> writes:
>>  Phillip> The major work of course is the move to a little endian
>>  Phillip> layout without any bit fields in the structures to make it
>>  Phillip> easier to swap member fields on big-endian architectures.
>>  Phillip> I'm currently working on this on a non-CVS branch.
>>  Phillip> Most of the work till now has been without any attempt to
>>  Phillip> retain backwards compatibility with the current 3.3
>>  Phillip> little-endian filesystem layout.  After your private email
>>  Phillip> regarding retaining backwards compatibility I will look
>>  Phillip> again at this issue, it may well be that I will abandon my
>>  Phillip> current layout changes that I have so far made.
>>
>> What private mail? Anything of interest to the rest of the group? As I
>
> Oops, I've just returned from holidays, and realize I never actually responded
> to this question. So here is the gist of it:
>
> | I had a closer look at the structures and bitfields, and I still think it's
> | possible to stay compatible with the current little endian layout:
> |   1. About half of the bitfields are actually bytes or 16-bit words. Hence
> |      these can easily be converted to __u8 or __le16.
> |   2. Most of the remaining bitfields sit in an 8, 16, or 32 bit integer.
> |      Hence these can be converted to such an integer (or an array of bytes,
> |      cfr. 3 below), and accessed using get_unaligned_le{16,32}() and a
> |      shift/mask operation.
> |   3. There are a few bitfields that sit in an `odd' number of bytes. These
> |      can be converted to an array of bytes, and accessed using
> |      get_unaligned_le{16,32}() and a shift/mask operation.
> |   4. The integral fields in the structs should be accessed using
> |      get_unaligned_le{8,16,32}(), too.
>
> I noticed the squashfs CVS repository is getting a new (incompatible) 4.0
> layout now?
>
> What do people think?
>

Last time I looked you were not the maintainer of squashfs.  Phillip
spent a long time examining the possibility of maintaining
compatibility but decided asthat there were sufficient advantages in a
new layout to warrant the change.

Rob.

> With kind regards,
>
> Geert Uytterhoeven
> Software Architect
>
> Sony Techsoft Centre Europe
> The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
>
> Phone:    +32 (0)2 700 8453
> Fax:      +32 (0)2 700 8622
> E-mail:   Geert.Uytterhoeven@eu.sony.com
> Internet: http://www.sony-europe.com/
>
> A division of Sony Europe (Belgium) N.V.
> VAT BE 0413.825.160 · RPR Brussels
> Fortis 293-0376800-10 GEBA-BE-BB
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Squashfs-devel mailing list
> Squashfs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/squashfs-devel
>
>

  reply	other threads:[~2008-07-17 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 15:33 Geert Uytterhoeven
2008-06-04  3:16 ` Phillip Lougher
2008-06-04  9:37   ` [Squashfs-devel] " Peter Korsgaard
2008-07-17 15:35     ` Geert Uytterhoeven
2008-07-17 15:47       ` Robert Lougher [this message]
2008-07-18  6:14         ` Geert Uytterhoeven
2008-07-18 12:37           ` Robert Lougher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d58509a80807170847p6ef05a8av96b6c8828a33821@mail.gmail.com \
    --to=rob.lougher@gmail.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=jacmet@sunsite.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@lougher.demon.co.uk \
    --cc=squashfs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®