From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793870600; b=eyN80t9wfbp3FD2U1OUxFxdCgLOEWM1WkDqUTTYxqz32s+/PdRZE3g7r13pwY/XM+Uq9 FfXiKIF7sOa4mWXi6IgaM1w+rs6vBT7ImS/xqx3R4KOE5WPP3jgnIgS0fHVNfNJPcEsJ3 U0XsGmzmS+rDDOy9Q50iTINa241m5GuoYegx/WMadc40tdoowrCk1LSf7MjH4Vo7BC/7q 9VIIwb6lw89y6PFGJtlECnL1fw46gRwP6Jmiy1Zv2SkO24h1i5QswgHq+c2IypLA6bdqJ gy+h79e7B+QD5b5kZdxPEvvVRr+lt08Uj0e8E5mQTHyDM9f9kbn4+XbnQtxKAwMb9PQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793870600; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=ki9y4eq2dEC7VWNO5IB8msQDS0Cuy6X4Ug5yP6t7pJM=; b=V6AJRiOzwuLG4yOSqQCSQP3iicmyunlwsfotATt5Yvqhm1roFrd7TixHRGzoPLO1UY94 qa46uODOW3wqwN5t8RKdWCWPjrHz3Ddd+i0laqHmH1oyiqVW/8lrbvuWxgFnKTNVxCK2u YwFKHrbL1+EltEQ7LYfFohUMXLyBlICq6QAHuC4vqp//CWgRc123AEudz+/RjTqGoyxKD R93MvwjhEZQWWOM05S1o6ZEORHPhUZbLXCNkLU6OnA+AIEoDALlpFsrlEovO2H10m9v94 455dQb9htURcfsWolTa1Xm/fNb8QIF8t6rv1qI9Jp/lZAB19/rgk20Ibh621eIQjgGQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cIdt0Tjo; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945D7606A31B; Thu, 5 Nov 2026 09:23:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cIdt0Tjo Received: by smtp.kernel.org (Postfix) with ESMTPSA id 269441F000C1; Thu, 5 Nov 2026 09:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793870600; bh=ki9y4eq2dEC7VWNO5IB8msQDS0Cuy6X4Ug5yP6t7pJM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=cIdt0TjomawwziUa68EDmJxEaKs/40F6e2sri8AFlQTOzxhTiRE0IsioyD3jQW5uh DLbeBEv2YcFrFP0KiJ1WxQq97+S8fgtKxHasEm264NpovVo+cgRVOt+oO5uPyAXIY9 zlSStHeNUGpfcEuFKIXq8H76rcZ7/5kaSIl8+YLK1az1qDqaV5fl2F2AmDmZ6owXcf R0i757EIl2z31wUcDtKlaHVbsWKwSeqyc+xddHHMKmhysRnMnJDQk13NVKSB/tt0cS JfzB2TvbeU2f5CfvVMudNg1YogQXMktQg134UU/8SEL/0qFVhmqaNad5UxkvzEtQe9 OLdMermuWH0Jg== Message-ID: Date: Thu, 5 Nov 2026 10:23:12 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports To: Nihal Kumar Gupta Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Vankadara , Vikram Sharma References: <20261102-glymur_camss-v1-0-fcb619fc7319@oss.qualcomm.com> <20261102-glymur_camss-v1-1-fcb619fc7319@oss.qualcomm.com> <20261104-real-nebulous-ostrich-017e92@quoll> <72064a9a-1b2e-4c24-99e2-2cc15a8dd7f1@oss.qualcomm.com> <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <539842db-c672-4549-b861-4a6f3be47556@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/11/2026 10:18, Nihal Kumar Gupta wrote: > > > On 05-11-2026 13:03, Krzysztof Kozlowski wrote: >>>> What is the problem exactly you are solving? >>>> >>> The problem is that CSIPHY4 is connected to CAMSS interface 4, so the >>> graph should describe it as port@4, not port@2. >> Nothing like this is explained in commit msg. >> > I will update commit message to explain it better. > >>> The previous port@3 description only worked through the X1E80100 resource >>> table indirection: >>> >>> port@3 -> csiphy_res[3] -> .csiphy.id = 4 -> CSID selects CSIPHY4 >>> >>> New standalone PHY path: >>> port@4 -> no csiphy_res[] lookup -> port number is id 4 -> CSID selects CSIPHY4 >> Then this breaks existing users, no? Anyway, what stops you from having >> there proper mapping? >> > No existing upstream user should break here; this is still part of the Glymur > CAMSS enablement. > > This follows the earlier discussion that CSIPHY4 should use the > CAMSS-side interface index as its graph port number: > > https://lore.kernel.org/all/CAFEp6-23L+4+yzVxX815ZA2x1_tN8SpzL7ciNcb9b+gBT67AdQ@mail.gmail.com/ Should use? Since when? Do you have DT maintainers ack on that? > >> Did you find any existing practice of numbering ports logical numbering >> in this device, but some other logic coming from datasheet? Where? >> > > Glymur has only CSIPHY0, CSIPHY1 and CSIPHY4; CSIPHY2 and CSIPHY3 are not > present on the SoC. Then CSIPHY4 is basically the third (so @2 counting from 0) input port, no? Not fifth. > > Using port@2 for CSIPHY4 would require a Glymur-specific port-to-CSIPHY mapping. > port@4 describes the CAMSS input directly and avoids introducing separate logical > numbering for Glymur. Seems you opened a new can of worms, so this needs proper justification. Again, do you see any recent preexisting DT review which would help to convince me? I know I usually ask not to use poor existing code as reason to do the same, but here I actually want to see proofs of current accepted practice. Best regards, Krzysztof