From: Samuel Holland <samuel@sholland.org>
To: Jernej Skrabec <jernej.skrabec@gmail.com>,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, wens@csie.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: dt-bindings: allwinner: video-engine: Fix number of IOMMU channels
Date: Wed, 16 Nov 2022 17:06:17 -0600 [thread overview]
Message-ID: <d58b5b89-380a-d967-9cd0-6dcf1bb9fe4d@sholland.org> (raw)
In-Reply-To: <20221116193105.363297-2-jernej.skrabec@gmail.com>
On 11/16/22 13:31, Jernej Skrabec wrote:
> Cedrus (video engine) on Allwinner H6 actually uses two IOMMU channel,
> not just one. However, Cedrus on SoCs like D1 only uses one channel.
>
> Allow up to 2 IOMMU channels.
>
> Fixes: 62a8ccf3a248 ("arm64: dts: allwinner: h6: Fix Cedrus IOMMU usage")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
> .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> index 541325f900a1..257bb372d166 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml
> @@ -55,7 +55,7 @@ properties:
> description: Phandle to the device SRAM
>
> iommus:
> - maxItems: 1
> + maxItems: 2
You need to add minItems: 1, or else this will require two items.
Regards,
Samuel
>
> memory-region:
> maxItems: 1
next prev parent reply other threads:[~2022-11-16 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 19:31 [PATCH 0/2] arm64: allwinner: h6: Add second IOMMU reference to Cedrus Jernej Skrabec
2022-11-16 19:31 ` [PATCH 1/2] media: dt-bindings: allwinner: video-engine: Fix number of IOMMU channels Jernej Skrabec
2022-11-16 23:06 ` Samuel Holland [this message]
2022-11-16 23:42 ` Rob Herring
2022-11-16 19:31 ` [PATCH 2/2] arm64: dts: allwinner: h6: Fix Cedrus " Jernej Skrabec
2022-11-16 23:07 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58b5b89-380a-d967-9cd0-6dcf1bb9fe4d@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®