mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Triet Hoang <triet.hoang.dev@gmail.com>,
	dri-devel@lists.freedesktop.org, Oded Gabbay <ogabbay@kernel.org>,
	Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Igor Paunovic <royalnet026@gmail.com>
Subject: Re: [PATCH v4 1/2] drm/rocket: Check allocations before use
Date: Mon, 17 Aug 2026 18:40:34 +0200	[thread overview]
Message-ID: <d593bdeb-e6f8-44d2-a444-e9197a8ed1a3@web.de> (raw)
In-Reply-To: <20260817140110.148873-1-89897892+HMTCT@users.noreply.github.com>

…
> +++ b/drivers/accel/rocket/rocket_job.c
> @@ -192,6 +192,9 @@ static int rocket_job_push(struct rocket_job *job)
>  
>  	bos = kvmalloc_array(job->in_bo_count + job->out_bo_count, sizeof(void *),
>  			     GFP_KERNEL);
…

I see opportunities for corresponding collateral evolution.
How do you think about to apply the attribute “__free(kvfree)” also in such
a function implementation by another update step?
https://elixir.bootlin.com/linux/v7.2-rc7/source/include/linux/slab.h#L1420

Regards,
Markus

  parent reply	other threads:[~2026-08-17 16:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260817055315.C9AA41F000E9@smtp.kernel.org>
2026-08-17  7:20 ` [PATCH v2] " Triet Hoang
2026-08-17  9:20   ` Markus Elfring
2026-08-17  9:31     ` [PATCH v3] " Triet Hoang
2026-08-17  9:55       ` Markus Elfring
2026-08-17 11:22         ` Triet Hoang
2026-08-17  9:30   ` [PATCH v2] " Igor Paunovic
2026-08-17 13:14     ` Triet Hoang
2026-08-17 14:01     ` [PATCH v4 1/2] " Triet Hoang
2026-08-17 14:01       ` [PATCH v4 2/2] drm/rocket: Keep scheduler allocation in rocket_file_priv Triet Hoang
2026-08-17 17:06         ` Markus Elfring
2026-08-17 16:40       ` Markus Elfring [this message]
2026-08-18  1:31         ` [PATCH v4 1/2] drm/rocket: Check allocations before use Triet Hoang
2026-08-18  5:48           ` [v4 " Markus Elfring
2026-08-18  6:21             ` [PATCH] " Triet Hoang
2026-08-17 14:28     ` [PATCH v2] " Triet Hoang
2026-08-18  1:55       ` Triet Hoang
2026-08-18  1:56       ` Triet Hoang
2026-08-18  4:15     ` [PATCH v5 1/2] " Triet Hoang
2026-08-18  4:15       ` [PATCH v5 2/2] drm/rocket: Keep scheduler allocation in rocket_file_priv Triet Hoang
2026-08-18  4:23         ` [PATCH v5] drm/rocket: Check allocations before use Triet Hoang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d593bdeb-e6f8-44d2-a444-e9197a8ed1a3@web.de \
    --to=markus.elfring@web.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ogabbay@kernel.org \
    --cc=royalnet026@gmail.com \
    --cc=tomeu@tomeuvizoso.net \
    --cc=triet.hoang.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®