From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S970425AbdIZUTz (ORCPT <rfc822;w@1wt.eu>);
        Tue, 26 Sep 2017 16:19:55 -0400
Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:18493 "EHLO
        esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S967680AbdIZUTw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Sep 2017 16:19:52 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.166.132.198
X-IronPort-AV: E=Sophos;i="5.42,441,1500958800"; 
   d="scan'208";a="990483842"
X-DLP: DLP_GlobalPCIDSS
To: <pali.rohar@gmail.com>
CC: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
        <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>,
        <quasisec@google.com>
Subject: RE: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi
 descriptor check
Thread-Topic: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi
 descriptor check
Thread-Index: AQHTNwPCuwyBIhJXPESKiX/qu3pqvaLHm2mA
Date: Tue, 26 Sep 2017 20:19:50 +0000
Message-ID: <d59f64d339a1425b9bb4ac590fff4cb9@ausx13mpc120.AMER.DELL.COM>
References: <cover.1506451187.git.mario.limonciello@dell.com>
 <4178d2bdfc69c94fe4972fee7b97b08202890e66.1506451187.git.mario.limonciello@dell.com>
 <201709262211.57222@pali>
In-Reply-To: <201709262211.57222@pali>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.18.86]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v8QKK0iW012563

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Tuesday, September 26, 2017 4:12 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> quasisec@google.com
> Subject: Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi
> descriptor check
> 
> On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote:
> > +	if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
> 
> Should not be this memcmp? IIRC we want to compare that buffer is equal
> to some bytes, right?
> 

It used to be comparing the bytes, but Andy S. thought this wasn't very clear.
That's why I adjusted it to compare to the strings that the bytes used instead.