From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933372AbdBHNSe (ORCPT ); Wed, 8 Feb 2017 08:18:34 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:59090 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932242AbdBHNS3 (ORCPT ); Wed, 8 Feb 2017 08:18:29 -0500 Subject: Re: [PATCH v2 10/16] net: stmmac: Correct the error message about invalid speed To: Corentin Labbe , , References: <20170208083121.27949-1-clabbe.montjoie@gmail.com> <20170208083121.27949-11-clabbe.montjoie@gmail.com> CC: From: Giuseppe CAVALLARO Message-ID: Date: Wed, 8 Feb 2017 14:18:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170208083121.27949-11-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-08_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/8/2017 9:31 AM, Corentin Labbe wrote: > The message about invalid speed does not state 1000 as a valid speed. > It is much simpler to said that the speed is invalid. > > Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index a13fcc4..ed81375 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -738,8 +738,7 @@ static void stmmac_adjust_link(struct net_device *dev) > break; > default: > netif_warn(priv, link, priv->dev, > - "Speed (%d) not 10/100\n", > - phydev->speed); > + "broken speed: %d\n", phydev->speed); > break; > } > >