mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ellie Reeves <ellierevves@gmail.com>
To: Gabriel C <nix.or.die@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: christian.brauner@canonical.com,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Seth Forshee <seth.forshee@canonical.com>
Subject: Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn
Date: Sat, 22 Dec 2018 23:12:33 -0500	[thread overview]
Message-ID: <d5ab1cb4-6d4a-4d57-0c70-3377549086e2@gmail.com> (raw)
In-Reply-To: <CAEJqkgjF7HBcvD=2QHTTipjv1kmpWwRATp1VLnu8KDe6cGMvhg@mail.gmail.com>

Hi,
I would like to thank you all for reacting to this issue so quickly, and 
I am really sorry for sending the message several time. I thought there 
was a problem with the way it was formatted or some such, hence why I 
sent it several times, because none of the messages seemed to get through.
So yeah, real sorry about that bit, and thanking you all

Gabriel C a écrit :
> Am So., 23. Dez. 2018 um 00:02 Uhr schrieb Linus Torvalds
> <torvalds@linux-foundation.org>:
>>
>> On Sat, Dec 22, 2018 at 2:49 PM Christian Brauner
>> <christian.brauner@canonical.com> wrote:
>>>
>>> To be fair, no one apart from me was pointing out that it actually
>>> breaks people including systemd folks
>>> even though I was bringing it up with them. I even tried to fix all of
>>> userspace after this got NACKED
>>
>> Seriously, the "we don't break user space" is the #1 rule in the
>> kernel, and people should _know_ it's the #1 rule.
>>
>> If somebody ignores that rule, it needs to be escalated to me.
>> Immediately. Because I need to know.
>>
> 
> I do that usually but I didn't saw Christian's revert the time and I
> never hit that issue.
> Just saw that now because the unusual  [BREAKAGE] prefix.
> 
>> I need to know so that I can override the bogus NAK, and so that we
>> can fix the breakage ASAP. The absolute last thing we need is some
>> other user space then starting to rely on the new behavior, which just
>> compounds the problem and makes it a *much* bigger problem.
>>
> 
> Yes and you are right ..
> https://github.com/lxc/lxc/pull/2438
> 
> I've added an comment there about 4.20.0.
> 
> BR,
> 
> Gabriel
> 

  reply	other threads:[~2018-12-23  4:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22 11:39 Ellie Reeves
2018-12-22 20:57 ` Gabriel C
2018-12-22 22:20   ` Linus Torvalds
2018-12-22 22:48     ` Christian Brauner
2018-12-22 23:01       ` Linus Torvalds
2018-12-22 23:07         ` Christian Brauner
2018-12-22 23:28           ` Linus Torvalds
2018-12-23 10:54             ` Thomas Backlund
2018-12-24  8:08               ` Greg KH
2018-12-22 23:32         ` Gabriel C
2018-12-23  4:12           ` Ellie Reeves [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-12-22 14:36 Ellie Reeves
2018-12-22 10:44 Ellie Revves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5ab1cb4-6d4a-4d57-0c70-3377549086e2@gmail.com \
    --to=ellierevves@gmail.com \
    --cc=christian.brauner@canonical.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nix.or.die@gmail.com \
    --cc=seth.forshee@canonical.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®