From: Krzysztof Kozlowski <krzk@kernel.org>
To: fengchenguang@kylinos.cn, s.nawrocki@samsung.com, mchehab@kernel.org
Cc: peter.griffin@linaro.org, alim.akhtar@samsung.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] media: exynos4-is: Fix runtime PM usage counter leak in fimc-isp
Date: Wed, 30 Sep 2026 14:05:41 +0200 [thread overview]
Message-ID: <d5b4602c-e95f-461f-843c-7a86d8582a32@kernel.org> (raw)
In-Reply-To: <20260930113849.278562-1-fengchenguang@kylinos.cn>
On 30/09/2026 13:38, fengchenguang@kylinos.cn wrote:
> From: Chenguang Feng <fengchenguang@kylinos.cn>
>
> fimc_isp_subdev_s_power() increments the usage counter with
> pm_runtime_resume_and_get() and releases it if fimc_is_start_firmware()
> fails, but not when fimc_is_hw_initialize() fails further down: the
> function then returns with the counter still held, and the device can
> never runtime-suspend afterwards.
>
> Call pm_runtime_put() on the fimc_is_hw_initialize() error path as
> well, like the fimc_is_start_firmware() path already does.
>
> Fixes: 9a761e436843f ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chenguang Feng <fengchenguang@kylinos.cn>
> ---
How many separate patches are you planning to send? Why this cannot be a
patchset? Are we repeating now the recent half-spam of AI created "fixes"?
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-30 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 11:38 fengchenguang
2026-09-30 12:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b4602c-e95f-461f-843c-7a86d8582a32@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=fengchenguang@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®