From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f227.google.com (mail-vk1-f227.google.com [209.85.221.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F18539A4BA for ; Sun, 2 Aug 2026 10:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785666326; cv=none; b=hJtpN7Dft2xIyqQTPw+rJC662FiIGfsV5Hqenb4+DhOTsUvsbxJZ9ZcZ8TcUVVOB9yC08zLNEluA5DnyCmNBbBzDGSc8bMTKPQ4a2CaEpKd5ToBdQBl+zy6Skz7QlgHkweWfif9/QQ70uiffziVv11hKoeGd5aXEX7IloUHwHzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785666326; c=relaxed/simple; bh=pck+pClOKblcqDWxsPRoWg8rfy6K+Grrr1EREHE3oKM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=JqmCYUJ2irLd7DIk2LfP7uzm7zWxRIP/m+r/3Li3zfM++eO6FCzpne3yEtktR+t2aZYr3gxMW7q+ADpXh6JV/I56YkYt8EciYYPM4LgX/ktyhyNiMQ+u7H5Vb8ABMpdUwRrqOZMK4PQQEG5WuuO/selg5/T5ZpjgEh8kllrUKjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hbzswvKG; arc=none smtp.client-ip=209.85.221.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hbzswvKG" Received: by mail-vk1-f227.google.com with SMTP id 71dfb90a1353d-5bfb3347ce0so837158e0c.2 for ; Sun, 02 Aug 2026 03:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785666318; x=1786271118; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=U30tOpuVn8qhXLPjIH2/nfOt+KCdmSRNh2hKzUS0a7U=; b=AfZ/NFnKH+/HKa8TNScS3ZT/JLmfi+gkJYf8asBrCMu46z6NsxUZdG/NqhSCTSBarv 8ryAgWbT3Wue25XGaLUJ6ZcF2bxnF70eesbcuEoL5IbWvnoOUxmTnndEDkYWAjhAAAVs 5aACvdVnM6acv3pQ+M57qer4FVimpD7L1g7cMnPQrUV1gPC9PTmdm2cBa2NupB9P5jY8 m/kXdyu3GKmL3JSMa0xF2kDPh/Fm4+iJm0PwQWFw11DbXRKuMxbG1cqmSo1XkeR/CXZ2 D9xxSF6snR/36R739ierKCFECGIorwpxThXZHcsehosauGZJf+Bz/ZrGZwS+RdgSCtRH rUVQ== X-Forwarded-Encrypted: i=1; AHgh+Rq8suNHFQUsmEuXLeL6vdzSHuHf3l2e1I2VBPIUGDfsD39+jVgRQ2jpkJMeE8qiS4244B8ijnNr7Vc6530=@vger.kernel.org X-Gm-Message-State: AOJu0YwqfIgQe9qJVQgf3hzip+2O5UXG6+1AZXO3ONQwbi7Ewh+Hq5KH aUcJTwBxtbxa5xJFa43wDUxUP9FUae/vhtubqTlEoUAMhz3DNmbCvhmW0e9l9/JSeEp5oaaeH8H eIv9yUZV1QpDuoSFP0Qzu/TOInGs0V2tXasqyr5oejxbdZHuQ5GfznuIY2vbaABqZsw9nPbksDx RpD31EHYa/5tYlVBj+2Bu1w5QXS9Y4rvoPwdBf6bp0x061ryVTTmmdLz8Sb6QC2TJ0kDK1RsJwP bR+fIuZFLGcIcZbuIboP6YX7A== X-Gm-Gg: AR+sD10ven5y4ZK8/TdOnKz04cT5+nW43zDp1KzEqtn8NjofSea/SAt6oKnav4igQTL m8QasbnAgk6GtsRjbIh/zWq//t30h1kggeGBkegrbW6dVZQ1UkOKErA28qvbMsOuTn1zvv1n96C BE4J17bQZi+YYSpMYXexfCfo+R6D8HZsAyFGUbtBb+jgLIlRdTXFMId8tk5mlBL7DIRVJu9YgWo eoBCBUWCedEImy1sEV70oP4JGa64uhkPMBuCkxUZTpIiW0X/I3RDl8HghSsN2zczjbqMOwDWku1 6985PrFfVdH88bk69F8Pe4kRlHVUPXFX59wwv3iXOpLmyrmwnboFkGFEhX40auGQS2ac5nVWdzy tHAgMeiMVaw+KsZHzRKxslZCnt+dbVt/4M0K0RtaC/IS3xc0KIKPW9RnfEi1eRV1OM4WbLrkiKY mi8lpmC0ie4c5oIgAmcD626gfIyspxxc97WTT6Qk4= X-Received: by 2002:a05:6123:122:b0:573:a779:62cf with SMTP id 71dfb90a1353d-5c3876d902fmr1679380e0c.7.1785666318252; Sun, 02 Aug 2026 03:25:18 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-27.dlp.protect.broadcom.com. [144.49.247.27]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-5c37ecf5518sm808463e0c.7.2026.08.02.03.25.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 03:25:18 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cab048cdb3eso3231298a12.0 for ; Sun, 02 Aug 2026 03:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785666317; x=1786271117; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=U30tOpuVn8qhXLPjIH2/nfOt+KCdmSRNh2hKzUS0a7U=; b=hbzswvKG+60l4KC5opdp+YoxTEYW/2w+jgzB2YKl0dwnEWTq6FAd3ac5bRh643U4AK 9PFtnA32PxqeqMfTEq1Wl1+o+IiMOAV41xbyc1N9CiEVtaLE+MWPRTKXY/Hg52oEcPPs HzhMFxYCxBJykqXlRNp9h4N8mo0nRl0bhnx+w= X-Forwarded-Encrypted: i=1; AHgh+RpwQakLZmKqqGUFKvCtZGkqg0szMvt3xN62UfWf2ZhvE1mTLNZ9d5OQLw/InQg1+Rx9r7Xl70LefVl1hOU=@vger.kernel.org X-Received: by 2002:a05:6a21:3a4a:b0:3c4:14a3:fed4 with SMTP id adf61e73a8af0-3c92a8f5e7fmr6805477637.55.1785666316992; Sun, 02 Aug 2026 03:25:16 -0700 (PDT) X-Received: by 2002:a05:6a21:3a4a:b0:3c4:14a3:fed4 with SMTP id adf61e73a8af0-3c92a8f5e7fmr6805451637.55.1785666316514; Sun, 02 Aug 2026 03:25:16 -0700 (PDT) Received: from [10.229.42.78] ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab1334cfsm22570319c88.1.2026.08.02.03.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 03:25:15 -0700 (PDT) Message-ID: Date: Sun, 2 Aug 2026 12:25:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/8] wifi: brcm80211: performance and stability fixes From: Arend van Spriel To: Shivesh Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org References: <20260731160646.3812-1-chanelshivesh@gmail.com> <20260802101530.4028803-1-arend.vanspriel@broadcom.com> Content-Language: en-US In-Reply-To: <20260802101530.4028803-1-arend.vanspriel@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 02/08/2026 12:15, Arend van Spriel wrote: > On Fri, 31 Jul 2026 16:06:17 +0000, Shivesh wrote: >> This series fixes several performance bottlenecks and correctness >> issues in both brcmfmac (PCIe/SDIO) and brcmsmac drivers. > > Two blockers need to be fixed before any of this can be applied: > > - 2/8: num++ was dropped from the subframe-parse loop. cnt is always 0 > on return, so rd->seq_num += cnt - 1 underflows to 255 (u8) on every > successful glom receive, corrupting sequence-number tracking for all > subsequent packets. > > - 4/8: pmksa->fils_cache_id does not exist in struct cfg80211_pmksa; > the correct field name is cache_id so this does not compile. > > Beyond the blockers, please split the series into separate submissions: > 1. Stability and correctness fixes (3/8, 5/8 TX-stall fix, 6/8 Fixes > tagged part) > 2. Performance improvements (1/8, 2/8, 5/8, 6/8 performance parts) > 3. New functionality and comment-only patches (4/8 PMKID_V2,7/8, 8/8) > > This makes it easier dealing with fixes that should go to stable trees. > For the stability series you can add Cc: stable@vger.kernel.org and a > Fixes: tag in the commit message. > > Regarding patch 1/8: the patch also fixes a race where a ring state > changes RING_OPEN->RING_CLOSING while blocked causes a permanent > netif queue stop. The fix relies on the atomic counter so keeping them > together is fine, but this change is primarily a potential bug fix so > rephrase the subject, e.g. "fix blocked-ring race permanently stopping queue" > > Finally, some of the commit messages seem to use LLM lingo so if there > was a coding assistent used please add an Assisted-by tag as required by > Documentation/process/coding-assistants.rst. Some additional remarks. Have these patches all been tested and if so please add reference to the platform used. Especially for the performance improvements it would also be good to have some profiling information as to how much performance gain these patches provide. Regards, Arend