From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: David Kahurani <k.kahurani@gmail.com>
Cc: ericvh@gmail.com, lucho@ionkov.net, asmadeus@codewreck.org,
linux_oss@crudebyte.com, linux-kernel@vger.kernel.org,
syzbot+cb1d16facb3cc90de5fb@syzkaller.appspotmail.com,
v9fs-developer@lists.sourceforge.net,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] 9P FS: Fix wild-memory-access write in v9fs_get_acl
Date: Sat, 11 Mar 2023 21:35:41 +0400 [thread overview]
Message-ID: <d5bb5ff0-1102-c7cd-c21b-c3a7f4f31717@gmail.com> (raw)
In-Reply-To: <CAAZOf24yhpSBd1926v7T=qDwqvFfLsWMJeMKTafeZ=69hJ4rdw@mail.gmail.com>
> I'm not sure what are the rules around here but I prefer to use brackets
> more generously.
I think in this particular case they can just make the code less
readable (considering they will not change the behavior in any way).
However, this is eternal discussion and I saw examples of both in the
kernel sources.
next prev parent reply other threads:[~2023-03-11 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 20:26 Ivan Orlov
2023-03-11 5:16 ` Siddh Raman Pant
2023-03-11 6:12 ` Ivan Orlov
2023-03-11 17:30 ` David Kahurani
[not found] ` <CAAZOf24yhpSBd1926v7T=qDwqvFfLsWMJeMKTafeZ=69hJ4rdw@mail.gmail.com>
2023-03-11 17:35 ` Ivan Orlov [this message]
2023-03-12 10:38 ` Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5bb5ff0-1102-c7cd-c21b-c3a7f4f31717@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@gmail.com \
--cc=k.kahurani@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=syzbot+cb1d16facb3cc90de5fb@syzkaller.appspotmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®