From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E618C433DB for ; Thu, 4 Feb 2021 18:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 360BC64F65 for ; Thu, 4 Feb 2021 18:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239293AbhBDSsF (ORCPT ); Thu, 4 Feb 2021 13:48:05 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:8537 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239366AbhBDSoz (ORCPT ); Thu, 4 Feb 2021 13:44:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1612464295; x=1644000295; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=bLTbvpLrEHxq5RI+rYCa3j+E1tXZ1nPttjCvTxH1lBo=; b=nigY+C90r0EymCjua+vR3S7rP9qTdssPISrRYRCH/l0/rceGsfydVdkT mO3mnu7TipSokIbltfNB/0VzKp9CogFKQyEDsjeCdBj3gCBehh/cV1kjJ +9ulfsfkZ26lmyHl0TQaKABpG5d1vAxfcuLaYVt1WFfI1Y5l+qJVZjpOO kySnm9LJZtxfGbAUqcw9KTNVRT+ekocFfBkJUA1v0nT8Q0bKfYYJkk6+r xpmnSZOt/B+d5luPDl8nNJncqVGxaN/XYtLO5PmclXMi62l+nAhH5l/wQ I2rGG85eR8TS5lMxB5h83uihOl1urub4/+9JhyPZvlUBJpjsc/0teZIFF g==; IronPort-SDR: eBql+5flRwgc+oDmGTlZF9RKUq4v1KWEeMtbEx4ZXLcJYkkofIYtx8AbnPU149a+52HFeWaWwy OqBtCZt5W4f1jRgAmbNCHQC+wTEf2qeuymTAJifC63KzX4wNqZcu6UOj9wiNc21lveeu/tVp0S TqiLjvljRimti5Iv/prihHIgIy3TCgs+d5XlrjQDhNAtwz3lxJFwRS1LJfTV0NFwcLHnj5qRWx hvZJs0Dz01fO8ix3KL4Wk4UOpSLcNWW/ev5F4CXRda1DSXWQLAYqtDTU7WeJ52A+Ecoelw//yH mEU= X-IronPort-AV: E=Sophos;i="5.81,153,1610434800"; d="scan'208";a="102622916" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 Feb 2021 11:43:37 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 4 Feb 2021 11:43:37 -0700 Received: from [10.171.246.84] (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Thu, 4 Feb 2021 11:43:33 -0700 Subject: Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend To: Arnd Bergmann , Russell King , Alexandre Belloni , Ludovic Desroches , Nathan Chancellor , Nick Desaulniers , Claudiu Beznea List-Id: CC: , Arnd Bergmann , Stephen Boyd , , , References: <20210204160129.2249394-1-arnd@kernel.org> From: Nicolas Ferre Organization: microchip Message-ID: Date: Thu, 4 Feb 2021 19:43:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210204160129.2249394-1-arnd@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2021 at 17:01, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compiling with the clang integrated assembler warns about > a recently added instruction: > > :14:13: error: unknown token in expression > ldr tmp1, =#0x00020010UL > arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation > at91_plla_enable > > Remove the extra '#' character that is not used for the 'ldr' > instruction when doing an indirect load of a constant. > > Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60") > Signed-off-by: Arnd Bergmann Looks good to me: Acked-by: Nicolas Ferre Thanks! Best regards, Nicolas > --- > arch/arm/mach-at91/pm_suspend.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index 909856c8a8c6..0d467cc40129 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode) > str tmp1, [pmc, #AT91_PMC_PLL_UPDT] > > /* step 2. */ > - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA > + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA > str tmp1, [pmc, #AT91_PMC_PLL_ACR] > > /* step 3. */ > -- > 2.29.2 > -- Nicolas Ferre