From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, <linux-riscv@lists.infradead.org>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>, <tglx@linutronix.de>,
<daniel.lezcano@linaro.org>, <kernel-team@android.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: clocksource: timer-riscv: Depend on the SBI
Date: Thu, 26 Nov 2020 09:00:08 +0800 [thread overview]
Message-ID: <d5ce9003-b070-0dfc-042c-a2879b992959@huawei.com> (raw)
In-Reply-To: <20201125195804.3780975-1-palmer@dabbelt.com>
Hi Palmer， I send a same patch and have been acked from you : )
https://patchwork.kernel.org/project/linux-riscv/patch/20201028131230.72907-1-wangkefeng.wang@huawei.com/
On 2020/11/26 3:58, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Fundamentally this is an SBI timer driver, so it cannot be enabled without
> support for the RISC-V SBI.
>
> Fixes: d5be89a8d118 ("RISC-V: Resurrect the MMIO timer implementation for M-mode systems")
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68b087bff59c..3eeaf0efba8f 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -655,6 +655,7 @@ config ATCPIT100_TIMER
> config RISCV_TIMER
> bool "Timer for the RISC-V platform" if COMPILE_TEST
> depends on GENERIC_SCHED_CLOCK && RISCV
> + depends on RISCV_SBI
> select TIMER_PROBE
> select TIMER_OF
> help
prev parent reply other threads:[~2020-11-26 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 19:58 Palmer Dabbelt
2020-11-26 1:00 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5ce9003-b070-0dfc-042c-a2879b992959@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®