From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27BAD170A15 for ; Sun, 8 Dec 2024 16:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733676251; cv=none; b=eDrq/G3XEovxXCTrU1VqwM7BCngEsDjfQhBLNPFGlrl66GsaoDFXu3BhicQ/t5EtTkNokBsMTNsBuqPza2RrueoHVNm/mjPmOknGJlg8ptBIxleViFyExedWlNRUlHfI5yYmJkDc12Xp/SNAnn8fnVYWKzVQ5S2QKjpbkRnZ9IA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733676251; c=relaxed/simple; bh=u18GVkcun9bmHffXCJyLVQo9hlXnvo82onfpHRp1QD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V9vQ4wUFymqK6vyK4wch+Nzjqfn2Nf05bnZdYJtr8bU2TpmxBNOAJVEbuL6PrWuuSTKKazIRBKvRA+yDzaDVLnJkvmOswBZo1EcaZKTLpNo6upgInYNJuF6lQFRKSlMX1ZxQAgynbpAIi4LK+JsPIkvyejtb+0IDUz9/n+V4ZwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Da+iT3uX; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Da+iT3uX" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3862b364538so1225277f8f.1 for ; Sun, 08 Dec 2024 08:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733676247; x=1734281047; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZOi2LT6/bSAyzBeK+6Fj/VJjHRIZTnvrX9jpLhKvAB0=; b=Da+iT3uXRdif3Rn3fy6JoeSY2AoUFpAHj2n+9GqSki9JyOreWq/gXD+7UFqwvZh0SP z7zsa84CfPFU+N+f8L1zTs7eoaekO+2ourf9G7+xum/jG/5dlBolrZRlKoMmzgsMIEDo /CDYSZULm25HsPUMPj/BtNVMvx2KBoMGqvPA7H/yocbDdgOoaeAeEJqbQXYVe3aTnc92 r3v33+ARPRb4DQS3CCKmQ5DPPpvVBE1gJsiee+Sx/E0SD+ho3g2nec5x3SSVOzGoG4fN 7aY7rbmnfD7PKuNS42/r803WCg2ucUYd+qah/dOLzWcpNjF+SlW8Ra/9kspuBRIPzKkb 1M7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733676247; x=1734281047; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZOi2LT6/bSAyzBeK+6Fj/VJjHRIZTnvrX9jpLhKvAB0=; b=UcdO4JL1tLuIwseMNYdE6k5cWBAs2MrvJ8zv0c0uZNywxZzqkgkHpCMVUT3b6zIB7L Yfpee06BEaoLBx3LFCbWSXUiPlbPLPq4W8nFzUiqxO61AtS/IGpmv9/UjDj9KbMjLvq6 7mWuRDvMGjDAi3FdyWL5KvWzBJAC97LLulBg3tlzigtgyt4MLtdXu+IapTogo7cKAnTc iPm56xQpKlerT5zCbgsg2NSbcWlcKkRmlc4YIe0vVNrpvvuCWuB68Vh9CdRclBt1+i6a iEAY3dNgWmP/wZozz26j14wQ6B6mHB36mf4VywJ3P7SOQSd/WJskVS6mP3ADF34pk22Q SiYQ== X-Forwarded-Encrypted: i=1; AJvYcCWwua55/XhWWm6S+kMPrUgbavTJT2FHwC+BrNruC40JV/jg7ZpZIZ3J6/XnfbCa+ziRwo9/BPGSOs3Gk2o=@vger.kernel.org X-Gm-Message-State: AOJu0YwIdviDUWj0k4hYr0gzQIRJThqmtrcq7ZFTBCxvrthWl/kELu9K CRIjybFKptAbb37PhvqbmJyd3rNMBVsRWJJG1MaQL2eHHhTAbdo7KrClkf/c8ug= X-Gm-Gg: ASbGncvDy6OXgY8X5r5uYXFrixMZF44HGBp2eit6kvi3wi8riATKGy6WxL2gwrLFcFJ zZqYhdK6rvsfFMR984d4XGsJku2CeuRGBfi57mVZHVc7rjzo3h/F+Unx4wU0u12X8UuUJbqr6b5 2OYCTmRuCZ5KFy6THdH1p00bicnCt+5GE0Ip1Zg1UXdpas7WvC+UOTzg8nk81VYuK8v1GqdUm74 DSLK+ntAbwNdvX7WOTbMyoDQPRamzJxRZeOpijyoDGdziyIZZATqA01+X4= X-Google-Smtp-Source: AGHT+IGGy6Ldhaa4YTjG8IieQa8Oj6Mw4sjYxJ+7EDklp4oAAKnvXJZlWaCkP9Zsx1bWxvnFCp2yYw== X-Received: by 2002:a5d:64e7:0:b0:385:ee85:f1bf with SMTP id ffacd0b85a97d-3862a8b530bmr7258225f8f.18.1733676247575; Sun, 08 Dec 2024 08:44:07 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3861f4a85f2sm10302736f8f.29.2024.12.08.08.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Dec 2024 08:44:07 -0800 (PST) Message-ID: Date: Sun, 8 Dec 2024 18:44:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/13] clk: at91: sama7d65: add sama7d65 pmc driver Content-Language: en-US To: Christophe JAILLET , Ryan.Wanner@microchip.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de Cc: dharma.b@microchip.com, mihai.sain@microchip.com, romain.sioen@microchip.com, varshini.rajendran@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org References: <6cf9921c6d312193c34f6f5cbd9eda7d0f9f317c.1733505542.git.Ryan.Wanner@microchip.com> From: Claudiu Beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08.12.2024 18:35, Christophe JAILLET wrote: > Le 06/12/2024 à 20:59, Ryan.Wanner@microchip.com a écrit : >> From: Ryan Wanner >> >> Add clock support for SAMA7D65 SoC. >> >> Increase maximum number of valid master clocks. The PMC for the SAMA7D65 >> requires 9 master clocks. >> >> Increase maximum amount of PLLs to 9 to support SAMA7D65 SoC PLL >> requirements. >> >> Signed-off-by: Ryan Wanner > > ... > >> +    for (i = 0; i < ARRAY_SIZE(sama7d65_gck); i++) { >> +        u8 num_parents = 4 + sama7d65_gck[i].pp_count; >> +        struct clk_hw *tmp_parent_hws[8]; >> +        u32 *mux_table; >> + >> +        mux_table = kmalloc_array(num_parents, sizeof(*mux_table), >> +                      GFP_KERNEL); >> +        if (!mux_table) >> +            goto err_free; >> + >> +        PMC_INIT_TABLE(mux_table, 4); >> +        PMC_FILL_TABLE(&mux_table[4], sama7d65_gck[i].pp_mux_table, >> +                   sama7d65_gck[i].pp_count); >> +        for (j = 0; j < sama7d65_gck[i].pp_count; j++) { >> +            u8 pll_id = sama7d65_gck[i].pp[j].pll_id; >> +            u8 pll_compid = sama7d65_gck[i].pp[j].pll_compid; >> + >> +            tmp_parent_hws[j] = sama7d65_plls[pll_id][pll_compid].hw; >> +        } >> +        PMC_FILL_TABLE(&parent_hws[4], tmp_parent_hws, >> +                   sama7d65_gck[i].pp_count); >> + >> +        hw = at91_clk_register_generated(regmap, &pmc_pcr_lock, >> +                         &sama7d65_pcr_layout, >> +                         sama7d65_gck[i].n, NULL, >> +                         parent_hws, mux_table, >> +                         num_parents, >> +                         sama7d65_gck[i].id, >> +                         &sama7d65_gck[i].r, >> +                         sama7d65_gck[i].pp_chg_id); >> +        if (IS_ERR(hw)) > > If we fail here, mux_table is not freed, because it is not stored yet in > alloc_mem. You're right! I missed that.