From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Linus Walleij <linusw@kernel.org>
Cc: andrew@lunn.ch, olteanv@gmail.com, kuba@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux@armlinux.org.uk, luizluca@gmail.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
gusfmora@gmail.com, kuncy7@gmail.com, fabianotassotti@gmail.com,
gabonpivovich@gmail.com, contact@c127.dev
Subject: Re: [PATCH net-next v11 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling
Date: Tue, 17 Nov 2026 09:53:15 +0100 [thread overview]
Message-ID: <d5d5e96a-d321-48b6-8c82-a1b224ab0be5@yahoo.com> (raw)
In-Reply-To: <CAD++jLkJxM2yE2QwsDijqnsP+bH=xNfcNy+yj3hbv1k+q9aJ=g@mail.gmail.com>
Hi Linus,
On Tue, Nov 17, 2026 at 09:34 Linus Walleij wrote:
> What about int rtl8366_set_pvid() which is shared in realtek.h and
implemented in rtl8366-core.c.
> (...)
> If you can confirm that this is the case also for PVID I can send a
patch to push this into the RTL8366RB driver.
Confirmed for PVID. rtl8365mb does not use rtl8366_set_pvid(), and none
of the realtek_ops VLAN callbacks you listed (get/set_vlan_mc,
get/set_vlan_4k, get/set_mc_index, enable_vlan, enable_vlan4k) are used
by it. Its PVID, VLAN MC and VLAN 4k handling is private to
rtl8365mb_vlan.c and works on its own struct rtl8365mb_vlanmc and struct
rtl8365mb_vlan4k, not on struct rtl8366_vlan_mc / rtl8366_vlan_4k.
The family_info callbacks in this series (vlan_4k_read/write,
vlan_port_get_pvid, vlan_pvid_port_set/clear, ...) are only an internal
split between family C and family D inside rtl8365mb. They do not touch
realtek_ops, realtek.h or rtl8366-core.c, so moving the shared rtl8366
VLAN/PVID helpers into the RTL8366RB driver would not conflict with this
series.
So please go ahead with that patch if you want to; I will rebase on top
of it if it lands first.
Best regards,
Mieczyslaw Nalewaj
next prev parent reply other threads:[~2026-11-17 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cf3fd237-2290-4002-8de0-ea4100ef0f85.ref@yahoo.com>
2026-11-17 7:34 ` [PATCH net-next v11 00/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-17 7:35 ` [PATCH net-next v11 01/13] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-17 7:36 ` [PATCH net-next v11 02/13] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-17 7:36 ` [PATCH net-next v11 03/13] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-17 7:37 ` [PATCH net-next v11 04/13] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-17 7:38 ` [PATCH net-next v11 05/13] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-17 7:38 ` [PATCH net-next v11 06/13] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-17 7:39 ` [PATCH net-next v11 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-17 8:23 ` Linus Walleij
2026-11-17 7:39 ` [PATCH net-next v11 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling Mieczyslaw Nalewaj
2026-11-17 8:34 ` Linus Walleij
2026-11-17 8:53 ` Mieczyslaw Nalewaj [this message]
2026-11-17 7:40 ` [PATCH net-next v11 09/13] net: dsa: realtek: rtl8365mb: use raw VID for PVID on family D Mieczyslaw Nalewaj
2026-11-17 7:41 ` [PATCH net-next v11 10/13] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-17 7:41 ` [PATCH net-next v11 11/13] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-17 7:42 ` [PATCH net-next v11 12/13] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-17 7:43 ` [PATCH net-next v11 13/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d5e96a-d321-48b6-8c82-a1b224ab0be5@yahoo.com \
--to=namiltd@yahoo.com \
--cc=alvin.sipraga@analog.com \
--cc=andrew@lunn.ch \
--cc=contact@c127.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabianotassotti@gmail.com \
--cc=gabonpivovich@gmail.com \
--cc=gusfmora@gmail.com \
--cc=kuba@kernel.org \
--cc=kuncy7@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luizluca@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®