From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbcI3I3m (ORCPT ); Fri, 30 Sep 2016 04:29:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbcI3I3i (ORCPT ); Fri, 30 Sep 2016 04:29:38 -0400 Subject: Re: [PATCH v2 2/3] KVM: VMX: join functions that disable x2apic msr intercepts To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20160929204133.1259-1-rkrcmar@redhat.com> <20160929204133.1259-3-rkrcmar@redhat.com> Cc: Wanpeng Li From: Paolo Bonzini Message-ID: Date: Fri, 30 Sep 2016 10:29:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160929204133.1259-3-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 30 Sep 2016 08:29:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2016 22:41, Radim Krčmář wrote: > for (msr = 0x800; msr <= 0x8ff; msr++) { > if (msr == 0x839 /* TMCCT */) > continue; > - vmx_disable_intercept_msr_read_x2apic(msr, true); > + vmx_disable_intercept_msr_x2apic(msr, MSR_TYPE_R, true); > } > > /* TPR */ > - vmx_disable_intercept_msr_write_x2apic(0x808, true); > + vmx_disable_intercept_msr_x2apic(0x808, MSR_TYPE_W, true); > /* EOI */ > - vmx_disable_intercept_msr_write_x2apic(0x80b, true); > + vmx_disable_intercept_msr_x2apic(0x80b, MSR_TYPE_W, true); > /* SELF-IPI */ > - vmx_disable_intercept_msr_write_x2apic(0x83f, true); > + vmx_disable_intercept_msr_x2apic(0x83f, MSR_TYPE_W, true); > > /* > * (enable_apicv && !kvm_vcpu_apicv_active()) || > * !enable_apicv > */ > /* TPR */ > - vmx_disable_intercept_msr_read_x2apic(0x808, false); > - vmx_disable_intercept_msr_write_x2apic(0x808, false); > + vmx_disable_intercept_msr_x2apic(0x808, MSR_TYPE_R | MSR_TYPE_W, false); Alternatively you could place the two function calls for 0x808 together: for (msr = 0x800; msr <= 0x8ff; msr++) vmx_disable_intercept_msr_x2apic(msr, MSR_TYPE_R, true); /* * TPR reads and writes can be virtualized even if virtual interrupt delivery * is not in use. */ vmx_disable_intercept_msr_x2apic(0x808, MSR_TYPE_R | MSR_TYPE_W, false); vmx_disable_intercept_msr_x2apic(0x808, MSR_TYPE_W, true); /* EOI */ vmx_disable_intercept_msr_x2apic(0x80b, MSR_TYPE_W, true); /* SELF-IPI */ vmx_disable_intercept_msr_x2apic(0x83f, MSR_TYPE_W, true); Paolo