From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433761E25F9 for ; Wed, 29 Apr 2026 14:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777474240; cv=none; b=HIpdTESttsC4bSb3wE3rbSFJ2MPSYbECqZb0W9rHMKGvdqdAGKrGamWhZFQX/6O7FS08IuKDoN4O5t0+YtY84Wauns4Xzw/TqL3rv+qVSYaiIOvv/24J3fFd4lfVYdnSd+QrLJyDlGhVKRwDHe6Gdr98aLSgHLf+xW67+CAwLZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777474240; c=relaxed/simple; bh=thfUlE0axhTR/XnrGpaLu6GUutQHpZ011AZmWf1HJPI=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=mPa+5cLNx/FAhwK/8Pc061ZHcWHrt2jBEW5lz3Pe1zPIKzKyN8zHE7vGQrwILqEZ0lJ7PHpkpV94FG+Ko5nUqGR5UfMOTjdT0i35TNje47chc4eh8RukvEfmvK9AKcCywi2/b0IsM1pAvtj3CCQjKqhVmJH1K7K4SxFJGNBBS4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EL18D2lC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EL18D2lC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C1F2C4AF0B; Wed, 29 Apr 2026 14:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777474239; bh=thfUlE0axhTR/XnrGpaLu6GUutQHpZ011AZmWf1HJPI=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=EL18D2lC5/TNS/vf9oGrmGdSZ+4/LQ+mYg5ueb0bmlDSu3hoInq+MXfPtV0x67xGj bFoN/koD35he2TRwnTokjaWdGCzWS+qT1sqbGedPGQ3jkN3U2F/zH1g0O2sre5yTx8 EfX668MAN91CFcLiP0F9TtkoKc7KHP5X2GS+xCr2U4DSHaNwH1Q3hTZPjfpZamf6j9 wGHJ1zsjAVNjAudxI1MU6AGaR2tUamwI6CGKjaEKEJeUdLvOfJ3boWuQXL5IqlD54O PwWyTr6NSfTkkm0nRGlb5CP9clEPN1ZEVk6BprN1UmG2NbOQqdICopWUs42g9ALJ2Z VNKPIk9LUnv4g== Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfauth.phl.internal (Postfix) with ESMTP id C2343F40070; Wed, 29 Apr 2026 10:50:38 -0400 (EDT) Received: from phl-imap-04 ([10.202.2.82]) by phl-compute-02.internal (MEProxy); Wed, 29 Apr 2026 10:50:38 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekgeejvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthhqredtredtjeenucfhrhhomhepfdetnhhnrgcu ufgthhhumhgrkhgvrhdfuceorghnnhgrsehkvghrnhgvlhdrohhrgheqnecuggftrfgrth htvghrnhepudeuveegffelvdelvdeiffehvedvvdetfeefgeefhfdvtdeufffgteevhfev teelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hnnhgrodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejjeduvddtjeel qdeffedvvdefgeejuddqrghnnhgrpeepkhgvrhhnvghlrdhorhhgsehnohifhhgvhigtrh gvrghmvghrhidrtghomhdpnhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepthhighhrrghnrdhmkhhrthgthhihrghnseguvghshidruggvpdhrtg hpthhtohepkhgvnhhnvghrrdhlihhnuhiguggvvhesghhmrghilhdrtghomhdprhgtphht thhopehsnhhithiivghrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehtrhhonhgumh ihsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhhutghkrdhlvghvvghrsehorhgr tghlvgdrtghomhdprhgtphhtthhopehjtghurhhlvgihsehpuhhrvghsthhorhgrghgvrd gtohhmpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghl rdhorhhgpdhrtghpthhtoheplhhinhhugidqnhhfshesvhhgvghrrdhkvghrnhgvlhdroh hrgh X-ME-Proxy: Feedback-ID: i20964851:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id A49BCB6006E; Wed, 29 Apr 2026 10:50:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AY8c0H4t9Dfo Date: Wed, 29 Apr 2026 10:50:17 -0400 From: "Anna Schumaker" To: "Kenner de Azevedo dos Santos Miranda" , "Trond Myklebust" Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, "Jonathan Curley" , "Tigran Mkrtchyan" , "Chuck Lever" , "Mike Snitzer" Message-Id: In-Reply-To: <20260428195919.29794-1-kenner.linuxdev@gmail.com> References: <20260428195919.29794-1-kenner.linuxdev@gmail.com> Subject: Re: [PATCH] nfs: flexfilelayout: fix unused-but-set variable 'err' Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Kenner, On Tue, Apr 28, 2026, at 3:59 PM, Kenner de Azevedo dos Santos Miranda w= rote: > The variable int err in f_layout_io_track_ds_error() is set but not=20 > used in the code. > > The warning was identified by running make w=3D1: > > warning: variable =E2=80=98err=E2=80=99 set but not used > > I set the (void)err to prevent the warning. Wouldn't it be better to handle the error instead of ignoring it? Thanks, Anna > > I didn`t test with hardware, i ran again the make w=3D1 and the warnin= g=20 > was removed. > > Signed-off-by: Kenner de Azevedo dos Santos Miranda > --- > fs/nfs/flexfilelayout/flexfilelayout.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c=20 > b/fs/nfs/flexfilelayout/flexfilelayout.c > index 8b1559171fe3..d9a0fed41eac 100644 > --- a/fs/nfs/flexfilelayout/flexfilelayout.c > +++ b/fs/nfs/flexfilelayout/flexfilelayout.c > @@ -1536,6 +1536,7 @@ static void ff_layout_io_track_ds_error(struct=20 > pnfs_layout_segment *lseg, > mirror, dss_id, offset, length, status, opnum, > nfs_io_gfp_mask()); >=20 > + (void)err; > switch (status) { > case NFS4ERR_DELAY: > case NFS4ERR_GRACE: > --=20 > 2.43.0