mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Paul Parsons <lost.distance@yahoo.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, Dave Gerlach <d-gerlach@ti.com>,
	Mark Rutland <mark.rutland@arm.com>, Nishant Menon <nm@ti.com>,
	Rob Herring <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver
Date: Fri, 19 Jan 2018 18:43:21 -0600	[thread overview]
Message-ID: <d5e1dda3-fb89-9280-6d68-b02996b5cd0c@ti.com> (raw)
In-Reply-To: <20180119234938.GB4180@atomide.com>

On 01/19/2018 05:49 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [180119 23:30]:
>> On 01/19/2018 03:33 PM, Tony Lindgren wrote:
>>> OK let's do some tests on that, I'll take a look at doing a dts
>>> file over next few weeks.
>>
>> You can look up the patches folder in the above repo, there are some
>> example nodes there already, they are rather straight-forward.
> 
> Just for reference, here's what I played with but keep getting
> -EPROBE_DEFER somewhere during init.

Hmm, What's the baseline branch you are using - mainline, linux-next or
your for-next?

> 
> Regards,
> 
> Tony
> 
> 	prm: prm@6000 {
> 		...
> 		ranges = <0 0x6000 0x3000>;
> 
> 		prm_dsp: prm@400 {
> 			compatible = "simple-bus";
> 			#address-cells = <1>;
> 			#size-cells = <1>;
> 			ranges = <0 0x400 0x100>;
> 
> 			dsp_rstctrl: rstctrl@10 {
> 				compatible = "ti,rstctrl";
> 				reg = <0x10 0x4>;
> 				#reset-cells = <1>;
> 			};
> 		};
> 		...
> 	};
> 
> 	target-module@4a066000 {
> 		compatible = "ti,sysc-omap2", "ti,sysc";
> 		ti,hwmods = "mmu_dsp";
> 		reg = <0x4a066000 0x4>,
> 		      <0x4a066010 0x4>,
> 		      <0x4a066014 0x4>;
> 		reg-names = "rev", "sysc", "syss";
> 		ti,sysc-mask = <(SYSC_OMAP2_CLOCKACTIVITY |
> 				 SYSC_OMAP2_SOFTRESET |
> 				 SYSC_OMAP2_AUTOIDLE)>;
> 		ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> 				<SYSC_IDLE_NO>,
> 				<SYSC_IDLE_SMART>;
> 		clocks = <&tesla_clkctrl OMAP4_DSP_CLKCTRL 0>;
> 		clock-names = "fck";
> 		resets = <&dsp_rstctrl 1>,
> 			 <&dsp_rstctrl 0>;
> 		reset-names = "rst2", "rst1";

We definitely do not want the two resets here for sure, as the rst2
belongs to the dsp core (I believe it would be a sibling node to mmu_dsp
here), and cannot be released from reset without programming the MMU and
loading the code.

regards
Suman

> 		#address-cells = <1>;
> 		#size-cells = <1>;
> 		ranges = <0 0x4a066000 0x1000>;
> 
> 		mmu_dsp: mmu@0 {
> 			compatible = "ti,omap4-iommu";
> 			reg = <0 0x100>;
> 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> 			#iommu-cells = <0>;
> 		};
> 	};
> 

  reply	other threads:[~2018-01-20  0:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  1:11 Tony Lindgren
2018-01-16  6:50 ` Tero Kristo
2018-01-16  9:30 ` Philipp Zabel
2018-01-16 15:03   ` Tony Lindgren
2018-01-16 21:22     ` Suman Anna
2018-01-16 23:22       ` Tony Lindgren
2018-01-19 20:22         ` Suman Anna
2018-01-19 21:33           ` Tony Lindgren
2018-01-19 23:29             ` Suman Anna
2018-01-19 23:49               ` Tony Lindgren
2018-01-20  0:43                 ` Suman Anna [this message]
2018-01-20  0:55                   ` Tony Lindgren
2018-01-22 17:03                     ` Tony Lindgren
2018-03-01 18:14     ` Tony Lindgren
2018-03-02  9:53       ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5e1dda3-fb89-9280-6d68-b02996b5cd0c@ti.com \
    --to=s-anna@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lost.distance@yahoo.com \
    --cc=mark.rutland@arm.com \
    --cc=nm@ti.com \
    --cc=p.zabel@pengutronix.de \
    --cc=philipp.zabel@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®