From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 487E12D24A8 for ; Fri, 12 Sep 2025 14:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757686782; cv=none; b=s+LKjgI01TxX99NXfl8Kt4eIil4ZunCErmC9n6uwI8+NeGb1TPJUU87uSExo4AG9mD0QgE50jqHaboTj5S3BPvk9tPhRrTWbVR3W0vvoEh2hScISk0EYogU26/j0+Tt3UBWzEI3T96jHg/wDwDn4nhB77NsiOwp4/FkU2qVOZ6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757686782; c=relaxed/simple; bh=hP65JmfhwJmWH6ux4J6yoXvAjKeM+s8/GCFzs+JAKbs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gocuqb7fYebQMrD+bfm5bRnI3rHzOlNg34kVedjQl4NcngAeOU1wvETKj0SpSFrHUwC0Yczph1FlVPXBxPY6o04LAkr1It74UWaub0jaqzPNz+SvW1pn7m6/eUC4hjJCzmAQ8hwG0vyjDmsdhJMiB3fvYGSbNUbajfyDyjAL4z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AIuSuuhz; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AIuSuuhz" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-30cceb749d7so741833fac.2 for ; Fri, 12 Sep 2025 07:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1757686779; x=1758291579; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SI0FVmuRZzP3RoX0Ughgr/ocMtvo4boFzev/pIdHsz4=; b=AIuSuuhz4gSbxhvodZlMvqtv786P1Y20sWucyvOtC2DOBVr2i7VGz9iNsEWGMr1EY3 EvFfaCUQ395npQ+2NXfQ4qAnLvKJjIX0YSbHN6UZai7jdSjov0wkCFr8uG+we2UEOppL 8Wh4W6T3G7RGSLQxc0MqgjCgxybN7Rk7XTA+JCCT6Gy4I78ON75hkmFEg/U00qRGe3mD n0imt0xhzHjuQEXNIC4+eSHq8SM5L9B32RMoCekkpqngU/7g4B/D3GGA0BFmt0AcXDHk 24uQ3MQV1HCfbm4asrAiqyoZR74W/Pu63LRABiZKP8lZ5K2ienVXAYLBr9lfGLpnMYGm cmEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757686779; x=1758291579; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SI0FVmuRZzP3RoX0Ughgr/ocMtvo4boFzev/pIdHsz4=; b=PrvvHLRIImLoWFZpXEJ1dmIkdnRpA4WFRCPexh5HbKDa4763qdePKkIau+QCt5fOev UYyuMOZ5RK+dFl0MB9lmgSdMMolsBQgft2z5E6aflcHicPzQWopdiT/QfgwaPEPYHQwN 6orAwXGrA8WW1dOp6ntwjFjaD2f4DngZ+dXTkP3tQeIXSS7AHwuxtRhKrXUgodiSe67z KmggwxX0xZFm7DaLKzQvHE7v6A8kJoZzZyoqTjHU47LypUHljJ0JaEO0abOM9PPPR33U qDQxMy5pbhSVgufFKURjdEqpXuiNOetIWNJDjzrISbbqdS8A3KaM0LeBdyVi8+mgXREb ATWQ== X-Forwarded-Encrypted: i=1; AJvYcCWoIXsU7BUnwJ6+SGsPwUmZDYMAu8NzccNLQ+qIqP0ofEvzu/49R6ihydsBWABF3kg+TYiyesZkOKMAg0k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+eYbvm3pD/MZT8amWbByJxyyxqpl1hogj8hF3bv1m4kgpG0AL wqtvLfzARUcbMMA4nswEX9uYBHr+nIlO7+hny5znrpimT7l71V+Sp4EF7mSTfAADoP8= X-Gm-Gg: ASbGncsVIoJFy2WM9FGs+PMPtJTB3+aBKH1aj7aFGOEgJ9kgKHUaPnyERe26GeNc0tc 5fk6e7uuOkBBSLJg1V1JvrZ7gllRKtAhFetXep0dBPy5g2R0yHPzj1n0Q1JNTrDQE0fqeP8P5DB CIVdYC4HWNtiGU2zIOkdsLlPHCBaJUlyL0x9Grm2ZgLGAbbJazzLs2l4mDRyF2QLVwWObCbbs5Y JZQbfssqb49iseOo740j1dT1QJwd5gH+d/CVAZLgZ85p8J0iHXGicNMEjXPN85w9WG+f9+L9jK/ 3GHFhhlnAgC/2EaxGgNIQdia9RIFuAJ0WwwcCrmNZ7hi4fPTkpe6VwyvGof79RUUT5ihNdpu9gA tyVztSwaWbNB8QEoX/KGqBuPP4ZjSo2M0MOOfcD5qQWXW2vsvAY8xSizE8c8kC/s6fBJgXrsvg3 A= X-Google-Smtp-Source: AGHT+IGVtrygXnW497Sb9d68zHBUC2goMyzzb0ofpsi1eyzIw+EncMLcIzM6izO+GNjJkhrNIKAM1g== X-Received: by 2002:a05:6870:63ac:b0:31a:e9e8:3018 with SMTP id 586e51a60fabf-32e54983c42mr1662429fac.5.1757686779053; Fri, 12 Sep 2025 07:19:39 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1? ([2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7524986ca64sm1034583a34.14.2025.09.12.07.19.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 07:19:38 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 09:19:36 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] iio: adc: ad7124: use guard(mutex) to simplify return paths To: Andy Shevchenko Cc: Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250911-iio-adc-ad7124-add-filter-support-v2-0-b09f492416c7@baylibre.com> <20250911-iio-adc-ad7124-add-filter-support-v2-3-b09f492416c7@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/11/25 11:39 PM, Andy Shevchenko wrote: > On Fri, Sep 12, 2025 at 12:42 AM David Lechner wrote: >> >> Use guard(mutex) in a couple of functions to allow direct returns. This >> simplifies the code a bit and will make later changes easier. > > From this and the patch it's unclear if cleanup.h was already there or > not. If not, this patch misses it, if yes, the commit message should > be different. > cleanup.h is already there. I'm not sure what would need to be different in the commit message though.