From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752831AbcHAKtw (ORCPT ); Mon, 1 Aug 2016 06:49:52 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:23555 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752754AbcHAKtp convert rfc822-to-8bit (ORCPT ); Mon, 1 Aug 2016 06:49:45 -0400 From: Amitkumar Karwar To: Heinrich Schuchardt , Nishant Sarmukadam , Kalle Valo CC: "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition Thread-Topic: [PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition Thread-Index: AQHR6ySu7ttSOM9q+ki0cj8/iukAPKAz7ZLQ Date: Mon, 1 Aug 2016 10:46:47 +0000 Message-ID: References: <877fc2816w.fsf@purkki.adurom.net> <1469967081-3937-1-git-send-email-xypron.glpk@gmx.de> In-Reply-To: <1469967081-3937-1-git-send-email-xypron.glpk@gmx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-01_08:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608010116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de] > Sent: Sunday, July 31, 2016 5:41 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Heinrich Schuchardt > Subject: [PATCH 1/1] mwifiex: key_material_v2 remove superfluous > condition > > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > index 128add8..0d4f9fe 100644 > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c > @@ -706,15 +706,10 @@ mwifiex_cmd_802_11_key_material_v2(struct > mwifiex_private *priv, > (priv->wep_key_curr_index & KEY_INDEX_MASK)) > key_info |= KEY_DEFAULT; > } else { > - if (mac) { > - if (is_broadcast_ether_addr(mac)) > - key_info |= KEY_MCAST; > - else > - key_info |= KEY_UNICAST | > - KEY_DEFAULT; > - } else { > + if (is_broadcast_ether_addr(mac)) > key_info |= KEY_MCAST; > - } > + else > + key_info |= KEY_UNICAST | KEY_DEFAULT; > } > } > km->key_param_set.key_info = cpu_to_le16(key_info); > -- > 2.8.1 Looks ok to me. Acked-by: Amitkumar Karwar Regards, Amitkumar