From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A19AE22D7B5 for ; Wed, 18 Mar 2026 01:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773797209; cv=none; b=iStQmptNX9c6xo6VSMM0YqEacpQr0sN354uMyET5yM4/qMsolb6GC4D/2X1ZcXk5UfH8c2MSpdQl97eTI35dbl1SqimAdQnRKozkUtq+mHhCT2tLShR+VyEFKfIZcCblOzfBoISWdxkmHad53+HHBpw3HKBvwcJp+2y7BmIIazc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773797209; c=relaxed/simple; bh=lws6mUjxOxt894KC8EDa+YmeqMZUPxAoxc5buAqlavw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fdNHerHazEqaPYineH8B+4fg3k24QD3HZKZA5fuFaCe8jo4Cx1SzZToiTdfNxqhxI3cfsqVfP3V0D+E8XZfLRu9YdENfXtvC2McelK+hR1nbF8v1E3/sKqGJ8xrHFDzNcVKOaU/RL1V3WP7Nvqr125x5BjwuIdsS6ldHyQ/VRsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=1jWhFq+c; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="1jWhFq+c" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-4671cbce626so2934742b6e.1 for ; Tue, 17 Mar 2026 18:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1773797206; x=1774402006; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+wLngegFvX4b1A6M7gXF8x6LDEglu2szAu+mVlUeGgM=; b=1jWhFq+cVF1+B8ujcanJSEixAu3uy8eRNBbmLH/3dX/rif9OCW/Sj4Hw6806WYpgZw EPvKkc07HeSiv+2a+APiEHg0G+M6UuszAsZKt14HdJkqenKXtP/0nq7zc0o1VXdkOQ5/ 1sP5s+kE7ur9t8U6+oZqmPLgKfC2FgpC19OvV5dNANrWEo4DfzkCkkKTuKBpJBDkn0iV tIupwYLdWK0+5VrU97gZwFX6NVEq/eXiykR0dWoK2I6OnIPkkR5g+DoQhOVC8lCYuvSy v9NPF7sDrqlsjZGBxCyhqa3/hxbZd6Z/x78p3LZJA5Jsl0dwEUal2q2jiHLd5vQdQuGh XNmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773797206; x=1774402006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+wLngegFvX4b1A6M7gXF8x6LDEglu2szAu+mVlUeGgM=; b=DqExjTbQk87+eQN6G6RlG/9o0gcArkBWATx6HEGoxJmH31i6lOINHnkz3zAEoAGCMC TpgYcNvMwVrFz1r8BVXSNd/lJ9Op5/hWnaTwztDzVa0XVlty2bawErWeArxrIW9s4+xE 7IioACHWyZfNq2maMBWCHq3tJN8nlCJz6Rgfx9D8CrVXBHl5vSbhVNhCtRZq0POA6n8+ 21mZzLjt7T8EaOiuf2RHHFx2g9191kGtLkD9sqwre6hC1V68Ie9PqMXGTSxg2YXBaqyE ucUSnx3EiUQuLkjAHoB6DJXUJcSnF0ziCXGe/xImL+2oaGNETMlCaS05PB542Neg1UQB ExvA== X-Forwarded-Encrypted: i=1; AJvYcCX92IaWl+00f2iQAxGHklJ1hpINi2ae/2EYBeYHgicyZVfuMfdJZnyFgk92Katvp0LBDRjRF6JnXKYXJeA=@vger.kernel.org X-Gm-Message-State: AOJu0YxFpGtZsuHsyTUIoUmvfzOffvd9VQCuenmwYUmQxBl1HJFs8ylR 1KOd7iTsVyL8HT9ECCVt0S2dVTM66ulS3oZy8UJbJ5736BdRjulwohAhhtkbfx/KS2M= X-Gm-Gg: ATEYQzxde1l/rJIFq51HyoqYsv8yMBzkbbNAMFnry7/gqQa+Q5CLTEwyniCt3Nvwnf0 0lUA53NAk2IvS2AMCNYs6IqqH3otOwOl0a43ZI2TnmNTluD9QJsOcJUdw7VE3DaNpcpBYSVgaLw 0tud1IoMwvlrzSTXnDJWFE/U8VcKuigTE6Z67jwNYQRQOTfhrUH8q/8d1zRiBrTz7IGxXHDpYMh 2BatzDKGMX95pC5IioV173QI1eQ2qwDR7c0A2nWPFzoxNqHbJqkpLTRRCRU5MfiX6t9BBxTKrRd XloZrcQt4i3xygl1s9elfnVqHk8mkog4nKh0en9hM1Vv2TfhRPSzYChGlx37myrQi4vHYSdjfwf uKtap7g+IkekQ4hMtnKwa5K00itAE9XTmmJ4XKsP28tmkRbIuZaKenbWmYdyBHVjae2V3CNGhOL W+x4QSxuBHdcZfZQGQK1i9cqwI1x52DWOPQPOTuH3YelMCTHSLbIxF8cPuqFfix2oQTwhAuXz3l 90SBEl/Cx3Q1Eo1w0um X-Received: by 2002:a05:6808:1308:b0:467:880:7441 with SMTP id 5614622812f47-467ba105148mr976117b6e.18.1773797206154; Tue, 17 Mar 2026 18:26:46 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 5614622812f47-467baa8dc58sm800637b6e.12.2026.03.17.18.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 18:26:45 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 19:26:43 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL To: Caleb Sander Mateos Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Anuj Gupta , Kanchan Joshi , Ming Lei References: <20260302172914.2488599-1-csander@purestorage.com> <177369928494.700746.8101380068186003544.b4-ty@kernel.dk> <307e4126-91ed-4ca8-9eb0-3f24f1490aa8@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/17/26 6:47 PM, Caleb Sander Mateos wrote: > On Mon, Mar 16, 2026 at 6:01 PM Jens Axboe wrote: >> >> On 3/16/26 4:14 PM, Jens Axboe wrote: >>> >>> On Mon, 02 Mar 2026 10:29:09 -0700, Caleb Sander Mateos wrote: >>>> Currently, creating an io_uring with IORING_SETUP_IOPOLL requires all >>>> requests issued to it to support iopoll. This prevents, for example, >>>> using ublk zero-copy together with IORING_SETUP_IOPOLL, as ublk >>>> zero-copy buffer registrations are performed using a uring_cmd. There's >>>> no technical reason why these non-iopoll uring_cmds can't be supported. >>>> They will either complete synchronously or via an external mechanism >>>> that calls io_uring_cmd_done(), io_uring_cmd_post_mshot_cqe32(), or >>>> io_uring_mshot_cmd_post_cqe(), so they don't need to be polled. >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/5] io_uring: add REQ_F_IOPOLL >>> commit: 9165dc4fa969b64c2d4396ee4e1546a719978dd1 >>> [2/5] io_uring: remove iopoll_queue from struct io_issue_def >>> commit: 7995be40deb3ab8b5df7bdf0621f33aa546aefa7 >>> [3/5] io_uring: count CQEs in io_iopoll_check() >>> commit: 3a5e96d47f7ea37fb6adf37882eec1521f8ca75e >>> [4/5] io_uring/uring_cmd: allow non-iopoll cmds with IORING_SETUP_IOPOLL >>> commit: 23475637b0c47e5028817c9fd4dabe8f7409ca6c >>> [5/5] nvme: remove nvme_dev_uring_cmd() IO_URING_F_IOPOLL check >>> commit: f144dbac4b177cfd026e417ab98da518ff3372cb >> >> Caleb, want to send the liburing tests and documentation updates too? > > Sure. What type of file do you recommend using for non-iopoll > uring_cmds? Most of them seem to have relatively specific hardware > (e.g. blkdev_uring_cmd, nvme_dev_uring_cmd) or kernel configuration > (e.g. ublk_ch_uring_cmd, io_mock_cmd) requirements, as well as > requiring elevated permissions. Maybe io_uring_cmd_sock would be the > most general? Yep I think uring_cmd sock commands would be a good choice. Bonus points if you write the test as such that we can easily plug in future commands we allow with IOPOLL as well, as I would imagine we'd expand which we allow going forward once vetted. -- Jens Axboe