From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0C7396D1C for ; Mon, 13 Apr 2026 09:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776071481; cv=none; b=FUEL16cZi4gjD2ZWE3yzPrUNFM6GGLAGMozEUFpskQyFCqPomtU7UnCV8XecfM0GrxxhsFNGGRYZ7yp2T6uRiFRlJ7qVrexKiiMEI5xKHmoda4AECywnvIv0V9XVjRcGJOfcCWEW77PEp/7PmCHJO9NkHk3exsjTHMOVkjeuud0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776071481; c=relaxed/simple; bh=3WOw8s6Ohc5SZUfbw4vOwLhX9LZmHj7TUZSBFd+D2Ys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fgo7qvA88YY6KbRfktexDkMel653swvZ34k00auVl3Vsa2JxAEBKy10kM0g0O08uWaqFwiDAB1fSzr1xI1386GmUnfhk30CvNtWfPYCOjYgX9NOWVj+1yLA+fIpAnz6Xvt3MDlYkvIeraaFAwBdddFrQT4n2LEZcGovaLyzWGWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HjEtIRhY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FPPcigwz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HjEtIRhY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FPPcigwz" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D5Jinf3313194 for ; Mon, 13 Apr 2026 09:11:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OaJAwMwHvRhGyIQtZCdpx+5k+5RxYYbk83a3VG87hbY=; b=HjEtIRhYP7rvPQ3H 8kmsD+S3NpXHEKmiRoGkq2P5J1TOK1j4nJQIGDk9alGZihSnk0TSUh4+RgvkPl/F mwyCMMfprwotuxqqfAgbsCMvgXQ71nJ1S4CMwlWwCDafr+TGs05xvHlHdpIP1TxG 1p73aMShwFz5N6i7TvpnfYZreRiGVLTOLGb9bKaSynLkQXUvWPie2+Vy7gnp+haO IiMViMHpLSQRwH7mt9b9RihoZloPpS1+mmzAeuphUkpbaKVuZNOWZaE8wmCHfgDL v5Xc7qr9AdE2L2OABadIuVkxyBtoGDs/aeQoIaWePDqLCJ6UFwkqh5jDVuJ8tLX/ xDEC+g== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dfewkvnjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 09:11:19 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b9074bd42so11491361cf.0 for ; Mon, 13 Apr 2026 02:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776071479; x=1776676279; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OaJAwMwHvRhGyIQtZCdpx+5k+5RxYYbk83a3VG87hbY=; b=FPPcigwzdoY0unWKYgB9X43IK3v0DsRRuLD2tc7TzB/CdtyLyqOtf+wAC2kwpSYYsG voQnqRaTv7OprTWD5hyMKXccXRJxSeTu18Hb8weO0MqxJCNIWnuUhp8iNh50ygonmK/U FolCoV+033uDpJ/ez6dDXQ977diaabT+Eek2P3wOmrMJpkb677Z3pVoxHb8qPpfOH0v6 xRJFsTuFg1i5SMJ3HrmCDF7/MemV4bg+Egl2xqsf/TIKvR4eYk6J2T1sHxiRjmog4/O6 BivCFXfMu0L4kK44bS6I1mbU9So1gEeOEgUfUoM9QYVU+qM6HYtDJkecJyS8uvvgfFBc 17VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776071479; x=1776676279; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OaJAwMwHvRhGyIQtZCdpx+5k+5RxYYbk83a3VG87hbY=; b=sM59RRdI/RuxjEYn5K5WZDqtsXsQ2OLRhmTaWp4GNPerdgIolNjE3/xEL9VGB6NxZF jQzHiMykvD0Cye8EyCvnhpJjaNPgWHdZhIGsH09WozFzmFwDN3JrdiSDNZZFzGOcRuty EdN225+8vb/A1O3kVv5m7AK5/7IPBSjUchzsvkbKNqEqj0zlKXGNRrEgRH41v2g/AMj0 ZJreDU++x6XZuWGU0S7Exp3pXBLk7x9PGFHw7eOswGp2HLbooMIUnkgjPNGxtlMn5B/n 0ffE78ShZ5GHNN+6LWLFAz2pnlnLzuCNUJTxZT6JdvFNI3/Dtlc3Jb25QFSwclViQCCk x98A== X-Forwarded-Encrypted: i=1; AFNElJ/mqWxCQNpZsAa7e5kSBihkgXpZsd8DA3BZ4esRzIx11AcJg95+IHPw50zHmEGDK2yb1Bwo9LPHQFB/fBY=@vger.kernel.org X-Gm-Message-State: AOJu0YxjGo5QvgjlLBK4yIaq1RBR44d9xiuetGcDdQzj/jOD9poBU7Yr QXSug9UOC5XxwisrH+TFMeBOI6q4REo4lp3HtSLYWO/avtA/YlDm+tDZXypGXV1u0jZPdOtfK2a 7lh05B1nF39igFewNdGSSReN2ShNBpUn1PKcNqEZvAd8mjmRR/IRY/WYKePkGlb1imS8= X-Gm-Gg: AeBDietyfSwsDElUOjbOd6nDV9ofxTY8JruKoU3DQGee8lCRUBryOspdAYcjdS1l8sQ MovGBlaT0+RL733ZIYcbN7trBrNEc/yZo2b+KUZMXnVODFTwy2p60X/7Sz4Zs95T8MGaNLU23en pMi7J/w1pGh84IAo3TymQ4buxjVL/uawfDNQ/IFgIEmRpHTTjhLtzwLmYNfs+ErxFMYXQdc4kPi 4fw0Po/RQxeWR2y6efnlRN2RklVK1oQbEuX1bey5A0z83oArw01dW6masE/Z2nFCVoVvPTfIZhK /X4dkvLFEqU9g8J/XVmVt4aQ0e3d1Ud8AwBHZwdlzJclNLxHc6l00Uz6OCW6waqQId2YC+bK3J3 AU/aNoBFUYLAZy0b+4SNsKkvbVPQWfMl4O2B815nzjhs2m/llsUgHMKKABLu2y9LDQHIKhnjQQz lMHvw= X-Received: by 2002:a05:622a:5815:b0:50d:a92e:fead with SMTP id d75a77b69052e-50dd5bf0cf5mr130767521cf.3.1776071478684; Mon, 13 Apr 2026 02:11:18 -0700 (PDT) X-Received: by 2002:a05:622a:5815:b0:50d:a92e:fead with SMTP id d75a77b69052e-50dd5bf0cf5mr130767361cf.3.1776071478250; Mon, 13 Apr 2026 02:11:18 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e5c56dfsm302667366b.37.2026.04.13.02.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 02:11:17 -0700 (PDT) Message-ID: Date: Mon, 13 Apr 2026 11:11:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm6115-pro1x: Correct touchscreen GPIO flags To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dang Huynh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20260413090527.53000-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260413090527.53000-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bcFbluPB c=1 sm=1 tr=0 ts=69dcb337 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=p5SleGX6KkeDsG2sNWoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDA4OSBTYWx0ZWRfX6cwJlf8Mdig+ WOcyo96KL3ng/WZWLx28/1BWdC9Bsb4nWkNY4pkVqhvVtVuvx8wCD2eMhNiHS4vx0ocTW6Kz10o oii1wewTyYFJCqLxYGODpSE8MUCXVIq5KW2EjPS+if+TJf98rD8Mq8WQH/gS3+9ITyx9gYG2sFY uTcotHalEKLyNAy4aYsR7p27Rx3aKuHTuriRCUS8rozffqtFKl0Ap2V763NQ6SGAUlo31fmpT4d rymMigyNI1JGUomUjMhiiCP59HwZP9W0KkkSSJv+69eI3rZInI+eZIMZCy+Ntt0Gt7eUYK4oVGo 79+tjPeQkz/KYXP/JjTmee9/3EhV6YrncG/uiTPxW8yKVKrq//D4b3Ta09SlTla3ee53zEgkOwO GTtEYoBJxXjhgT+9UxiHoze+EAuluZ3CuZmdiuskHuRb1C1QOFt2ODLftD0Kpaglivgs3tY+cAx EHhWnFasOIONGDzwmfg== X-Proofpoint-ORIG-GUID: BI3O-c0tvqBhRPNiVi1WfkFDg_agOF0q X-Proofpoint-GUID: BI3O-c0tvqBhRPNiVi1WfkFDg_agOF0q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130089 On 4/13/26 11:05 AM, Krzysztof Kozlowski wrote: > IRQ_TYPE_xxx flags are not correct in the context of GPIO flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: IRQ_TYPE_LEVEL_LOW = 8 = GPIO_TRANSITORY. > > Correct the touchscreen irq-gpios to use proper flags, assuming the > author of the code wanted similar logical behavior: > > IRQ_TYPE_LEVEL_LOW => GPIO_ACTIVE_LOW > > Fixes: e46b455e67f8 ("arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad