From: Tom Talpey <tom@talpey.com>
To: Namjae Jeon <linkinjeon@kernel.org>, Wang Ming <machel@vivo.com>
Cc: Steve French <sfrench@samba.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero
Date: Tue, 4 Jul 2023 09:58:22 -0400 [thread overview]
Message-ID: <d5fbf1cc-9b79-5fbb-a109-87679caffcc4@talpey.com> (raw)
In-Reply-To: <CAKYAXd85gpb2xzPEm8BJV6gsff3p-8b4Aj_rOaEvU=+n43SgBQ@mail.gmail.com>
On 7/4/2023 4:58 AM, Namjae Jeon wrote:
> 2023-07-04 16:40 GMT+09:00, Wang Ming <machel@vivo.com>:
>> The return value of the ksmbd_vfs_getcasexattr() is signed.
>> However, the return value is being assigned to an unsigned
>> variable and subsequently recasted, causing warnings. Use
>> a signed type.
>>
>> Signed-off-by: Wang Ming <machel@vivo.com>
> Acked-by: Namjae Jeon <linkinjeon@kernel.org>
>
> Thanks for your patch!
>
FYI, this is missing my previous Acked-by. The updated changelog
otherwise looks good.
Tom.
next prev parent reply other threads:[~2023-07-04 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 7:40 Wang Ming
2023-07-04 8:58 ` Namjae Jeon
2023-07-04 13:58 ` Tom Talpey [this message]
2023-07-09 0:40 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2023-07-01 5:55 Wang Ming
2023-07-01 14:43 ` Tom Talpey
2023-07-02 12:51 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5fbf1cc-9b79-5fbb-a109-87679caffcc4@talpey.com \
--to=tom@talpey.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®