From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515AAC433E6 for ; Mon, 1 Mar 2021 08:01:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15DDC64E04 for ; Mon, 1 Mar 2021 08:01:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232684AbhCAIBp (ORCPT ); Mon, 1 Mar 2021 03:01:45 -0500 Received: from foss.arm.com ([217.140.110.172]:52324 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232620AbhCAIBd (ORCPT ); Mon, 1 Mar 2021 03:01:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1E031063; Mon, 1 Mar 2021 00:00:36 -0800 (PST) Received: from [10.163.67.14] (unknown [10.163.67.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 17F0A3F70D; Mon, 1 Mar 2021 00:00:33 -0800 (PST) Subject: Re: [PATCH] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE To: Christoph Hellwig Cc: linux-mm@kvack.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1614577853-7452-1-git-send-email-anshuman.khandual@arm.com> <20210301062358.GA25761@lst.de> <89f2d77c-f4bc-8f7b-a6b0-1c04e422fb77@arm.com> <20210301075352.GA27659@lst.de> From: Anshuman Khandual Message-ID: Date: Mon, 1 Mar 2021 13:31:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210301075352.GA27659@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/21 1:23 PM, Christoph Hellwig wrote: > On Mon, Mar 01, 2021 at 01:13:41PM +0530, Anshuman Khandual wrote: >>> doesn't this need a 'if HUGETLB_PAGE' >> >> While making HUGETLB_PAGE_SIZE_VARIABLE a generic option, also made it >> dependent on HUGETLB_PAGE. Should not that gate HUGETLB_PAGE_SIZE_VARIABLE >> when HUGETLB_PAGE is not available irrespective of the select statement on >> the platforms ? > > depends doesn't properly work for variables that are selected. > Alright, will move the HUGETLB_PAGE dependency to platforms while selecting the variable HUGETLB_PAGE_SIZE_VARIABLE.