From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7492148FE6 for ; Sat, 22 Nov 2025 13:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763818669; cv=none; b=UHo8DRK9IH67ULMlStAjd+w24VyA6ES3DWxtpnVoub504ijUHMv5xDVJd9tB1GdfC/VIHc32g0rHMqLpHvYTy47Q7igzFrOYvDLRuI+AgU7ktMYet0bB2sFychvNBY8L8qsawne8vVrEGmIpspI3Tf8qDWZQC5v/GD+bBbS9n0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763818669; c=relaxed/simple; bh=u6BauhfFyOUtj6qYbL0c4k+4saAV/sEZnEnpWETEeu0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iV6kXBW3OLHsWuFlHDpkBbyeOmz2Fy6UaCt9HT8nTW3AcsnHG40GjCq3cvj+Umbz7J/6JX0ZTLVuO+IR9vB+q/63/hCnAYovN/azne/EjqEgPD1biEjfmrFnzx8kkT8LOl0GThyGras9o64MAZ5psotPL4BVgT3efvg9cJXwsZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eqVWyPrd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YPn6Npuu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eqVWyPrd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YPn6Npuu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AMCcV8w2730071 for ; Sat, 22 Nov 2025 13:37:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vpKlju2borCnF5T0A8CLiJv8yDluVEw4QY6DSS08xXM=; b=eqVWyPrdXhpla72C qS95Kdp6woviucvBADPP34opafepdhEddkKNmJc2d0ux66f667lXwuzlWJ+dngqe liLCtdnGHLmgTVYLK50AUzkNjQQ3pxGxT3mlLQFGCgkU3huC59hoAsVDJFAwmA2I VA4825HrQC4Rbj5nU5OhbxishIzOQL6on9EcspqMAeqFWnBnareB3dEruG0XWmvQ 0kKF+mPiobsobSayMKYTYvPWTZn6xb8dTT/LT+B2X5NMRyaFzz/sk23pa7vxyhFH 50rHMSdhOSB+1d3UVAy7SiSU02pgJh9MECVbcrI5mQ1s/hfSQuPWUE58wa5OO0sm +1jL2A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak691gr2s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Nov 2025 13:37:46 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ede0bd2154so9140921cf.1 for ; Sat, 22 Nov 2025 05:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763818666; x=1764423466; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vpKlju2borCnF5T0A8CLiJv8yDluVEw4QY6DSS08xXM=; b=YPn6NpuuuE07XrI1vYldEGrcN81RQ/n38otfbZlfhO05VD7/78ATNMGfOTWboYpMki rFqcDMCn+7FkECSFigGEMvAtwJ664V9524gofp/FuD64jfFotJxTK2xGGu6DDgFsTnnP AJqdFyc4iMoy8XJtvj7ofKoxNI4BJqhi1QzUxNvMqg0mY3WsCxEhN1PGfJeX0I27XyOi WMjVfkE4aaGp3P5ysjEYeZNYNmZz4biRshamKMEORJfb0HofyQvWHUyIpyEXVLw3abhb ui8oaRac4uJfv+xaCkt6Z1Fltsu7SKQ/a0oc6g6P5PnMStdPEdciqw84jVnsSf1xKiGV UbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763818666; x=1764423466; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vpKlju2borCnF5T0A8CLiJv8yDluVEw4QY6DSS08xXM=; b=QWPUUF/oZ5LKszbASveUH6YW+zC5Zt5lYjri3fDiPfcwhBG6jQVPFLw51Dx8/m10Lo pxnqUgxhhDgzZ2RbMyf71hxECAKFoULu0GgeA2HcaRkNCOXLIrHdBfs/TK2PvNZi9oiY xkHpdzCGlPPQcLtq5HF+i5/t5SIPR93OgerouHDOL5jbRYkNgRi6xiPeclPwxkAp9ihQ IuSL8eoDT9kDUTYYgJI5RjqHpi81n8Tlw8TGjpXOK7IW2LwB6+mx/fu0igsz9bYJ2zVB uDJOINLcUHjSH2uxpfy3DAorFzGgDoLu22aWwaQinqM/SWMUPsAB0ewUONlXsBu9CVB2 BIEA== X-Forwarded-Encrypted: i=1; AJvYcCXAh1t4N9bhGlrxRjcwYHKhv/nHuTimqPLnIwna6oWG2Tctp54sMSUI3nwZsDgQDhqp7KyZwhkAK5jwPO0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzh3gZrN0sRCHq0ykj2vB0pAziehMmqhchjw78OYP49i59OqcoS QKGzMCgoo+bhWW0saBYkgKqtK2ED5AuS2HIWtmczkPFP9F+KmS7RAVq6Lfr8INRXXgviT4r8OF/ UD7mz+KgJwS6PbYljGeX3gptJ3Ql88+C94gdj1KE86hcPBkHPipw+mUIsCcrlyX1cDFQ= X-Gm-Gg: ASbGncuqKlGTa2jPMlKE3ywhRNheChVQs6RyZtUVEkID4MAa0VfbMcG7tvtdsiVYas4 VFJbA49cvjmCKKikKO853HMXp0JWjviP+8mOmEyJxT6qoHK2UCI6w6oaUp2EVwSABt5UkfebujM +EmbhE4OD6MMXL/n5d3+NtkiCidtK9b1WHm/A/o1jmCYG+zYS9apGkou1PYo2rrj1didfXStwRD XhFRBcm0d8B+gS9z2b+lHztgDSBs0LeC1ytCuZ4efBG1e10pMzndCUpNkNS4zaRYxnUxfTcCrk6 GAXILn9M1w4ysIEkIRHgyN6nYu08zubj74KcuQjEdX+vZ2ImQ70z6CgBEgHlltLvEyL1Bn5QTRg cLK8v/kFOMYUGwCge8/u0/SLA5MrOq3yByBN5UEm17xK2LS8qua5r29rxzT2X3StPH94= X-Received: by 2002:a05:622a:c3:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee5883ae04mr61120461cf.2.1763818666109; Sat, 22 Nov 2025 05:37:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoep6nfGiw+VpxZkfaKHeCgO/XxMbNv1FNgkeFxXOdBWbxoTvU1FtSK/h2lVrS77kwEGBxsA== X-Received: by 2002:a05:622a:c3:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee5883ae04mr61120141cf.2.1763818665629; Sat, 22 Nov 2025 05:37:45 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654cdabd0sm718995766b.12.2025.11.22.05.37.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Nov 2025 05:37:45 -0800 (PST) Message-ID: Date: Sat, 22 Nov 2025 14:37:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: x1e80100-vivobook-s15: add charge limit nvmem To: Maud Spierings , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20251116-asus_usbc_dp-v2-0-cc8f51136c9f@hotmail.com> <20251116-asus_usbc_dp-v2-5-cc8f51136c9f@hotmail.com> <378c611b-f8c6-4f89-a3b3-6d8c22445e83@oss.qualcomm.com> <57bab427-d8fd-490d-88f6-358b79367ed1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Be3VE7t2 c=1 sm=1 tr=0 ts=6921bcaa cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=69EAbJreAAAA:8 a=Ufo_hXmgmYuxYTG_NCgA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: T2maQPgV8xzojtmCFtcvAEyfr1ci72N2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDExMSBTYWx0ZWRfXxf4ay8F/AtSB rb742xEd5VtAQc3twxWHQMbDGRUUdc87g9wP3hVUyONm9pUGxmkLy7yjallvXm4Nb6J18FvoO4I k704DSNjZJ2JeFTrWoNhcjh9mT0tbnPZ8uiIK6S9/A/YfK/dQ6Xw38XNyksVaOaoJNjOh5Ki6XC 84hWnFZHQhU6bHFKBNHe7p/tOqKpOy5CtZhjPOgKKk3mVvE3njZAiJrldIfbsjqVZIYu0rZJG2P 9YcBx3JGK2WUlpHompgV8DcZuke2aHSf74w+mJcTuhJ3cD/xAyA5y/TB7Yz59oYMV0ijz4u4Pa/ 8copg7158cgBHs84wTOM3h0T4P3o9XMehE4IvuQgNgWvIFkGJ76u3sLXSVBnSoNCm1QXHFKBZWU 3zQ8+25y+i5AZBhR6KTjWGRXOdNKbw== X-Proofpoint-GUID: T2maQPgV8xzojtmCFtcvAEyfr1ci72N2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-22_05,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220111 On 11/22/25 12:07 PM, Maud Spierings wrote: > On 11/20/25 16:36, Konrad Dybcio wrote: >> On 11/17/25 4:44 PM, Maud Spierings wrote: >>> On 11/17/25 16:35, Konrad Dybcio wrote: >>>> On 11/17/25 3:13 PM, Maud Spierings wrote: >>>>> Hi Konrad, >>>>> >>>>> On 11/17/25 13:59, Konrad Dybcio wrote: >>>>>> On 11/16/25 11:52 AM, Maud Spierings via B4 Relay wrote: >>>>>>> From: Maud Spierings >>>>>>> >>>>>>> Add nvmem cells for getting charge control thresholds if they have >>>>>>> been set previously. >>>>>>> >>>>>>> Signed-off-by: Maud Spierings >>>>>>> --- >>>>>> Have you verified that e.g. >>>>>> >>>>>> connecting the charger >>>>>> setting the charge threshold >>>>>> rebooting to windows >>>>>> rebooting to windows once more for good measure >>>>>> rebooting to linux >>>>>> >>>>>> still has the settings persist? >>>>> Hmm I have tried several things but I can't seem to get the values to stick. I the spmi-sdam driver is compiled in, I am not quite sure if I might be missing something. >>>> Hm, I wonder if Windows/UEFI overwrites these values or whether they're >>>> used by something else.. >>>> >>>> Can you set a threshold in windows and see if Linux can read back that >>>> data? >>> the values in /sys/class/power_supply/jada-jada/ are zero when rebooting from Windows into Linux after enabling charge limitting in the Asus application. >>> >>> I remember my old vivobook (x86) also forgot its settings each boot, but given the nvmem cells that should not be happing here I guess. It is odd that there seems to be no collision between Windows and Linux. Maybe the Windows mechanism is doing the old trick of writing it in there every boot? >> Odd indeed.. Does it work if you reboot from Linux to Linux? > It seems not, I seem to remember testing it quite some time ago, but I cannot get it to remember any way, at least it is not popping up in sysfs, always back to 0 It seems like the driver currently only populates the sysfs start/stop values if the "enable" bit is set Could you check this (hacky and wrong) diff and give it another try? diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c index c8028606bba0..9ebd8adfb8eb 100644 --- a/drivers/power/supply/qcom_battmgr.c +++ b/drivers/power/supply/qcom_battmgr.c @@ -733,7 +733,7 @@ static int qcom_battmgr_charge_control_thresholds_init(struct qcom_battmgr *batt u8 en, end_soc, start_soc, delta_soc; ret = nvmem_cell_read_u8(battmgr->dev->parent, "charge_limit_en", &en); - if (!ret && en != 0) { + if (!ret) { ret = nvmem_cell_read_u8(battmgr->dev->parent, "charge_limit_end", &end_soc); if (ret < 0) return ret; Konrad