From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbcI0ITM (ORCPT ); Tue, 27 Sep 2016 04:19:12 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51681 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680AbcI0ITJ (ORCPT ); Tue, 27 Sep 2016 04:19:09 -0400 Subject: Re: [PATCH] video: fbdev: constify fb_fix_screeninfo and fb_var_screeninfo structures To: Julia Lawall References: <1473607040-21295-1-git-send-email-Julia.Lawall@lip6.fr> CC: , Benjamin Herrenschmidt , Teddy Wang , Sudip Mukherjee , Kristoffer Ericson , Michal Januszewski , , , Jean-Christophe Plagniol-Villard , Hans de Goede , Jaya Kumar , Paul Mackerras , Ferenc Bakonyi , , Antonino Daplas From: Tomi Valkeinen Message-ID: Date: Tue, 27 Sep 2016 11:17:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1473607040-21295-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JI5haVODTXRJMj6h1s1STULaeV5qRgtNO" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JI5haVODTXRJMj6h1s1STULaeV5qRgtNO Content-Type: multipart/mixed; boundary="MKiAMwPtL29BQ0TKTkAa7DWE2uxwj73wx"; protected-headers="v1" From: Tomi Valkeinen To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Benjamin Herrenschmidt , Teddy Wang , Sudip Mukherjee , Kristoffer Ericson , Michal Januszewski , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Hans de Goede , Jaya Kumar , Paul Mackerras , Ferenc Bakonyi , linux-nvidia@lists.surfsouth.com, Antonino Daplas Message-ID: Subject: Re: [PATCH] video: fbdev: constify fb_fix_screeninfo and fb_var_screeninfo structures References: <1473607040-21295-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1473607040-21295-1-git-send-email-Julia.Lawall@lip6.fr> --MKiAMwPtL29BQ0TKTkAa7DWE2uxwj73wx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/09/16 18:17, Julia Lawall wrote: > These structures are only used to copy into other structures, so declar= e > them as const. >=20 > The semantic patch that makes this change in the fb_fix_screeninfo case= is > as follows (http://coccinelle.lip6.fr/). The fb_var_screeninfo case is= > analogous. >=20 > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct fb_fix_screeninfo i@p =3D { ... }; >=20 > @ok@ > identifier r.i; > expression e; > position p; > @@ > e =3D i@p >=20 > @bad@ > position p !=3D {r.p,ok.p}; > identifier r.i; > struct fb_fix_screeninfo e; > @@ > e@i@p >=20 > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct fb_fix_screeninfo i =3D { ... }; > // >=20 > Signed-off-by: Julia Lawall >=20 > --- > drivers/video/fbdev/arcfb.c | 4 ++-- > drivers/video/fbdev/asiliantfb.c | 4 ++-- > drivers/video/fbdev/aty/aty128fb.c | 6 +++--- > drivers/video/fbdev/aty/atyfb_base.c | 2 +- > drivers/video/fbdev/aty/radeon_monitor.c | 2 +- > drivers/video/fbdev/hecubafb.c | 4 ++-- > drivers/video/fbdev/hgafb.c | 2 +- > drivers/video/fbdev/i740fb.c | 2 +- > drivers/video/fbdev/kyro/fbdev.c | 2 +- > drivers/video/fbdev/pm2fb.c | 2 +- > drivers/video/fbdev/s1d13xxxfb.c | 2 +- > drivers/video/fbdev/savage/savagefb_driver.c | 2 +- > drivers/video/fbdev/simplefb.c | 4 ++-- > drivers/video/fbdev/sm712fb.c | 2 +- > drivers/video/fbdev/ssd1307fb.c | 4 ++-- > drivers/video/fbdev/tdfxfb.c | 4 ++-- > drivers/video/fbdev/uvesafb.c | 2 +- > drivers/video/fbdev/vfb.c | 2 +- > drivers/video/fbdev/vga16fb.c | 2 +- > 19 files changed, 27 insertions(+), 27 deletions(-) Thanks, queued for 4.9. There was a minor conflict in vfb.c, I resolved that. Tomi --MKiAMwPtL29BQ0TKTkAa7DWE2uxwj73wx-- --JI5haVODTXRJMj6h1s1STULaeV5qRgtNO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6isyAAoJEPo9qoy8lh71xGQP/0J5lZO8CWvf3olLMdh1zjTy CP5Q9REOlq6k2ADKE+/vhpHzmhKigxH+s2KorZLlbqCheqXEyuMjzL2e2SBsL9P/ D58rd06+htOvOV80pAy61kEFucjJem5WCoY8mczuaf9J/G6sq5WQPMdra4WnjSdF PH4rD9oP2WEAHIR6szjhZq2ltopPWpZ8aHb1IRiySpNi18kgE094yqcD+nJgn3iF sycIKV8eA4796vzGR6xY4WqZPnlRZbnG8fN6FwBayJeII9C8k1sDk+159Z57CcdW /kmw5/Ap1qQxQE9lOInAy8KLBQk74xddl+fHLz+l9Wz2CMgUhtawesAW2+u3kXlQ M48fJiu+xwa9I3tIcJnUlRyaAKhtdD1fn76CGHk+e3wwBwWLYhb3N5qkJU/RRIAx OcCnKmvUh4oCB+KpowMFr+OafbdOpQarw39PdymO4Esja5oYG799X39VQibnB+p3 BsxVZe0Twl4OnE5vmNkATLaTB4Kj3BTzAx6BL2CJnQL6oP/caL1y1bLlgA8xJaZv qpy3NeumRKuHSOoZqGOwx87otMw3m19WAawXk07anbKTYniBlBVGiUK6p6s7OSqo X9EbKJhvEjnvZsbWML8WpqJRzKIQd+E1S1w4tnDca4aCQ91EMe3lWsXJPmiAJTHZ KLQZyp5m4dF93cjNrdB5 =x4wK -----END PGP SIGNATURE----- --JI5haVODTXRJMj6h1s1STULaeV5qRgtNO--