From: Tasos Sahanidis <tasos@tasossah.com>
To: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] ring-buffer: Fix persistent buffer when commit page is the reader page
Date: Wed, 14 May 2025 09:20:12 +0300 [thread overview]
Message-ID: <d60729c2-9fb4-4fa7-9e4b-070127d8943e@tasossah.com> (raw)
In-Reply-To: <20250513115032.3e0b97f7@gandalf.local.home>
On 2025-05-13 18:50, Steven Rostedt wrote:
> To trigger this bug:
>
> # echo 1 > /sys/kernel/tracing/instances/boot_mapped/events/syscalls/sys_enter_fchownat/enable
> # touch /tmp/x
> # chown sshd /tmp/x
> # reboot
>
> On boot up, the dmesg will have:
> Ring buffer meta [0] is from previous boot!
> Ring buffer meta [1] is from previous boot!
> Ring buffer meta [2] is from previous boot!
> Ring buffer meta [3] is from previous boot!
> Ring buffer meta [4] commit page not found
> Ring buffer meta [5] is from previous boot!
> Ring buffer meta [6] is from previous boot!
> Ring buffer meta [7] is from previous boot!
>
> Where the buffer on CPU 4 had a "commit page not found" error and that
> buffer is cleared and reset causing the output to be empty and the data lost.
>
> When it works correctly, it has:
>
> # cat /sys/kernel/tracing/instances/boot_mapped/trace_pipe
> <...>-1137 [004] ..... 998.205323: sys_enter_fchownat: __syscall_nr=0x104 (260) dfd=0xffffff9c (4294967196) filename=(0xffffc90000a0002c) user=0x3e8 (1000) group=0xffffffff (4294967295) flag=0x0 (0
>
Tested-by: Tasos Sahanidis <tasos@tasossah.com>
Patch resolves the issue on my end. Cheers!
next prev parent reply other threads:[~2025-05-14 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 15:50 Steven Rostedt
2025-05-14 6:20 ` Tasos Sahanidis [this message]
2025-05-14 13:01 ` Steven Rostedt
2025-05-14 6:52 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d60729c2-9fb4-4fa7-9e4b-070127d8943e@tasossah.com \
--to=tasos@tasossah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®