From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/6] regulator: qcom_spmi: Add support for PMP8074 regulators
Date: Wed, 18 May 2022 15:42:44 +0200 [thread overview]
Message-ID: <d60f32dc-a9f5-95ad-245e-6b9521d73fce@somainline.org> (raw)
In-Reply-To: <20220517205341.536587-4-robimarko@gmail.com>
On 17/05/2022 22:53, Robert Marko wrote:
> PMP8074 is a companion PMIC for the Qualcomm IPQ8074 WiSoC-s.
>
> It features 5 HF-SMPS and 13 LDO regulators.
>
> This commit adds support for S3 and S4 HF-SMPS buck regulators of
> the HFS430 type and LDO11 of the HT_P150 type.
> S3 is the CPU cluster voltage supply, S4 supplies the UBI32 NPU cores
> and LDO11 is the SDIO/eMMC I/O voltage regulator required for high speeds.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/regulator/qcom_spmi-regulator.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 38bbc70241ae..696b088aae40 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -2137,6 +2137,13 @@ static const struct spmi_regulator_data pms405_regulators[] = {
> { }
> };
>
> +static const struct spmi_regulator_data pmp8074_regulators[] = {
Please sort the struct alphabletically.
> + { "s3", 0x1a00, "vdd_s3"},
> + { "s4", 0x1d00, "vdd_s4"},
> + { "l11", 0x4a00, "vdd_l10_l11_l12_l13"},
Are the other regulators somehow not controllable through SPMI? Please
leave a comment if that's the case.
> + { }
> +};
> +
> static const struct of_device_id qcom_spmi_regulator_match[] = {
> { .compatible = "qcom,pm8004-regulators", .data = &pm8004_regulators },
> { .compatible = "qcom,pm8005-regulators", .data = &pm8005_regulators },
> @@ -2150,6 +2157,7 @@ static const struct of_device_id qcom_spmi_regulator_match[] = {
> { .compatible = "qcom,pm660-regulators", .data = &pm660_regulators },
> { .compatible = "qcom,pm660l-regulators", .data = &pm660l_regulators },
> { .compatible = "qcom,pms405-regulators", .data = &pms405_regulators },
> + { .compatible = "qcom,pmp8074-regulators", .data = &pmp8074_regulators },
Please sort the compatible too.
Konrad
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_spmi_regulator_match);
>
next prev parent reply other threads:[~2022-05-18 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 20:53 [PATCH v3 1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema Robert Marko
2022-05-17 20:53 ` [PATCH v3 2/6] regulator: qcom_spmi: add support for HT_P150 Robert Marko
2022-05-17 20:53 ` [PATCH v3 3/6] dt-bindings: regulator: qcom,spmi-regulator: add PMP8074 PMIC Robert Marko
2022-05-18 13:10 ` Krzysztof Kozlowski
2022-05-17 20:53 ` [PATCH v3 4/6] regulator: qcom_spmi: Add support for PMP8074 regulators Robert Marko
2022-05-18 13:42 ` Konrad Dybcio [this message]
2022-05-18 17:31 ` Robert Marko
2022-05-18 18:25 ` Robert Marko
2022-05-17 20:53 ` [PATCH v3 5/6] arm64: dts: ipq8074: add SPMI PMP8074 PMIC regulators Robert Marko
2022-05-18 13:40 ` Konrad Dybcio
2022-05-17 20:53 ` [PATCH v3 6/6] arm64: dts: ipq8074: add VQMMC supply Robert Marko
2022-05-18 12:58 ` [PATCH v3 1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema Krzysztof Kozlowski
2022-05-18 13:25 ` Robert Marko
2022-05-18 13:34 ` Krzysztof Kozlowski
2022-05-18 14:00 ` Robert Marko
2022-05-18 14:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d60f32dc-a9f5-95ad-245e-6b9521d73fce@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®