From: Timo Alho <talho@nvidia.com>
To: Jonathan Hunter <jonathanh@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] firmware: tegra: add BPMP debugfs support
Date: Tue, 3 Oct 2017 14:21:56 +0300 [thread overview]
Message-ID: <d614ffff-880f-aa2e-ee23-17edef78c3c8@nvidia.com> (raw)
In-Reply-To: <7fecddd5-f676-83b9-5e6e-6b3cd652e947@nvidia.com>
Jon, thanks for reviewing
On 03.10.2017 13:55, Jonathan Hunter wrote:
>> +static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
>> + size_t bufsize, struct dentry *root)
>> +{
>> + struct seqbuf seqbuf;
>> + int err;
>> +
>> + bpmp->debugfs_mirror = debugfs_create_dir("debug", root);
>> + if (!bpmp->debugfs_mirror)
>> + return -ENOMEM;
>
> Is this extra level needed? Do you plan to have other sub-directories
> under the main bpmp directory?
Yes, the downstream driver has few files under main directory (e.g.
'ping' to check that firmware is alive, or 'tag' to read the firmware
version).
BR,
Timo
next prev parent reply other threads:[~2017-10-03 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 6:12 Timo Alho
2017-10-03 10:55 ` Jon Hunter
2017-10-03 11:21 ` Timo Alho [this message]
2017-10-17 10:44 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d614ffff-880f-aa2e-ee23-17edef78c3c8@nvidia.com \
--to=talho@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome