From: Jonathan Marek <jonathan@marek.ca>
To: Liviu Nicoara <lnicoara@thinkoid.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Johan Hovold <johan@kernel.org>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: lpass-wsa-macro: rewrite the interpolator volume after enabling clocks
Date: Thu, 24 Sep 2026 16:52:42 -0400 [thread overview]
Message-ID: <d617c7b0-e6e3-bcc0-7ea9-5b955bc367bf@marek.ca> (raw)
In-Reply-To: <CAAhq3a6OV6+Z0p=qVqpUiL-QoP92fYTsf5MBQL-f2oedddW=Dg@mail.gmail.com>
On 9/24/26 3:52 PM, Liviu Nicoara wrote:> However, on my unpatched
driver an idle volume change did not take place
> when playback starts (changed it from 69 to 81 and it played at 69). A
> change done during playback though, takes effect at once. I don't think
> anything writes the register in between.
in this case, while its playing with the wrong volume, use /dev/mem to
directly read the value of the volume register and then write the same
value, if that fixes the volume from 69 to 81, then this patch might be
necessary, otherwise its papering over the issue like I wrote
next prev parent reply other threads:[~2026-09-24 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 12:59 Liviu Nicoara
2026-09-24 18:57 ` Jonathan Marek
2026-09-24 19:52 ` Liviu Nicoara
2026-09-24 20:52 ` Jonathan Marek [this message]
2026-09-24 22:13 ` Liviu Nicoara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d617c7b0-e6e3-bcc0-7ea9-5b955bc367bf@marek.ca \
--to=jonathan@marek.ca \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lnicoara@thinkoid.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®