From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbZBWWob (ORCPT ); Mon, 23 Feb 2009 17:44:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757135AbZBWWoU (ORCPT ); Mon, 23 Feb 2009 17:44:20 -0500 Received: from el-out-1112.google.com ([209.85.162.178]:32908 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755092AbZBWWoT convert rfc822-to-8bit (ORCPT ); Mon, 23 Feb 2009 17:44:19 -0500 MIME-Version: 1.0 In-Reply-To: <200902232323.25583.rjw@sisk.pl> References: <200902221837.49396.rjw@sisk.pl> <200902221839.50357.rjw@sisk.pl> <200902232323.25583.rjw@sisk.pl> Date: Mon, 23 Feb 2009 14:44:17 -0800 Message-ID: Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: LKML , Linus Torvalds , Ingo Molnar , "Eric W. Biederman" , Benjamin Herrenschmidt , Jeremy Fitzhardinge , pm list , Len Brown , Jesse Barnes , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 23, 2009 at 2:23 PM, Rafael J. Wysocki wrote: > On Monday 23 February 2009, Arve Hjønnevåg wrote: >> On Sun, Feb 22, 2009 at 9:39 AM, Rafael J. Wysocki wrote: >> > From: Rafael J. Wysocki >> > >> > Introduce two helper functions allowing us to disable device >> > interrupts (at the IO-APIC level) during suspend or hibernation >> > and enable them during the subsequent resume, respectively, so that >> > the timer interrupts are enabled while "late" suspend callbacks and >> > "early" resume callbacks provided by device drivers are being >> > executed. >> > >> > Use these functions to rework the handling of interrupts during >> > suspend (hibernation) and resume. Namely, interrupts will only be >> > disabled on the CPU right before suspending sysdevs, while device >> > interrupts will be disabled (at the IO-APIC level), with the help of >> > the new helper function, before calling "late" suspend callbacks >> > provided by device drivers and analogously during resume. >> > >> >> What impact does this have on wakeup interrupts? Unless you add a >> check, after masking all interrupt at the CPU, to abort suspend if any >> wakeup interrupt has IRQ_PENDING set I think you will loose wakeup >> interrupts (at least for irqs that use default_disable). > > I _think_ they would have to be reenabled after we've called > local_irq_disable(). Are you talking about the irq_chip switching from enabled interrupts to wake interrupts? It is not enough for the irq_chip to reenable the hardware interrupt. If the interrupt is edge triggered and occurred after you disabled it, but before local_irq_disable, the only record of it is the IRQ_PENDING flag. -- Arve Hjønnevåg