From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758793AbZBZUek (ORCPT ); Thu, 26 Feb 2009 15:34:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754214AbZBZUe2 (ORCPT ); Thu, 26 Feb 2009 15:34:28 -0500 Received: from mail-gx0-f174.google.com ([209.85.217.174]:64244 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754934AbZBZUe1 convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2009 15:34:27 -0500 MIME-Version: 1.0 In-Reply-To: <200902261050.50531.rjw@sisk.pl> References: <200902221837.49396.rjw@sisk.pl> <200902250029.16107.rjw@sisk.pl> <200902261050.50531.rjw@sisk.pl> Date: Thu, 26 Feb 2009 12:34:25 -0800 Message-ID: Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: Ingo Molnar , Linus Torvalds , "Eric W. Biederman" , LKML , Benjamin Herrenschmidt , Jeremy Fitzhardinge , pm list , Len Brown , Jesse Barnes , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2009 at 1:50 AM, Rafael J. Wysocki wrote: > On Thursday 26 February 2009, Arve Hjønnevåg wrote: >> On Tue, Feb 24, 2009 at 3:29 PM, Rafael J. Wysocki wrote: >> > BTW, appended is the current (3rd) version of the $subject patch with some >> > of your comments taken into account.  In particular, I did the following: >> > - moved [suspend|resume]_device_irqs() to a separate file (pm.c) >> > - fixed interrupt.h so that their headers are at a better place >> > - made enable_irq() clear IRQ_SUSPENDED >> > - made device_power_down() and device_power_up() call >> >  suspend_device_irqs() and resume_device_irqs(), respectively, which >> >  simplified the callers quite a bit (it changed the Xen code ordering, though, >> >  but I _think_ it still should work). >> >> Do you plan to fix edge triggered wakeup interrupts? It still looks >> like edge triggered wakeup interrupts that occur between >> suspend_device_irqs and local_irq_disable will not cause a wakeup. > > In the current version of the patch the interrupts that have IRQ_WAKEUP set > in status are not disabled.  Is this not enough? That is enough for drivers that use wakelocks to abort suspend (if I fix the wakelock code to not use a platform device as its last abort point). It is not enough if you don't have wakelocks, since the interrupt can occur after suspend_late has been called and the driver has no way to abort suspend. -- Arve Hjønnevåg