From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761367AbZB0WJZ (ORCPT ); Fri, 27 Feb 2009 17:09:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758216AbZB0WJR (ORCPT ); Fri, 27 Feb 2009 17:09:17 -0500 Received: from mail-gx0-f174.google.com ([209.85.217.174]:39793 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755697AbZB0WJQ convert rfc822-to-8bit (ORCPT ); Fri, 27 Feb 2009 17:09:16 -0500 MIME-Version: 1.0 In-Reply-To: <200902272154.03539.rjw@sisk.pl> References: <200902192215.18365.rjw@sisk.pl> <200902271522.41915.rjw@sisk.pl> <20090227142946.GA13650@srcf.ucam.org> <200902272154.03539.rjw@sisk.pl> Date: Fri, 27 Feb 2009 14:09:12 -0800 Message-ID: Subject: Re: [RFD] Automatic suspend From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: Matthew Garrett , Pavel Machek , Alan Stern , "Woodruff, Richard" , Arjan van de Ven , Kyle Moffett , Oliver Neukum , Benjamin Herrenschmidt , pm list , LKML , Nigel Cunningham , mark gross , Uli Luckas , Igor Stoppa , Brian Swetland , Len Brown Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 27, 2009 at 12:54 PM, Rafael J. Wysocki wrote: > On Friday 27 February 2009, Matthew Garrett wrote: >> On Fri, Feb 27, 2009 at 03:22:39PM +0100, Rafael J. Wysocki wrote: >> > On Friday 27 February 2009, Pavel Machek wrote: >> > > Wakelocks done right are single atomic_t... and if you set it to 0, >> > > you just unblock "sleeper" thread or something. Zero polling and very >> > > simple... >> > >> > Except that you have to check all of the wakelocks periodically in a loop => >> > polling.  So? >> >> Why do you need to check them? If you're taking this approach you just >> have something like: >> >> suspend_unblock() { >>       if (atomc_dec_and_test(&suspend_lock)) >>               suspend(); >> } >> >> and then check that the lock count is still 0 after device_suspend(). >> There's no need to poll. > > I was talking about wakelocks as originally proposed. Can you be more specific? My wakelock implementation triggers suspend when the active list becomes empty. No polling required. -- Arve Hjønnevåg