From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761106AbZEGBSd (ORCPT ); Wed, 6 May 2009 21:18:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753884AbZEGBSY (ORCPT ); Wed, 6 May 2009 21:18:24 -0400 Received: from wf-out-1314.google.com ([209.85.200.172]:10167 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753358AbZEGBSX convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2009 21:18:23 -0400 MIME-Version: 1.0 In-Reply-To: <87zldpu5rt.fsf@deeprootsystems.com> References: <1241483224-7113-1-git-send-email-khilman@deeprootsystems.com> <87y6tb3x6r.fsf@deeprootsystems.com> <871vr22upr.fsf@deeprootsystems.com> <200905062318.23572.rjw@sisk.pl> <87zldpu5rt.fsf@deeprootsystems.com> Date: Wed, 6 May 2009 18:18:23 -0700 Message-ID: Subject: Re: [PATCH] PM: suspend_device_irqs(): don't disable wakeup IRQs From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Kevin Hilman Cc: "Rafael J. Wysocki" , Andrew Morton , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 6, 2009 at 5:16 PM, Kevin Hilman wrote: > "Rafael J. Wysocki" writes: > >> On Wednesday 06 May 2009, Kevin Hilman wrote: >>> Kevin Hilman writes: > There is at least one problem with that which is why Kyuwon Kim added > the ->disable hook to OMAP's irq_chip.  The problem is with drivers > that call disable_irq() in their suspend hook, usually done to prevent > the device from waking the system since on OMAP, any IRQ can be > configured to wake the system. > This does not sound correct. disable_irq_wake should be used for this. A driver may need to mask its interrupt before suspending but this should not also disable it as a wakeup source. > If a driver's suspend hook calls disable_irq() and the system is > suspended before the lazy disable happens in the next handler, then > the system will be suspended with that device's IRQ still enabled. > Without an irq_chip->disable hook, that will result in that device IRQ > waking up the system if it fires. The platform suspend code needs to write the wakeup mask into interrupt controller the before entering suspend. -- Arve Hjønnevåg