Re: HTC: touchscreen driver

["Arve Hjønnevåg" <arve@android.com>]

On Thu, Jul 23, 2009 at 2:25 PM, Pavel Machek<pavel@ucw.cz> wrote:
> On Tue 2009-07-21 18:12:03, Arve Hj?nnev?g wrote:
>> On Tue, Jul 21, 2009 at 3:11 AM, Pavel Machek<pavel@ucw.cz> wrote:
>> > On Sun 2009-07-19 20:43:10, Arve Hj?nnev?g wrote:
>> >> On Sun, Jul 19, 2009 at 2:23 PM, Pavel Machek<pavel@ucw.cz> wrote:
>> >> >
>> >> >> > Applying small patch on top of cleaned up driver should be better than
>> >> >> > carrying whole driver itself, right?
>> >> >>
>> >> >> Perhaps, but the only problem I encountered with this driver so far
>> >> >> was when calling disable_irq from the interrupt handler stopped
>> >> >> working on non-smp systems in 2.6.30 (which is another patch you
>> >> >> should probably apply first).
>> >> >
>> >> > How do I get that patch? git pull on msm-2.6.29 tree?
>> >>
>> >> No it is in the android-msm-2.6.30-rc2-test branch at
>> >> git://android.git.kernel.org/kernel/experimental.git (commit
>> >> 9f89902daf7a3c6fdd6b0c7494f3cc82d5e09217).
>> >
>> > Could you inline the patch? I tried to pull it off the web interface,
>> > but it did not work for some reason.
>>
>> git fetch git://android.git.kernel.org/kernel/experimental.git
>> android-msm-2.6.30-rc2-test
>> git cherry-pick 9f89902daf7a3c6fdd6b0c7494f3cc82d5e09217
>
> So I spent 10 minutes downloading patch you could have inlined... only
> to find out that review already pointed nosync issue (and I fixed swap
> independetly)...

Sorry, I thought it was clear what it contained.

I'm a little confused why you did not already have this though. This
is the same branch I pushed specifically so you could get at it a
month ago, and you said you got it booting back then.

>
>> That way you will hopefully not add question marks to my name.
>
> ...and I still don't know what your name is. My terminal displays "Arve
> Hj#罩nev##g <arve@android.com>" :-(.

That does not look right. It displays correctly for me in the mailing
list archives:
http://lkml.org/lkml/2009/7/21/496

gitk also works for me. git log only works if you are using a utf8
terminal (or have set the character set in your gitconfig).

-- 
Arve Hjønnevåg