From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65386214A6C for ; Thu, 17 Apr 2025 07:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744873664; cv=none; b=Dj9Q7TsAUNXSiDIPTqMCV+35NQ5zhZHKVNC7rRBcKsNZjgxC2zVBL85glIrLB/3kTXoKuqiJLRM74/bjzhDscd+qUn6G5Vog6MRpiMtvCX02FHx8CU4YTIU2Eh7rwHJz/UBpYcerbEsL3K8dZUYQ2N5MEZEC2SKZNe3NzH3rkOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744873664; c=relaxed/simple; bh=VcH901qcljndDAkf6FKG0mL6ZW97IUPuNheWF2bFrwA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dqbWsIFrFTTgvgWKnIHE1WJzLhxbjc8CZcc7S9bi4slPhCURnHmu4G5uGT5UnoQHPL2Lr8WvGx10VB4870vy4jDWBPYngIrUXNtRyPJ1Pod2b9wctHjeC3cykSqBF28ZgQk7o+jXkwUOSxjGu2w+vSyF3/g6H+TmWEXN3CFgkgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1fF3agDF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=7PqzR5Rz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=1fF3agDF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=7PqzR5Rz; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1fF3agDF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="7PqzR5Rz"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="1fF3agDF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="7PqzR5Rz" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1390C1F457; Thu, 17 Apr 2025 07:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744873655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w+J/9yJ67aCLrPoS8RxKMt4E/7nOHMoej776qBrTYZE=; b=1fF3agDF2wSsAzGB5ey594HlOXQH2H5zofC+ZaKlmURmcWFxMpADn/oOxCEdBD2exQ5UKC R6i6zr+5Wd2Zd2/26Md9qZQygObkxXiuSNwwhajeqzq0uutdpoku478Ib4p/BAQea2Rc3w 08k/1x9zUq2NbUvExAEHkyLj/8//KcY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744873655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w+J/9yJ67aCLrPoS8RxKMt4E/7nOHMoej776qBrTYZE=; b=7PqzR5Rzfe3fMt1/sgxADxY3KNP9StqUImSAI1B1kNJZp/+iu5FzLZVbOlm79FvST0DZKz tLZpDKNfHzfu8xDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1fF3agDF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7PqzR5Rz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744873655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w+J/9yJ67aCLrPoS8RxKMt4E/7nOHMoej776qBrTYZE=; b=1fF3agDF2wSsAzGB5ey594HlOXQH2H5zofC+ZaKlmURmcWFxMpADn/oOxCEdBD2exQ5UKC R6i6zr+5Wd2Zd2/26Md9qZQygObkxXiuSNwwhajeqzq0uutdpoku478Ib4p/BAQea2Rc3w 08k/1x9zUq2NbUvExAEHkyLj/8//KcY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744873655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w+J/9yJ67aCLrPoS8RxKMt4E/7nOHMoej776qBrTYZE=; b=7PqzR5Rzfe3fMt1/sgxADxY3KNP9StqUImSAI1B1kNJZp/+iu5FzLZVbOlm79FvST0DZKz tLZpDKNfHzfu8xDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9CA9F137CF; Thu, 17 Apr 2025 07:07:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Lb5mJLaoAGjGSAAAD6G6ig (envelope-from ); Thu, 17 Apr 2025 07:07:34 +0000 Message-ID: Date: Thu, 17 Apr 2025 09:07:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] virtgpu: don't reset on shutdown To: Gerd Hoffmann , "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Eric Auger , Eric Auger , Jocelyn Falempe , David Airlie , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev References: <8490dbeb6f79ed039e6c11d121002618972538a3.1744293540.git.mst@redhat.com> <20250415095922-mutt-send-email-mst@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1390C1F457 X-Spam-Level: X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[vger.kernel.org,redhat.com,chromium.org,gmail.com,linux.intel.com,kernel.org,ffwll.ch,linux.alibaba.com,lists.freedesktop.org,lists.linux.dev]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -4.51 X-Spam-Flag: NO Hi Am 16.04.25 um 15:57 schrieb Gerd Hoffmann: > On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: >> On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: >>> Hi, >>> >>>> +static void virtio_gpu_shutdown(struct virtio_device *vdev) >>>> +{ >>>> + /* >>>> + * drm does its own synchronization on shutdown. >>>> + * Do nothing here, opt out of device reset. >>>> + */ >>> I think a call to 'drm_dev_unplug()' is what you need here. >>> >>> take care, >>> Gerd >> My patch reverts the behaviour back to what it was, so pls go >> ahead and send a patch on top? I won't be able to explain >> what it does and why it's needed. > See below. Untested. > > Eric, can you give this a spin? > > thanks, > Gerd > > ----------------------- cut here ------------------------------- > From f3051dd52cb2004232941e6d2cbc0c694e290534 Mon Sep 17 00:00:00 2001 > From: Gerd Hoffmann > Date: Wed, 16 Apr 2025 15:53:04 +0200 > Subject: [PATCH] drm/virtio: implement virtio_gpu_shutdown > > Calling drm_dev_unplug() is the drm way to say the device > is gone and can not be accessed any more. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c > index e32e680c7197..71c6ccad4b99 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c > @@ -130,10 +130,10 @@ static void virtio_gpu_remove(struct virtio_device *vdev) > > static void virtio_gpu_shutdown(struct virtio_device *vdev) > { > - /* > - * drm does its own synchronization on shutdown. > - * Do nothing here, opt out of device reset. > - */ > + struct drm_device *dev = vdev->priv; > + > + /* stop talking to the device */ > + drm_dev_unplug(dev); > } It's the correct approach but also requires drm_dev_enter() and drm_dev_exit() around all of the driver's hardware access. Best regards Thomas > > static void virtio_gpu_config_changed(struct virtio_device *vdev) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)