From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 713DE3803D6 for ; Fri, 27 Feb 2026 16:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208183; cv=none; b=pVNtwOrmrp0Np762YeXdY5T3UP4BUCS2xAWVmHBrfK29XDhJ60PgDy4zcywJ8qe0diKnpZ5iv6FvNE/tlbFt15dj7QipoAWgZCssQUBxi7IA2hibo/U6nM9lkWMqHne8S7Ztn5uEitmeUgokIpL+FWD5NIrwh8rdcyjcE03JuC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208183; c=relaxed/simple; bh=lgtXmGFSF9WY/XUFIhf4Vzr/tUP/hhtMLJySoSZVeZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nuCeyifNGkDPVyBfshy+bZRJI7v8dLI3ke+sQje2GnwjLM4oQz7GyYvYgwtNJqU5S2SEe9PyIrh9a/46VnJ+a5hP5nDFUs4i5GTDmhVje4XWM7isiD407RJWwbA8jfsGytFkCZCqcAliySjeaB5vJZlEPJdiO+Fs+ghJed3cCKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lXPb1/AX; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lXPb1/AX" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7d4bc9e48bbso1001842a34.2 for ; Fri, 27 Feb 2026 08:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772208181; x=1772812981; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z/Dmx8lTYztz9z703bG8Wc8eXMBbKmKs50/Oz3D1ABs=; b=lXPb1/AXLW+dJ2bDAP8+d+p7kPkS8gSom65u25sefDUfF+GMwCGVaeRAWM+e2zG22Z 4Gdy30tenkClsg2Tt+I3GZqEMmFF3LYNw2MlBGZtBBo79slNyp2Ts2ERpjwcrlVGNxc0 WVsN+4p+ZhgC3RbxORHfEeq7M+7H2E74BFjIqCrN/gUPaLzMv48+KSWvNZyLRM/XsOlu b70ie/H5u9IJvqrxoHHAsTJr8OYAtAkrKKi3LiSWkqE+q0+mFUKL4UERNsxET18/958l QNqY9KSCnr1U/Z+40W53QWIXlnbuBIS61g0beVxEU08AtTzpb3zvXQmbyx2rliIrpkRp Y5xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772208181; x=1772812981; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z/Dmx8lTYztz9z703bG8Wc8eXMBbKmKs50/Oz3D1ABs=; b=U61ZiLvQDMKa4qBAOSyRlIG+qZ7JOOmJx6esjZ/vGI7X5l8D0JsMjqfKALbyhXnGDo YnroxTIQYaiArKX4FqqAiDM8uqNHIEk2Domo4Pzz+UgpYHBQ6J7EiMgJV5iVzx6+lsWu UbHO7SsH/y/E5gStZY70zOuGuhlAfbdBJ19nLYJDKUko28GgL8X2lqF6PBGHRiJ5hst4 1G1Nb+60SQxep2FuGv3snweca4RhwCKK87jueo64n7mEnIJSA7RVvgVtwLFxc5L+S/UR sWr4gEwXn453tlHST0uFJzAanqtBfrpE/4LhdlFBZnaB2iqCtKf9Xyg+F8qJTPpNd7IW Wxgg== X-Forwarded-Encrypted: i=1; AJvYcCXVLtEXN3HpMCf29/sakon7q6pQcYdBw0EwZ6z5QULgy5FYoISuQKQdQVSH03UwS0+trqLXilr9Ri0YiJM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzibfd67Ge9xSg7BnlDlx6JIZBg9h359Bozw3AqBEoe7MZj7A8f 6RhcLhRgx+v6U4cRbsQWo7NGVoGSJSdSBT6JPw8syKIsw4EzSZlXOjWC5yAuulf3PZA= X-Gm-Gg: ATEYQzwCxefddpuvLu3iGTAiTH78RlNi5ih2AxeUzCU3AmrrgHb9DXD2R7y2WPfK6AL e7HYhg3+oQLk/0gv5TqMFJ1rZNkrTVUcpMR+xhdSNKan362V4PKNsEu7wSw3MuinedadoJHBWi8 7+QxFTbng6v92pUtC7Z1mnIbXOlk+jl8VN5jEHg8WczAo5BgQki7GsC74tLCkZ2AcKBdAKCtQPE mf7LXR25KHJKmQyRjJ9flVQQW0f5gjiK5mMwIXpjlxyNqU5u/mzJRDU6nBzaRpLCdRWfzvIPENM 9MnNb4iyNl2V9D6ZULhd8GmQ/m+qxVYiTrodQVYN01+F2HSg6s40E6nFFWlCNOqLtIJM8yLXkV5 V7VC3o1crakKgM4UWbolGdwVj+BWqIwQM7JkplM4WMpc4sNJI5VpRwoiOzLf1FhpTDjAaouC5bi r+0h/MJL/su0VQR35i9JYApIUMAapAee4I20u5+0PJnGFx6AvO9ggVcz4gjmUrsfdK0A7XySrpZ Q== X-Received: by 2002:a05:6830:2647:b0:7cf:d30d:b12d with SMTP id 46e09a7af769-7d591c17be9mr2536685a34.32.1772208180907; Fri, 27 Feb 2026 08:03:00 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:876a:e36c:76c7:e6d4? ([2600:8803:e7e4:500:876a:e36c:76c7:e6d4]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d5998bc31asm483170a34.23.2026.02.27.08.02.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 08:02:59 -0800 (PST) Message-ID: Date: Fri, 27 Feb 2026 10:02:59 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] iio: filter: admv8818: Add missing error code To: Ethan Tidmore , Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260227061424.1135505-1-ethantidmore06@gmail.com> <20260227061424.1135505-2-ethantidmore06@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260227061424.1135505-2-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 12:14 AM, Ethan Tidmore wrote: > If the macro FIELD_GET() returns an error code the function returns > with 0 because ret was just confirmed to be 0 a few lines above. > > Add error code. > > Detected by Smatch: > drivers/iio/filter/admv8818.c:335 __admv8818_read_hpf_freq() warn: > missing error code? 'ret' > > drivers/iio/filter/admv8818.c:376 __admv8818_read_lpf_freq() > warn: missing error code? 'ret' > > Fixes: f34fe888ad054 ("iio:filter:admv8818: add support for ADMV8818") > Signed-off-by: Ethan Tidmore > --- > drivers/iio/filter/admv8818.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c > index e494fd33911b..4d5e7a9d806a 100644 > --- a/drivers/iio/filter/admv8818.c > +++ b/drivers/iio/filter/admv8818.c > @@ -332,7 +332,7 @@ static int __admv8818_read_hpf_freq(struct admv8818_state *st, u64 *hpf_freq) > hpf_band = FIELD_GET(ADMV8818_SW_IN_WR0_MSK, data); > if (!hpf_band || hpf_band > 4) { > *hpf_freq = 0; > - return ret; > + return -EINVAL; > } > > ret = regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); > @@ -373,7 +373,7 @@ static int __admv8818_read_lpf_freq(struct admv8818_state *st, u64 *lpf_freq) > lpf_band = FIELD_GET(ADMV8818_SW_OUT_WR0_MSK, data); > if (!lpf_band || lpf_band > 4) { > *lpf_freq = 0; > - return ret; > + return -EINVAL; > } > > ret = regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); Probably for a separate patch since this is considered a fix... The returns at the end of these functions should be changed to return 0. It is the only possible value ret can have at that point.