mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Chao Yu <chao@kernel.org>, Chao Yu <yuchao0@huawei.com>,
	"open list:JFS FILESYSTEM" <jfs-discussion@lists.sourceforge.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()
Date: Thu, 20 Sep 2018 09:24:53 -0500	[thread overview]
Message-ID: <d6360818-2808-d5a6-119d-97cb506b7d15@oracle.com> (raw)
In-Reply-To: <be3a41fb-9a83-19a8-b3da-ca91500471fc@kernel.org>

On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
> 
> Any comments?

Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks,
Dave

> 
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>>  fs/jfs/inode.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>> index 054cc761b426..805ae9e8944a 100644
>> --- a/fs/jfs/inode.c
>> +++ b/fs/jfs/inode.c
>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>>  			/*
>>  			 * Free the inode from the quota allocation.
>>  			 */
>> -			dquot_initialize(inode);
>>  			dquot_free_inode(inode);
>>  		}
>>  	} else {
>>

  reply	other threads:[~2018-09-20 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17  7:12 Chao Yu
2018-09-20 14:18 ` Chao Yu
2018-09-20 14:24   ` Dave Kleikamp [this message]
2018-09-20 14:32     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6360818-2808-d5a6-119d-97cb506b7d15@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=chao@kernel.org \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®